-----BEGIN PGP SIGNED MESSAGE-----
Nice start. A couple discussion points:
void debug(const char *format, ...)
instead of #ifdef DEBUG, can we have an env var that controls this
on/off? (No recompile)
Thought about that. I didn't know if we wanted a "production" version
that didn't have all the debug spew. I can rework it to use an
#define NSFLAG "NAMESPACE=1"
What is the purpose of this?
I was unsure if we needed to know that we were running with namespaces
and modify our behavior in mock.py. If it turns out we don't need to
do anything differently, I'll pull this out of the environment.
// elevate our privileges
if (setreuid (geteuid (), geteuid ()))
error("setreuid failed: %s", strerror(errno));
debug("running with uid: %d, gid: %d\n", getuid(), getgid());
Is this necessary? It seems to me like this is something that can be
done in mock.py for the cases where it is necessary, as mock.py might
need to know the user id of the person running mock, and so it can
switch back to that user for writing output files.
So, you're thinking we just to seteuid/setegid rather than setting the
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.3 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org
-----END PGP SIGNATURE-----