Javier Palacios wrote:
>> I have tested, and found a very little bug (fixed in patch).
I've updated the
>> wiki page about debian deployment to reflect this. The sample preseed
>> files will probably need to be fixed in order to use the new security repo,
>> but I cannot check until tomorrow, when I get some hardware to deploy.
>>
Too lazy to carry the laptop to home on monday, so deployment test should
wait. But at least I was able to setup a github repository, after plenty of not
successful trials. I have commited there the patch for autocreation of repos,
and I believe the proper url to see that is
http://github.com/javiplx/cobbler-debian/commits/debian
Any comments about the best ways of using github are more than welcome.
Javier Palacios
_______________________________________________
cobbler mailing list
cobbler(a)lists.fedorahosted.org
https://fedorahosted.org/mailman/listinfo/cobbler
your github usage is fine, and I like the way this works, but I have
some code comments that need to be addressed...
First off, don't use the "seed_data" to_datastruct/from_datastruct to
manipulate cobbler objects. Those are intended to load things to/from
the serializers but there are higher level APIs to use.
Instead you should do as the rest of the code in that module does:
repo = repo.Repo(...)
repo.set_some_value(value)
repo.set_another_value(value)
etc, rather than taking that shortcut.
The "ERROR - process_repos is an abstract method" exceptions should be
replaced by:
raise exceptions.NotImplementedError
Make those changes and I can work on merging this in and also testing
things on my end.
In git you can do this just by making those changes on top of your
existing commit (just make the changes, commit again, and push) -- no
need to revert what you've already done.
Thanks!!!
--Michael