[copr] master: add python-flexmock to deps of frontend (2c30fb0)

[Miroslav Suchý]

Repository : http://git.fedorahosted.org/cgit/copr.git

On branch  : master

> ---------------------------------------------------------------
commit 2c30fb0d407ea533f7a8921f90bbed051b7311bd
Author: Miroslav Suchý <msuchy(a)redhat.com&gt;
Date:   Tue Jun 25 14:43:50 2013 +0200

    add python-flexmock to deps of frontend
    
    addressing:
    _____________________________________ ERROR collecting
tests/test_views/test_coprs_ns/test_coprs_general.py
______________________________________
    tests/test_views/test_coprs_ns/test_coprs_general.py:4: in <module>
>    from flexmock import flexmock 
    E   ImportError: No module
named flexmock


> ---------------------------------------------------------------
 copr.spec |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/copr.spec b/copr.spec
index 8ac71c8..19c40f4 100644
--- a/copr.spec
+++ b/copr.spec
@@ -58,6 +58,7 @@ Requires:	python-psycopg2
 Requires:	python-whoosh
 # for tests:
 Requires:	pytest
+Requires:   python-flexmock
 
 %description frontend
 COPR is lightway Koji. It allows you to create new project in WebUI, and

[Bohuslav Kabrda]

----- Original Message -----
>  Repository : http://git.fedorahosted.org/cgit/copr.git
>  
>  On branch  : master
>  
>  >---------------------------------------------------------------
>  
>  commit 2c30fb0d407ea533f7a8921f90bbed051b7311bd
>  Author: Miroslav Suchý <msuchy(a)redhat.com&gt;
>  Date:   Tue Jun 25 14:43:50 2013 +0200
>  
>      add python-flexmock to deps of frontend
>      
>      addressing:
>      _____________________________________ ERROR collecting
>      tests/test_views/test_coprs_ns/test_coprs_general.py
>      ______________________________________
>      tests/test_views/test_coprs_ns/test_coprs_general.py:4: in <module>
>      >   from flexmock import flexmock
>      E   ImportError: No module named flexmock
>  
>  
>  >---------------------------------------------------------------
>  
>   copr.spec |    1 +
>   1 files changed, 1 insertions(+), 0 deletions(-)
>  
>  diff --git a/copr.spec b/copr.spec
>  index 8ac71c8..19c40f4 100644
>  --- a/copr.spec
>  +++ b/copr.spec
>  @@ -58,6 +58,7 @@ Requires:	python-psycopg2
>   Requires:	python-whoosh
>   # for tests:
>   Requires:	pytest
>  +Requires:   python-flexmock
>   
>   %description frontend
>   COPR is lightway Koji. It allows you to create new project in WebUI, and
>  
>   
This should probably go to BuildRequires and the tests should be run with sqlite during
build, IMO.


-- 
Regards,
Bohuslav "Slavek" Kabrda.

[Miroslav Suchý]

On 06/26/2013 07:55 AM, Bohuslav Kabrda wrote:
>  This should probably go to BuildRequires and the tests should be run
> with sqlite during build, IMO. 
It should be definitely in Requires as long as we ship those unit tests 
so you can actually run them.

Yes, I agree that next step will be to create %check section and run 
test there (and add BR). But I'm not there yet.

-- 
Miroslav Suchy
Red Hat Systems Management Engineering