Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=460304
Jens Petersen <petersen(a)redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #316154|0 |1
is obsolete| |
--- Comment #31 from Jens Petersen <petersen(a)redhat.com> 2008-09-09 04:42:15 EDT ---
Created an attachment (id=316159)
--> (https://bugzilla.redhat.com/attachment.cgi?id=316159)
macros.ghc
Hopefully a final fix to ghc_gen_filelists. (I am kind of tempted just to drop
its argument though.)
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=460304
--- Comment #28 from Jens Petersen <petersen(a)redhat.com> 2008-09-09 03:47:32 EDT ---
Created an attachment (id=316154)
--> (https://bugzilla.redhat.com/attachment.cgi?id=316154)
macros.ghc
I think to avoid confusion with whitespace it is better to reinstate
%cabal_build and %cabal_haddock even though they are trivial.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=460304
--- Comment #26 from Jens Petersen <petersen(a)redhat.com> 2008-09-09 03:14:12 EDT ---
I agree, if a library creates some test or demo programs then that can be
handled case-by-case by package review like any other package. I don't think
we need to specify in the guidelines explicitly whether should be be excluded
or subpackaged, but one of those two options is likely in general.
I think the macros in comment 14 can handle Cabal just fine. I'll attach a
spec file.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=460304
--- Comment #25 from Rajesh Krishnan <fedora(a)krishnan.cc> 2008-09-05 19:26:19 EDT ---
BRYAN:
1. The original set of macros published as part of Jens/Yaakov's updates
would not correctly build cabal packages with mixed case package names. The
"internal_name" variable is necessary to take care of that.
2. For the argument against deleting the executables after building, see point
(2.) in the next section below.
YAAKOV:
1. I just compared the macros.ghc you submitted with the one I have and they
are identical. Thank you for taking care of my concerns in your updated
macros.ghc submission.
2. As for your question about the necessity of the test executables, I have
no idea, because I am not the original author of the Crypto cabal package. So
in order to avoid ticking-off the very few developers who might actually need
those under some special circumstances (the tiniest bit of crypto-related
software being too important these days), I did not feel it was appropriate to
miss out that detail by simply deleting those executables after compilation.
Hence the logical choice of spinning out the -devel package with those
executables.
3. As for the %test macro, I think at this time the ghc-crypto rpm spec does
not really need that. I felt it would be just easier for me to provide the
users of ghc-crypto with the means of testing it for themselves (with the
executables in ghc-crypto-devel package).
4. I am building a lot of other cabal packages with our latest macros.ghc and
will let everyone know if we need any updates.
-Rajesh
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=460304
--- Comment #24 from Yaakov Nemoy <loupgaroublond(a)gmail.com> 2008-09-05 12:23:36 EDT ---
Rajesh, are any of those executables necessary at all? Are they needed for
testing the package itself after being built? Are they necessary for testing
packages that depend on them?
In any case, I think you should name the spec file 'ghc-crypto.spec' and iclude
a comment stating the exception. There's no need to revise the guidelines for
something like this. Secondly, if the executables are not needed once the
package has been built, note that there is a %test section in the RPM spec that
is not often used. Feel free to take advantage of this.
If they are needed for dependencies, then just spit out a -devel package,
comment why it's needed, and comment on it in the review as well.
As for the makefile business, The macros are based on bryan's work.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=460304
--- Comment #23 from Bryan O'Sullivan <bos(a)serpentine.com> 2008-09-05 12:15:12 EDT ---
Rajesh, your macros are substantially different from Jens's current version.
Is there anything about Jens's that would cause you problems?
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=460304
--- Comment #22 from Bryan O'Sullivan <bos(a)serpentine.com> 2008-09-05 12:09:38 EDT ---
Re comment #19:
Rajesh, if the build for a package is creating test executables that serve no
useful purpose, just delete them after cabal installs them. There is no reason
we would want to package or ship useless binaries.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.