Re: [PATCH 00/12] iptraf-ng: another cleanups

[Nikola Pajkovsky]

Vitezslav Samel <vitezslav(a)samel.cz&gt; writes:

>  Vitezslav Samel (12):
>    hostmon(): shuffle with init/destroy code
>    hostmon(): call init/destroy functions in LIFO order
>    hostmon(): optimize: move some checks away from the hot path
>    hostmon(): refactor various time computing
>    hostmon(): change do {} while() construct into while() {}
>    timer.c: cleanup printelapsedtime()
>    print_packet_drops(): use getmaxy() to get the last line
>    packet_size_breakdown(): refactor initialization
>    packet_size_breakdown(): optimize: move some checks away from the hot path
>    packet_size_breakdown(): refactor various time computing
>    packet_size_breakdown(): change do {} while() construct into while() {}
>    refactor pktsize.c to print in and out counters
>
>   src/deskman.c  |   4 +-
>   src/deskman.h  |   2 +-
>   src/detstats.c |   4 +-
>   src/hostmon.c  | 168 +++++++++++++-------------
>   src/ifstats.c  |   4 +-
>   src/itrafmon.c |   5 +-
>   src/pktsize.c  | 366 +++++++++++++++++++++++++++++++--------------------------
>   src/serv.c     |   4 +-
>   src/timer.c    |  12 +-
>   src/timer.h    |   2 +-
>   10 files changed, 299 insertions(+), 272 deletions(-) 
Except one coding style for cycle, all seems to be good. Thanks. Pushed

+	for(unsigned int i = 0; i < SIZES; i++) {

-- 
Nikola