Vitezslav Samel <vitezslav(a)samel.cz> writes:
On Tue, Apr 24, 2012 at 10:46:46AM +0200, Nikola Pajkovsky wrote:
> Vitezslav Samel <vitezslav(a)samel.cz> writes:
>
> > Besides rename move declarations for functions from utils.c
> > from iptraf-ng-compat.h into utils.h and use this new header file
> > where needed.
> >
> > Signed-off-by: Vitezslav Samel <vitezslav(a)samel.cz>
> > ---
> > src/Makefile.am | 3 ++-
> > src/fltedit.c | 1 +
> > src/fltmgr.c | 1 +
> > src/hostmon.c | 1 +
> > src/ifstats.c | 1 +
> > src/ipfrag.c | 1 +
> > src/iptraf-ng-compat.h | 7 -------
> > src/isdntab.c | 1 +
> > src/landesc.c | 1 +
> > src/othptab.c | 1 +
> > src/parse-options.c | 1 +
> > src/promisc.c | 1 +
> > src/serv.c | 1 +
> > src/strbuf.c | 1 +
> > src/tcptable.c | 1 +
> > src/{wrapper.c => utils.c} | 0
> > src/utils.h | 11 +++++++++++
> > 17 files changed, 26 insertions(+), 8 deletions(-)
> > rename src/{wrapper.c => utils.c} (100%)
> > create mode 100644 src/utils.h
>
> NACK I want to have it as it is.
So at least we should move declarations from iptraf-ng-compat.h into
wrapper.h
you need iptraf-ng-compat.h everywhere and also x* fncs are also
everywhere so it's pointless to add another header everywhere.
--
Nikola