Re: [PATCH] grab-logs.sh

[Laura Abbott]

On 06/21/2016 09:15 PM, Miguel Flores Silverio wrote:
>  Download the build logs for a list of architectures. Only
>  downloads the logs if they are present in the server. Logs
>  are saved in logs directory within the source tree.
>
>  By default looks at build logs for i686, x86_64, noarch and
>  armv7hl.
>  
Looks good, applied.

>  Signed-off-by: Miguel Flores Silverio <floresmigu3l(a)gmail.com&gt;
>  ---
>   scripts/grab-logs.sh | 31 +++++++++++++++++++++++++------
>   1 file changed, 25 insertions(+), 6 deletions(-)
>
>  diff --git a/scripts/grab-logs.sh b/scripts/grab-logs.sh
>  index 5df5735..b58dfff 100755
>  --- a/scripts/grab-logs.sh
>  +++ b/scripts/grab-logs.sh
>  @@ -1,16 +1,35 @@
>   #!/bin/sh
>  +# Script helps download the build logs for the current tree.
>  +# The downloaded logs will be saved in a logs/ within the
>  +# tree.
>  +
>  +BASEDIR="$(dirname "$(cd $(dirname $BASH_SOURCE[0]) &&
> pwd)")"
>  +pushd $BASEDIR > /dev/null
>
>   VER=$(fedpkg verrel)
>   ver=$(echo $VER | sed -e 's/-/ /g' | awk '{print $2}')
>   rev=$(echo $VER | sed -e 's/-/ /g' | awk '{print $3}')
>
>  -if [ -d logs ]; then
>  -  DIR=logs/
>  +# keep logs in one place. If logs directory does not exist, make it.
>  +if [ -d "$BASEDIR/logs" ]; then
>  +  DIR="$BASEDIR/logs"
>   else
>  -  DIR=./
>  +  mkdir "$BASEDIR/logs"
>  +  DIR="$BASEDIR/logs"
>   fi
>
>  -wget -O $DIR/build-$VER-i686.log
> http://kojipkgs.fedoraproject.org/packages/kernel/$ver/$rev/data/logs/i68...
>  -wget -O $DIR/build-$VER-x86-64.log
> http://kojipkgs.fedoraproject.org/packages/kernel/$ver/$rev/data/logs/x86...
>  -wget -O $DIR/build-$VER-noarch.log
> http://kojipkgs.fedoraproject.org/packages/kernel/$ver/$rev/data/logs/noa...
>  +# Common architectures that have build logs.
>  +ARCHS[0]=i686
>  +ARCHS[1]=x86_64
>  +ARCHS[2]=noarch
>  +ARCHS[3]=armv7hl
>
>  +for arch in ${ARCHS[@]}; do
>  +   
> URL=http://kojipkgs.fedoraproject.org/packages/kernel/$ver/$rev/data/logs...
>  +    # Only download logs if exist
>  +    wget --spider -q $URL
>  +    if [ $? -eq 0 ]; then
>  +	wget -O $DIR/build-$VER-$arch.log $URL
>  +    fi
>  +done
>  +popd > /dev/null
>  --
>  2.7.4
>