Hi,
I'm using koji as a python package in my scripts. Usually I develop them
inside of a virtual environment. I do not use system packages[1] in
virtualenv.
Currently I'm not able to install koji and it dependencies inside
virtualenv easily. Having koji in PiPy would help me. That way I can
just specify it in my requirements.txt or in install_requires of my
setup.py. I *guess*[2] one way to do that is to have setup.py in koji
code and add some extra steps as part of the release process to publish
it there.
What do you think about this?
For some time now I use my own setup.py. I guess it is not ready for PR
so I'd love to see comments on this as well:
https://pagure.io/fork/pbabinca/koji/blob/setup_WIP/f/setup.py
[1] Among other reasons I'd like to have environment isolated from the
system as much as possible.
[2] I have never maintained package on PiPy.
--
Pavol Babincak
We're very close to koji 1.12. We're targeting the middle of next week.
I'm using this PR to cover final release details:
https://pagure.io/koji/pull-request/361
We're in a code freeze until then to focus on testing. I'm only taking
critical bug fixes or doc changes related to the release.
If you're in a position to, now would be a great time to grab these bits
and put them through their paces.
I was cleaning up my unmerged branches and found an addendum to the
systemd support from a couple years ago.
https://pagure.io/fork/mikem/koji/commits/systemd-redundant-logfiles
This change:
- ensures that kojid, kojivmd, and kojira have explicit --logfile options
- allows this option to be specified as 'none'
- adds --logfile=none to their respective systemd ExecStart commands
The reason is that when systemd is in use, we're currently double
logging, both in the traditional log files (e.g. kojid.log) and in the
systemd journal (e.g. see journalctl -u kojid).
The thing is, I'm curious how folks feel about this. Is it a good idea,
or will it be to confusing for the original log files to be absent?
I suppose another option to avoid double logging would be to keep the
log files and turn of the logging in systemd (or at least most of it). I
suppose it could also be made more configurable.