Re: [mutt-kz] release based on mutt-1.5.24 (#118)
by Karel Zak
On Thu, Jan 07, 2016 at 07:18:16AM -0800, Thomas Klausner wrote:
> Please merge the changes and make a release based on that version Thank you!
I'll very probably merge stuff from neomutt/mutt-kz (from Richard
Russon). The result should be mutt-kz synced with the current mutt
upstream.
It seems that after years mutt upstream is again active, so it's
probably good idea to regularly rebase our changes to keep things up
to date. (It means that "git pull --force" or so will be necessary to
fetch mutt-kz.)
The next step (I hope end of this week or begin of the next week) will
be release mutt-kz tarball.
And sorry for my delays, I'm busy with util-linux and with work on
RHEL...
Karel
--
Karel Zak <kzak(a)redhat.com>
http://karelzak.blogspot.com
7 years, 8 months
marking message as unread
by Jan Hutař
Hello,
I'm trying to mark message as unread after I opened it. I have this in
.muttrc:
virtual-mailboxes \
'INBOX' 'notmuch://?query=tag:inbox and NOT tag:archive' \
[...]
macro index U "<modify-labels>+unread\n"
but it just do not work on majority of messages. When I run mutt with,
say, "-d 2", it says:
[2016-03-14 21:28:13] nm: find message (bug-1249655-203706-qqlNkcbOWR(a)bugzilla.redhat.com)
[2016-03-14 21:28:13] nm: tags modify: '+unread'
[2016-03-14 21:28:13] nm: add tag: 'unread'
[2016-03-14 21:28:13] nm: tags update requested (bug-1249655-203706-qqlNkcbOWR(a)bugzilla.redhat.com)
[2016-03-14 21:28:13] nm: tags unchanged
[2016-03-14 21:28:13] nm: db close
and message is still shown as read, but tags seems to be set correctly:
$ notmuch dump id:bug-1249655-203706-qqlNkcbOWR@bugzilla.redhat.com
+inbox +unread -- id:bug-1249655-203706-qqlNkcbOWR@bugzilla.redhat.com
I'm most probably missing something obvious. Looks like that "unread"
tag is not used by Mutt to determine if message was already red. Could
somebody please point me in right direction?
Thank you in advance,
Jan
--
Jan Hutar Systems Management QA
jhutar(a)redhat.com Red Hat, Inc.
7 years, 8 months
#118 and beyond...
by Richard Russon
In issue #118 Thomas Klausner asks if someone could update notmuch to
mutt-1.5.24. Done. That, and much much more...
mutt-kz consists of quite a few elements:
Major features:
sidebar
notmuch
Minor features:
conditional dates
index-color
nested-if
progress bar
quasi-delete
status-color
tls-sni
Misc:
bug-fixes for Mutt
However, the current version of mutt-kz is missing:
Some important mutt code commits
Most of the translation commits
Many bugfixes in the minor features
My wonderful new version of the sidebar patch
I've brought mutt-kz up-to-date. The branch names in [] refer to my
work repository on github. The diagram, below, may help you understand
the relationships between the branches (red: mutt; green: sidebar;
cyan: notmuch).
https://github.com/neomutt/flatcap
https://flatcap.org/mutt/flatcap.png
I started with the latest version of mutt-kz [kz/master] which contains
394 commits since the Last Common Ancestor with mutt [mutt/lca].
Rebase onto:
[mutt/1.5.24] -> [kz/rebase1] (160 commits)
[combine/minor/20160307] -> [kz/rebase2] (148 commits)
[combine/sidebar/20160307] -> [kz/rebase3] (129 commits)
Any mutt-kz bug-fixes that weren't notuch-related have been moved to
either [feature/bugfix] or the relevant feature branch.
The minor features have been merged into [combine/minor/20160307]
The icons represent the order in which the features were merged.
This brings mutt-kz now up-to-date, but still needs a little tidying.
Refactor:
[kz/refactor1] (116 commits)
Tidy remaining rebase artifacts
I've tweaked the history a little here (in very minor ways).
e.g. folded pairs like:
Introduce typo
Fix typo
Move notmuch build changes to beginning
[kz/refactor2] [kz/release2] (110 + 2 commits)
Factor out kz-build-related commit
The kz-version number isn't a part of the notmuch code.
gitignore changes folded
kz-versioning changes folded
[kz/release2] (yellow on diagram) represents the kz-versioning.
These are changes you want for mutt-kz, but don't want to be merged
into Mutt upstream.
[kz/refactor3] [kz/release3] (110 + 2 commits)
Trailing whitespace
Rework all the commits to prevent the introduction of trailing
whitespace.
Tidy commit messages
Most commits in the repo were prefixed with "notmuch:". Now the
notmuch code is isolated in its own branch, the prefix isn't
needed.
Fold commit messages
Fit to git standards
The code REMAINS THE SAME, but the 'churn' is reduced
This should making rebasing simpler.
I've been very careful not to make any functional changes and the
authorship of commits is maintained.
What next?
Adoption -- I would like you to adopt one of these branches.
Ideally [kz/refactor3]
Once you've picked a repo, I will start submitting changes to:
Tidy the Sidebar code that Notmuch introduces
Fix mutt-kz's remaining Sidebar issues
Rename <sidebar-toggle> to <sidebar-toggle-virtual>
Sidebar currently has <sidebar-toggle-visible>
Integrate [combine/extra/20160307]
Number of useful small features
Integrate other downstream/distro bugfixes
Hope this all makes sense.
--
Rich Russon (FlatCap) <rich(a)flatcap.org>
7 years, 8 months
