Make error on OS X 10.7.3

[Daren Lord]

After the sidebar patch was added I am now getting this error while trying to run make:

Undefined symbols for architecture x86_64:
  "_strdupa", referenced from:
      _draw_sidebar in sidebar.o
ld: symbol(s) not found for architecture x86_64
collect2: ld returned 1 exit status
make[2]: *** [mutt] Error 1
make[1]: *** [all-recursive] Error 1
make: *** [all] Error 2

Any suggestions?

Dlord

[Darryl L. Pierce]

On Wed, Mar 28, 2012 at 11:07:31AM -0600, Daren Lord wrote:
> After the sidebar patch was added I am now getting this error while trying to run make:
>
> Undefined symbols for architecture x86_64:
>   "_strdupa", referenced from:
>       _draw_sidebar in sidebar.o
> ld: symbol(s) not found for architecture x86_64
> collect2: ld returned 1 exit status
> make[2]: *** [mutt] Error 1
> make[1]: *** [all-recursive] Error 1
> make: *** [all] Error 2
>
> Any suggestions?

I've had a build error on F16 from the get-go but haven't had time to
address the problem.

[PATCH] Replace strdupa with strdup/free

[David Sterba]

Hi,

please try this one, works for me here, I don't have a Mac OS to test.

---
From: David Sterba

strdupa breaks Mac OS build.

Signed-off-by: David Sterba 
---
 sidebar.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/sidebar.c b/sidebar.c
index 6eff2f0..0129c96 100644
--- a/sidebar.c
+++ b/sidebar.c
@@ -288,7 +288,7 @@ int draw_sidebar(int menu) {
    		continue;
    	}

-		safe_path = strdupa(tmp->path);
+		safe_path = strdup(tmp->path);
    	if ( !safe_path ) {
    		move( lines, 0 );
    		lines++;
@@ -296,6 +296,7 @@ int draw_sidebar(int menu) {
    	}

base_name = basename(safe_path);
+		free(safe_path);
    	if ( !base_name ) {
    		move( lines, 0 );
    		lines++;

[PATCH] Replace strdupa with strdup/free

[Karel Zak]

On Thu, Mar 29, 2012 at 02:07:23AM +0200, David Sterba wrote:
> sidebar.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)

Applied, thanks.