#6013: Cannot update dead.package file
by Fedora Release Engineering
#6013: Cannot update dead.package file
----------------------------+------------------------
Reporter: orion | Owner: rel-eng@…
Type: defect | Status: new
Milestone: Fedora 21 Beta | Component: git
Keywords: | Blocked By:
Blocking: |
----------------------------+------------------------
I was trying to update the dead.package file for dkim-milter, but get:
{{{
Total 3 (delta 0), reused 0 (delta 0)
remote: W refs/heads/master dkim-milter orion DENIED by fallthru
remote: error: hook declined to update refs/heads/master
To ssh://orion@pkgs.fedoraproject.org/dkim-milter
! [remote rejected] master -> master (hook declined)
error: failed to push some refs to 'ssh://orion@pkgs.fedoraproject.org
/dkim-milter'
Could not execute commit: Command '['git', 'push']' returned non-zero exit
status 1
}}}
This is still needed at times to put better information into dead.package
files. I am a proven packager.
--
Ticket URL: <https://fedorahosted.org/rel-eng/ticket/6013>
Fedora Release Engineering <http://fedorahosted.org/rel-eng>
Release Engineering for the Fedora Project
9 years, 6 months
[releng] find_unblocked_orphans: Reword label
by Till Maas
commit 3c657271b37c136727eb29cbc06b83f7070ac70c
Author: Till Maas <opensource(a)till.name>
Date: Tue Oct 7 23:23:18 2014 +0200
find_unblocked_orphans: Reword label
scripts/find_unblocked_orphans.py | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
---
diff --git a/scripts/find_unblocked_orphans.py b/scripts/find_unblocked_orphans.py
index 071f7fe..2760397 100755
--- a/scripts/find_unblocked_orphans.py
+++ b/scripts/find_unblocked_orphans.py
@@ -599,7 +599,7 @@ def package_info(packages, release, orphans=None, failed=None):
breaking = breaking.union(set(deps.keys()))
if breaking:
- info += wrap_and_format("Affected packages", sorted(breaking))
+ info += wrap_and_format("Depending packages", sorted(breaking))
if failed:
info += "\nFTBFS: " + " ".join(failed)
9 years, 6 months
[releng] find_unblocked_orphans: Fix spelling
by Till Maas
commit c9275fc589ce0cc7d663da1721f234ebd774fddb
Author: Till Maas <opensource(a)till.name>
Date: Tue Oct 7 22:42:25 2014 +0200
find_unblocked_orphans: Fix spelling
scripts/find_unblocked_orphans.py | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
---
diff --git a/scripts/find_unblocked_orphans.py b/scripts/find_unblocked_orphans.py
index 63f5ad4..071f7fe 100755
--- a/scripts/find_unblocked_orphans.py
+++ b/scripts/find_unblocked_orphans.py
@@ -658,7 +658,7 @@ def main():
print text
if args.mailto or args.send:
- subject = "Orphan packages in " + args.release
+ subject = "Orphaned packages in " + args.release
if args.mailto:
mailto = args.mailto
else:
9 years, 6 months
[releng] find_unblocked_orphans: Show address count
by Till Maas
commit dbadea6b3a7bf0bdaa0bbc379518ae34337692df
Author: Till Maas <opensource(a)till.name>
Date: Tue Oct 7 22:36:55 2014 +0200
find_unblocked_orphans: Show address count
scripts/find_unblocked_orphans.py | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
---
diff --git a/scripts/find_unblocked_orphans.py b/scripts/find_unblocked_orphans.py
index 09a866c..63f5ad4 100755
--- a/scripts/find_unblocked_orphans.py
+++ b/scripts/find_unblocked_orphans.py
@@ -671,7 +671,8 @@ def main():
if mail_errors:
sys.stderr.write("mail errors: " + repr(mail_errors) + "\n")
- sys.stderr.write("Addresses: " + ", ".join(addresses) + "\n")
+ sys.stderr.write("Addresses ({}): {}\n".format(len(addresses),
+ ", ".join(addresses)))
if __name__ == "__main__":
main()
9 years, 6 months
[releng] find_unblocked_orphans: Add more length details
by Till Maas
commit e9182fafeb32891913f9519ecab877fb8b093a33
Author: Till Maas <opensource(a)till.name>
Date: Tue Oct 7 22:34:45 2014 +0200
find_unblocked_orphans: Add more length details
scripts/find_unblocked_orphans.py | 6 ++++--
1 files changed, 4 insertions(+), 2 deletions(-)
---
diff --git a/scripts/find_unblocked_orphans.py b/scripts/find_unblocked_orphans.py
index ad633dc..09a866c 100755
--- a/scripts/find_unblocked_orphans.py
+++ b/scripts/find_unblocked_orphans.py
@@ -427,7 +427,8 @@ class DepChecker(object):
allow_more = True
seen = []
while True:
- sys.stderr.write("to_check: {0}\n".format(repr(to_check)))
+ sys.stderr.write("to_check ({}): {}\n".format(len(to_check),
+ repr(to_check)))
check_next = to_check.pop()
seen.append(check_next)
dependent_packages = self.find_dependent_packages(check_next,
@@ -524,7 +525,8 @@ def dependency_info(dep_map, affected_people, people_dict):
info = ""
for package_name, subdict in dep_map.items():
if subdict:
- info += "Depending on: %s\n" % package_name
+ info += "Depending on: {} ({})\n".format(package_name,
+ len(subdict.keys()))
for fedora_package, dependent_packages in subdict.items():
people = people_dict[fedora_package]
for p in people:
9 years, 6 months
[releng] find_unblocked_orphans: Output currently checked package
by Till Maas
commit 844e47b2464bd03debb635396eb4f491f707619d
Author: Till Maas <opensource(a)till.name>
Date: Tue Oct 7 22:12:22 2014 +0200
find_unblocked_orphans: Output currently checked package
scripts/find_unblocked_orphans.py | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
---
diff --git a/scripts/find_unblocked_orphans.py b/scripts/find_unblocked_orphans.py
index 5964d1f..ad633dc 100755
--- a/scripts/find_unblocked_orphans.py
+++ b/scripts/find_unblocked_orphans.py
@@ -420,6 +420,7 @@ class DepChecker(object):
# dict for all dependent packages for each to-be-removed package
dep_map = OrderedDict()
for name in packages:
+ sys.stderr.write("Checking: {0}\n".format(name))
ignore = rpm_pkg_names
dep_map[name] = OrderedDict()
to_check = [name]
9 years, 6 months
[releng] find_unblocked_orphans: Output list of breaking packages
by Till Maas
commit 090d26b00bedcb257aa3040193c80374442ceb79
Author: Till Maas <opensource(a)till.name>
Date: Tue Oct 7 22:12:02 2014 +0200
find_unblocked_orphans: Output list of breaking packages
scripts/find_unblocked_orphans.py | 8 ++++++++
1 files changed, 8 insertions(+), 0 deletions(-)
---
diff --git a/scripts/find_unblocked_orphans.py b/scripts/find_unblocked_orphans.py
index 486b6f4..5964d1f 100755
--- a/scripts/find_unblocked_orphans.py
+++ b/scripts/find_unblocked_orphans.py
@@ -590,6 +590,14 @@ def package_info(packages, release, orphans=None, failed=None):
info += wrap_and_format("Orphans (not depended on)",
orphans_not_breaking_deps)
+
+ breaking = set()
+ for package, deps in dep_map.items():
+ breaking = breaking.union(set(deps.keys()))
+
+ if breaking:
+ info += wrap_and_format("Affected packages", sorted(breaking))
+
if failed:
info += "\nFTBFS: " + " ".join(failed)
info += "\n"
9 years, 6 months
[releng] find_unblocked_orphans: Indent wrapped lines
by Till Maas
commit 7e434930c7d1c6b0e62c57d10c01ec5108caa376
Author: Till Maas <opensource(a)till.name>
Date: Tue Oct 7 22:11:43 2014 +0200
find_unblocked_orphans: Indent wrapped lines
scripts/find_unblocked_orphans.py | 5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
---
diff --git a/scripts/find_unblocked_orphans.py b/scripts/find_unblocked_orphans.py
index 0de345d..486b6f4 100755
--- a/scripts/find_unblocked_orphans.py
+++ b/scripts/find_unblocked_orphans.py
@@ -568,8 +568,9 @@ def package_info(packages, release, orphans=None, failed=None):
info += "Affected (co)maintainers\n"
info += maintainer_info(affected_people)
- wrapper = textwrap.TextWrapper(break_long_words=False,
- break_on_hyphens=False)
+ wrapper = textwrap.TextWrapper(
+ break_long_words=False, subsequent_indent=" ", break_on_hyphens=False
+ )
def wrap_and_format(label, pkgs):
count = len(pkgs)
9 years, 6 months
[releng] find_unblocked_orphans: Wrap list of orphans
by Till Maas
commit d4fb31b8b642948324641b3058ae7e223e0647a3
Author: Till Maas <opensource(a)till.name>
Date: Tue Oct 7 21:45:08 2014 +0200
find_unblocked_orphans: Wrap list of orphans
scripts/find_unblocked_orphans.py | 27 +++++++++++++++++++--------
1 files changed, 19 insertions(+), 8 deletions(-)
---
diff --git a/scripts/find_unblocked_orphans.py b/scripts/find_unblocked_orphans.py
index 2b004ee..0de345d 100755
--- a/scripts/find_unblocked_orphans.py
+++ b/scripts/find_unblocked_orphans.py
@@ -22,6 +22,7 @@ import hashlib
import os
import smtplib
import sys
+import textwrap
import koji
import pkgdb2client
@@ -416,7 +417,7 @@ class DepChecker(object):
bin_pkgs = self.by_src.get(name, [])
rpm_pkg_names.extend([p.name for p in bin_pkgs])
- # dict for all dependent package for each to-be-removed package
+ # dict for all dependent packages for each to-be-removed package
dep_map = OrderedDict()
for name in packages:
ignore = rpm_pkg_names
@@ -566,18 +567,28 @@ def package_info(packages, release, orphans=None, failed=None):
info += "Affected (co)maintainers\n"
info += maintainer_info(affected_people)
+
+ wrapper = textwrap.TextWrapper(break_long_words=False,
+ break_on_hyphens=False)
+
+ def wrap_and_format(label, pkgs):
+ count = len(pkgs)
+ text = "{} ({}): {}".format(label, count, " ".join(pkgs))
+ wrappedtext = "\n" + wrapper.fill(text) + "\n\n"
+ return wrappedtext
+
if orphans:
- info += "\norphans: " + " ".join(orphans)
- info += "\n\n"
+ info += wrap_and_format("Orphans", orphans)
+
orphans_breaking_deps = [o for o in orphans if
o in dep_map and dep_map[o]]
- info += "orphans (depended on): " + " ".join(orphans_breaking_deps)
- info += "\n\n"
+ info += wrap_and_format("Orphans (dependend on)", orphans_breaking_deps)
+
orphans_not_breaking_deps = [o for o in orphans if
o not in dep_map or not dep_map[o]]
- info += "orphans (not depended on): " + " ".join(
- orphans_not_breaking_deps)
- info += "\n\n"
+
+ info += wrap_and_format("Orphans (not depended on)",
+ orphans_not_breaking_deps)
if failed:
info += "\nFTBFS: " + " ".join(failed)
info += "\n"
9 years, 6 months
[releng] find_unblocked_orphans: Handle pkgdb2 errors
by Till Maas
commit 9bea7961aa127ca3c9d2d2250c7ab92d5c1129ab
Author: Till Maas <opensource(a)till.name>
Date: Tue Oct 7 20:46:22 2014 +0200
find_unblocked_orphans: Handle pkgdb2 errors
Packages Fedora Branched without a branch for Fedora Branched cause an
error when getting maintainer information. However, this should never
happen:
https://github.com/fedora-infra/pkgdb2/issues/95
scripts/find_unblocked_orphans.py | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
---
diff --git a/scripts/find_unblocked_orphans.py b/scripts/find_unblocked_orphans.py
index ceea03b..2b004ee 100755
--- a/scripts/find_unblocked_orphans.py
+++ b/scripts/find_unblocked_orphans.py
@@ -199,7 +199,9 @@ def get_people(package, branch=RAWHIDE_RELEASE["branch"]):
sys.stderr.write(
"Error getting maintainer of package {} on branch {}\n".format(
package, branch))
+ # FIXME: Write proper traceback
sys.stderr.write(str(e))
+ return []
pkginfo = pkginfo["packages"][0]
people_ = [pkginfo["point_of_contact"]]
people_.extend(associated(pkginfo, exclude=people_))
9 years, 6 months