[releng] PR #6627 `Update 2wk atomic script to update tree ref`

[Patrick "マルタインアンドレアス" Uiterwijk]

puiterwijk opened a new pull-request against the project: `releng` that you are following:
``
Update 2wk atomic script to update tree ref
``

To reply, visit the link below or just reply to this email
https://pagure.io/releng/pull-request/6627

[Dusty Mabe]

dustymabe commented on the pull-request: `Update 2wk atomic script to update tree ref` that you are following:
``
are rpm-ostree and ostree installed on the machine this is going to run on?
``

To reply, visit the link below or just reply to this email
https://pagure.io/releng/pull-request/6627

[Dusty Mabe]

dustymabe commented on the pull-request: `Update 2wk atomic script to update tree ref` that you are following:
``
we should probably make `fedora-atomic/25/x86_64/docker-host` be a constant/variable that is set at the top of the script and we access here. 
``

To reply, visit the link below or just reply to this email
https://pagure.io/releng/pull-request/6627

[Adam Miller]

maxamillion commented on the pull-request: `Update 2wk atomic script to update tree ref` that you are following:
``
Can that be sub'd in by the release param that's passed in at the command line instead of hard coded?
``

To reply, visit the link below or just reply to this email
https://pagure.io/releng/pull-request/6627

[Dusty Mabe]

dustymabe commented on the pull-request: `Update 2wk atomic script to update tree ref` that you are following:
``
would you rather take this as an argument to the script rather than prompting someone for it? 
``

To reply, visit the link below or just reply to this email
https://pagure.io/releng/pull-request/6627

[Dusty Mabe]

dustymabe commented on the pull-request: `Update 2wk atomic script to update tree ref` that you are following:
``
where is `tree_rev` defined? 
``

To reply, visit the link below or just reply to this email
https://pagure.io/releng/pull-request/6627

[Adam Miller]

maxamillion commented on the pull-request: `Update 2wk atomic script to update tree ref` that you are following:
``
:thumbsup: 
``

To reply, visit the link below or just reply to this email
https://pagure.io/releng/pull-request/6627

[Dusty Mabe]

dustymabe commented on the pull-request: `Update 2wk atomic script to update tree ref` that you are following:
``
a little late, but +1
``

To reply, visit the link below or just reply to this email
https://pagure.io/releng/pull-request/6627

[Colin Walters]

walters commented on the pull-request: `Update 2wk atomic script to update tree ref` that you are following:
``
This should be `ostree`.
``

To reply, visit the link below or just reply to this email
https://pagure.io/releng/pull-request/6627

[Colin Walters]

walters commented on the pull-request: `Update 2wk atomic script to update tree ref` that you are following:
``
Also `ostree`.
``

To reply, visit the link below or just reply to this email
https://pagure.io/releng/pull-request/6627

[Colin Walters]

walters commented on the pull-request: `Update 2wk atomic script to update tree ref` that you are following:
``
diff --git a/scripts/push-two-week-atomic.py b/scripts/push-two-week-atomic.py
index 7de32a0..a4a0b0a 100755
--- a/scripts/push-two-week-atomic.py
+++ b/scripts/push-two-week-atomic.py
@@ -550,7 +550,7 @@ def prune_old_composes(prune_base_dir, prune_limit):

def move_tree_commit(release, old_commit, new_commit):
     log.info("Creating diff")
-    diff_cmd = ["/usr/bin/rpm-ostree", "static-delta", "generate", "--repo",
+    diff_cmd = ["/usr/bin/ostree", "static-delta", "generate", "--repo",
                 ATOMIC_DIR % release, "--if-not-exists", "--from", old_commit,
                 "--to", new_commit]
     if subprocess.call(diff_cmd):
@@ -561,7 +561,7 @@ def move_tree_commit(release, old_commit, new_commit):
                            TARGET_REF % release), 'w') as f:
         f.write(new_commit)

-    summary_cmd = ["/usr/bin/rpm-ostree", "summary", "-u", "--repo",
+    summary_cmd = ["/usr/bin/ostree", "summary", "-u", "--repo",
                    ATOMIC_DIR % release]
     if subprocess.call(summary_cmd):
         log.error("move_tree_commit: summary update failed: %s", summary_cmd)

``

To reply, visit the link below or just reply to this email
https://pagure.io/releng/pull-request/6627

[Dennis Gilmore]

ausil commented on the pull-request: `Update 2wk atomic script to update tree ref` that you are following:
``
We should use ${basearch} in here in order to prep for the future
``

To reply, visit the link below or just reply to this email
https://pagure.io/releng/pull-request/6627

[Dusty Mabe]

dustymabe commented on the pull-request: `Update 2wk atomic script to update tree ref` that you are following:
``
hey @ausil, where would basearch be set? would it be another variable that we set? would it be detected from the platform we're running on? 
``

To reply, visit the link below or just reply to this email
https://pagure.io/releng/pull-request/6627

[Dusty Mabe]

dustymabe commented on the pull-request: `Update 2wk atomic script to update tree ref` that you are following:
``
@walters - https://pagure.io/releng/pull-request/6628
``

To reply, visit the link below or just reply to this email
https://pagure.io/releng/pull-request/6627

[Dennis Gilmore]

ausil commented on the pull-request: `Update 2wk atomic script to update tree ref` that you are following:
``
@dustymabe it should be in the compose metadata
``

To reply, visit the link below or just reply to this email
https://pagure.io/releng/pull-request/6627