[pungi-fedora] PR #1267: f39: fix container-nightly.sh script to sync the right thing

[Kevin Fenzi]

kevin opened a new pull-request against the project: `pungi-fedora` that you are
following:
``
f39: fix container-nightly.sh script to sync the right thing
``

To reply, visit the link below or just reply to this email
https://pagure.io/pungi-fedora/pull-request/1267

[Adam Williamson]

adamwill commented on the pull-request: `f39: fix container-nightly.sh script to sync the
right thing` that you are following:
``
This looks right to me. sync-ostree-base-containers is for converting atomic desktop
ostrees to container images, and publishing those, so it should run after composes that
build those. `sync-latest-container-base-image.sh` should be the right thing to run after
building the things that `container-nightly.sh` / `fedora-container.conf` build.

Note this problem exists on f40 and main branches, too. We don't actually run the
script on those branches yet, but we should fix it there too for when we will.

I'm not *sure* we actually should be running `sync-ostree-base-containers` in its
current form at all any more, but @walters could maybe advise. We now build proper OCI
images for Silverblue, Kinoite and Sericea at least - which are the three variants that
script can convert from ostrees - in the current dev releases (40 and Rawhide). If
anything, we should be publishing *those*, not publishing images built by converting
ostrees?

But maybe I'm misunderstanding something there.
``

To reply, visit the link below or just reply to this email
https://pagure.io/pungi-fedora/pull-request/1267

[Kevin Fenzi]

kevin commented on the pull-request: `f39: fix container-nightly.sh script to sync the
right thing` that you are following:
``
Note that for f40/rawhide we do these as part of the main nightly.sh, it's only
'stable' releases that we build those nightly. 


``

To reply, visit the link below or just reply to this email
https://pagure.io/pungi-fedora/pull-request/1267

[Adam Williamson]

adamwill commented on the pull-request: `f39: fix container-nightly.sh script to sync the
right thing` that you are following:
``
yes, but once f40 goes stable, we will "naturally" just start doing
container-nightly.sh on it instead, and if we don't fix this for those branches now,
this problem will show up there when that happens. as for main, well, all the release
branches fork off it at first, so we should fix it there too so f41, f42 etc. don't
inherit the problem.

as for the 'should we be doing sync-ostree-base-containers at all?" thing, we
seem to be tracking that at https://pagure.io/releng/issue/10399 , thanks @siosm for
pointing me there.
``

To reply, visit the link below or just reply to this email
https://pagure.io/pungi-fedora/pull-request/1267

[Samyak Jain]

jnsamyak commented on the pull-request: `f39: fix container-nightly.sh script to sync the
right thing` that you are following:
``
This looks like Lgtm for f39, but do we have to do this for f40? 
Because, as @adamwill mentioned we will be doing it with `container-nightly.sh` f40+
onwards,? 
``

To reply, visit the link below or just reply to this email
https://pagure.io/pungi-fedora/pull-request/1267

[Adam Williamson]

adamwill commented on the pull-request: `f39: fix container-nightly.sh script to sync the
right thing` that you are following:
``
well, we should go ahead and merge it for f39 at least, I guess...
``

To reply, visit the link below or just reply to this email
https://pagure.io/pungi-fedora/pull-request/1267

[Samyak Jain]

jnsamyak merged a pull-request against the project: `pungi-fedora` that you are
following.

Merged pull-request:

``
f39: fix container-nightly.sh script to sync the right thing
``

https://pagure.io/pungi-fedora/pull-request/1267

[Samyak Jain]

jnsamyak commented on the pull-request: `f39: fix container-nightly.sh script to sync the
right thing` that you are following:
``
I thought I merged it in the afternoon but I guess I did not! I'll discuss more about
this in our releng call today :D for f40+
``

To reply, visit the link below or just reply to this email
https://pagure.io/pungi-fedora/pull-request/1267

[Kevin Fenzi]

kevin commented on the pull-request: `f39: fix container-nightly.sh script to sync the
right thing` that you are following:
``
Yeah... if someone wants to do a f40 pr to change that, we could, or we could wait for the
discussion above. ;) 

+1 to merge this now. 

``

To reply, visit the link below or just reply to this email
https://pagure.io/pungi-fedora/pull-request/1267

[Timothée Ravier]

siosm commented on the pull-request: `f39: fix container-nightly.sh script to sync the
right thing` that you are following:
``
I don't fully know / understand if it's related to this change yet but about 16
days ago, https://quay.io/repository/fedora/fedora-silverblue?tab=tags stopped being
updated, right around when this change got merged.

See also:
https://discussion.fedoraproject.org/t/quay-io-fedora-fedora-silverblue-3...
``

To reply, visit the link below or just reply to this email
https://pagure.io/pungi-fedora/pull-request/1267

[Kevin Fenzi]

kevin commented on the pull-request: `f39: fix container-nightly.sh script to sync the
right thing` that you are following:
``
Yep. It did. :( we forgot oci images... 

We need to enhance the script bodhi uses to sync ostree commits for updates probibly to
also generate/push the oci images. ;( 

In the mean time I will manually do a sync now... 
``

To reply, visit the link below or just reply to this email
https://pagure.io/pungi-fedora/pull-request/1267

[Timothée Ravier]

siosm commented on the pull-request: `f39: fix container-nightly.sh script to sync the
right thing` that you are following:
``
OK, maybe let's focus on https://pagure.io/releng/issue/10399 instead of investing
time into fixing the sync script as ideally it will go away soon.
``

To reply, visit the link below or just reply to this email
https://pagure.io/pungi-fedora/pull-request/1267