On Fri, 2015-07-10 at 11:05 -0500, Dennis Gilmore wrote:
On Friday, July 10, 2015 04:58:26 PM you wrote:
On Fri, 2015-07-10 at 09:03 -0500, Dennis Gilmore wrote:
On Friday, July 10, 2015 09:58:59 AM Mathieu Bridon wrote:
leading up to this we hit an issue where the mounting was not happening correctly. it turns out that when you pass os.path.join two variables the first one is silently dropped. not sure if this is a bug in python or the way that os.path.join is supposed to work.
Do you mean this?
>>> os.path.join('/foo', '/bar') == '/bar' TrueIf this is what you mean, then it indeed is the expected behaviour:
If a component is an absolute path, all previous components are thrown away and joining continues from the absolute path component.
https://docs.python.org/2/library/os.path.html#os.path.joinThis is the case, so we will have to get a patch into koji to not us os.path.join
Or rather, only pass it absolute paths as the first argument.
What code in Koji does that?
https://git.fedorahosted.org/cgit/koji/tree/plugins/runroot.py#n54
Attached patch should fix the issue.
On Fri, Jul 10, 2015 at 11:21 AM, Mathieu Bridon bochecha@daitauha.fr wrote:
On Fri, 2015-07-10 at 11:05 -0500, Dennis Gilmore wrote:
On Friday, July 10, 2015 04:58:26 PM you wrote:
On Fri, 2015-07-10 at 09:03 -0500, Dennis Gilmore wrote:
On Friday, July 10, 2015 09:58:59 AM Mathieu Bridon wrote:
leading up to this we hit an issue where the mounting was not happening correctly. it turns out that when you pass os.path.join two variables the first one is silently dropped. not sure if this is a bug in python or the way that os.path.join is supposed to work.
Do you mean this?
>>> os.path.join('/foo', '/bar') == '/bar' TrueIf this is what you mean, then it indeed is the expected behaviour:
If a component is an absolute path, all previous components are thrown away and joining continues from the absolute path component.
https://docs.python.org/2/library/os.path.html#os.path.joinThis is the case, so we will have to get a patch into koji to not us os.path.join
Or rather, only pass it absolute paths as the first argument.
What code in Koji does that?
https://git.fedorahosted.org/cgit/koji/tree/plugins/runroot.py#n54
Attached patch should fix the issue.
+1 to the patch.
-AdamM
-- Mathieu _______________________________________________ rel-eng mailing list rel-eng@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/rel-eng
On Friday, July 10, 2015 06:21:37 PM Mathieu Bridon wrote:
On Fri, 2015-07-10 at 11:05 -0500, Dennis Gilmore wrote:
On Friday, July 10, 2015 04:58:26 PM you wrote:
On Fri, 2015-07-10 at 09:03 -0500, Dennis Gilmore wrote:
On Friday, July 10, 2015 09:58:59 AM Mathieu Bridon wrote:
leading up to this we hit an issue where the mounting was not happening correctly. it turns out that when you pass os.path.join two variables the first one is silently dropped. not sure if this is a bug in python or the way that os.path.join is supposed to work.
Do you mean this?
>>> os.path.join('/foo', '/bar') == '/bar' TrueIf this is what you mean, then it indeed is the expected
behaviour:
If a component is an absolute path, all previous components are thrown away and joining continues from the absolute path component.
https://docs.python.org/2/library/os.path.html#os.path.joinThis is the case, so we will have to get a patch into koji to not us os.path.join
Or rather, only pass it absolute paths as the first argument.
What code in Koji does that?
https://git.fedorahosted.org/cgit/koji/tree/plugins/runroot.py#n54
Attached patch should fix the issue.
Applied thanks
Dennis
rel-eng@lists.fedoraproject.org
-
Adam Miller -
Dennis Gilmore -
Mathieu Bridon