[PATCH] Fix incorrect comparisons in fedora-release-* subpackages

[Stephen Gallagher]

Hi Dennis. I finally found the bad comparisons and rewrote them to be 
more readable. The attached patch should be the correct fix to the os-
release stuff (I've tested it six ways to sunday in mock, so I'm 
pretty confident this time).

[Stephen Gallagher]

On Fri, 2015-03-13 at 21:40 -0400, Stephen Gallagher wrote:
>  Hi Dennis. I finally found the bad comparisons and rewrote them to 
>  be  more readable. The attached patch should be the correct fix to 
>  the os- release stuff (I've tested it six ways to sunday in mock, so 
>  I'm  pretty confident this time). 

Attached, please find also a converged patch that brings the changes 
from the Rawhide branch back to Fedora 22.

This patch brings in the following changes from Rawhide:
* Generate os-release based on product subpackages
* Remove the -nonproduct subpackage
* Eliminate Conflicts between subpackages
* Add preset file for workstation to disable sshd


As with the Rawhide patch I'm applying to, I ran numerous tests in a 
mock chroot, both with using the standard @buildsys-build and then 
adding on new packages as well as modifying it so that the initial 
installation in the chroot included this and the new firewall patches 
at the same time.

All of it worked properly and upgraded cleanly. I'm ready to say that 
this should get pulled in so we can get it into the next Beta TC.

[Dennis Gilmore]

On Monday, March 16, 2015 10:04:04 AM Stephen Gallagher wrote:
>  On Fri, 2015-03-13 at 21:40 -0400, Stephen Gallagher wrote:
>  > Hi Dennis. I finally found the bad comparisons and rewrote them to
>  > be  more readable. The attached patch should be the correct fix to
>  > the os- release stuff (I've tested it six ways to sunday in mock, so
>  > I'm  pretty confident this time).
>  
>  Attached, please find also a converged patch that brings the changes
>  from the Rawhide branch back to Fedora 22.
>  
>  This patch brings in the following changes from Rawhide:
>  * Generate os-release based on product subpackages
>  * Remove the -nonproduct subpackage
>  * Eliminate Conflicts between subpackages
>  * Add preset file for workstation to disable sshd
>  
>  
>  As with the Rawhide patch I'm applying to, I ran numerous tests in a
>  mock chroot, both with using the standard @buildsys-build and then
>  adding on new packages as well as modifying it so that the initial
>  installation in the chroot included this and the new firewall patches
>  at the same time.
>  
>  All of it worked properly and upgraded cleanly. I'm ready to say that
>  this should get pulled in so we can get it into the next Beta TC. 
I would like to have a bit more testing in rawhide first 

Dennis

[Stephen Gallagher]

On Tue, 2015-03-17 at 13:01 -0500, Dennis Gilmore wrote:
>  On Monday, March 16, 2015 10:04:04 AM Stephen Gallagher wrote:
>  > On Fri, 2015-03-13 at 21:40 -0400, Stephen Gallagher wrote:
>  > > Hi Dennis. I finally found the bad comparisons and rewrote them 
>  > > to be  more readable. The attached patch should be the correct 
>  > > fix to the os- release stuff (I've tested it six ways to sunday 
>  > > in mock, so I'm  pretty confident this time).
>  > 
>  > Attached, please find also a converged patch that brings the 
>  > changes from the Rawhide branch back to Fedora 22.
>  > 
>  > This patch brings in the following changes from Rawhide:
>  > * Generate os-release based on product subpackages
>  > * Remove the -nonproduct subpackage
>  > * Eliminate Conflicts between subpackages
>  > * Add preset file for workstation to disable sshd
>  > 
>  > 
>  > As with the Rawhide patch I'm applying to, I ran numerous tests in 
>  > a mock chroot, both with using the standard @buildsys-build and 
>  > then adding on new packages as well as modifying it so that the 
>  > initial installation in the chroot included this and the new 
>  > firewall patches at the same time.
>  > 
>  > All of it worked properly and upgraded cleanly. I'm ready to say 
>  > that this should get pulled in so we can get it into the next Beta 
>  > TC.
>  
>  I would like to have a bit more testing in rawhide first 
>   
Updated patch that contains all of the tweaks we made in Rawhide.

[Dennis Gilmore]

On Friday, March 13, 2015 09:40:50 PM Stephen Gallagher wrote:
>  Hi Dennis. I finally found the bad comparisons and rewrote them to
> be
>  more readable. The attached patch should be the correct fix to the os-
>  release stuff (I've tested it six ways to sunday in mock, so I'm
>  pretty confident this time). 
applied, thanks

Additionally I made all the symlinks relative and added a missing space that 
caused one symlink to not be created

Dennis