5:20 a.m.
jvymazal opened a new pull-request against the project: `pungi-fedora` that you are
following:
``
added rsyslog module
``
To reply, visit the link below or just reply to this email
https://pagure.io/pungi-fedora/pull-request/428
5:39 a.m.
psabata commented on the pull-request: `added rsyslog module` that you are following:
``
LGTM, +1.
``
To reply, visit the link below or just reply to this email
https://pagure.io/pungi-fedora/pull-request/428
8:37 a.m.
sgallagh commented on the pull-request: `added rsyslog module` that you are following:
``
LGTM as well
``
To reply, visit the link below or just reply to this email
https://pagure.io/pungi-fedora/pull-request/428
8:46 a.m.
sgallagh commented on the pull-request: `added rsyslog module` that you are following:
``
I'm amending my previous statement. From the patch perspective, this is fine. But
please do not merge this until post-Beta. I have concerns about destabilizing the release
process.
Also, the rsyslog module is built against `bootstrap:master` but runtime-requires
`platform:f27`; it's possible that there are ABI differences between the two. This
should be checked.
``
To reply, visit the link below or just reply to this email
https://pagure.io/pungi-fedora/pull-request/428
8:33 a.m.
sgallagh commented on the pull-request: `added rsyslog module` that you are following:
``
@jvymazal Could you rebase this and address the comments I made above, please?
``
To reply, visit the link below or just reply to this email
https://pagure.io/pungi-fedora/pull-request/428
8:41 a.m.
jvymazal commented on the pull-request: `added rsyslog module` that you are following:
``
@sgallagh rebased module against 'bootstrap: f27', build passed, should be ready
for merge
``
To reply, visit the link below or just reply to this email
https://pagure.io/pungi-fedora/pull-request/428
10:08 a.m.
sgallagh commented on the pull-request: `added rsyslog module` that you are following:
``
Ack
@mohanboddu Please merge this.
``
To reply, visit the link below or just reply to this email
https://pagure.io/pungi-fedora/pull-request/428
6:17 a.m.
tmlcoch merged a pull-request against the project: `pungi-fedora` that you are following.
Merged pull-request:
``
added rsyslog module
``
https://pagure.io/pungi-fedora/pull-request/428
3:41 a.m.
ppisar commented on the pull-request: `added rsyslog module` that you are following:
``
The rsyslog-master is broken because it mixes platform streams.
``
To reply, visit the link below or just reply to this email
https://pagure.io/pungi-fedora/pull-request/428
6:17 a.m.
jvymazal commented on the pull-request: `added rsyslog module` that you are following:
``
The rsyslog-master is broken because it mixes platform streams.
Should be fixed now by
https://src.fedoraproject.org/modules/rsyslog/c/848a88b093f197ed2d48b67ba...
``
To reply, visit the link below or just reply to this email
https://pagure.io/pungi-fedora/pull-request/428
2334
days inactive
2366
days old
rel-eng@lists.fedoraproject.org
9 comments
5 participants
participants (5)
-
Jiří Vymazal -
Petr Pisar
-
Petr Šabata
-
Stephen Gallagher
-
Tomas Mlcoch