#6421: [PATCH] update-fullfilelist unconditionally changes ctime of fullfilelist
-----------------------------+------------------------
Reporter: tibbs | Owner: rel-eng@…
Type: defect | Status: new
Milestone: Fedora 24 Alpha | Component: other
Keywords: | Blocked By:
Blocking: |
-----------------------------+------------------------
The update-fullfilelist script:
https://infrastructure.fedoraproject.org/cgit/ansible.git/tree/roles/bodh...
/update-fullfilelist
unconditionally calls chmod on the two file lists. chmod unconditionally
updates the inode ctime even when the permissions don't change. Normally
nobody would care, but fullfiletimelist records the ctime change as part
of its detection of hardlinking. This results in a change in
fullfiletimelist, so quick-fedora-mirror clients will make an unnecessary
connectiondo an unnecessary transfer of the file list.
I would suggest moving the chmod into the conditional. Alternately you
could explicitly set umask to 022. Patch for the former attached..
--
Ticket URL: <
https://fedorahosted.org/rel-eng/ticket/6421>
Fedora Release Engineering <
http://fedorahosted.org/rel-eng>
Release Engineering for the Fedora Project