Review Request 124: Automatically start roles after deploy()

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-fedoraserver.rhcloud.com/r/124/
-----------------------------------------------------------

Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, Simo Sorce,
and Thomas Woerner.


Repository: rolekit


Description
-------

Many server installers will automatically start their services as
soon as installation is complete (such as FreeIPA). This means that
the real state of the system will disagree with rolekit's view of
it. To be sure that we are aligned, it makes the most sense to just
ensure that all roles are deployed into the RUNNING state.


Diffs
-----

  src/rolekit/server/rolebase.py 7f960bf41206c2552996936839a100325382e3be 

Diff: http://reviewboard-fedoraserver.rhcloud.com/r/124/diff/


Testing
-------

Deployed a domain controller and verified that after deployment, 'rolectl status
domaincontroller/teeceetwo.sgallagh.rht' reported "running" and
'systemctl status role-domaincontroller-teeceetwo.sgallagh.rht.target' reported
"active".


Thanks,

Stephen Gallagher

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-fedoraserver.rhcloud.com/r/124/
-----------------------------------------------------------

(Updated Nov. 21, 2014, 5:02 p.m.)


Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, Simo Sorce,
and Thomas Woerner.


Bugs: 35
    https://fedorahosted.org/rolekit/ticket/35


Repository: rolekit


Description
-------

Many server installers will automatically start their services as
soon as installation is complete (such as FreeIPA). This means that
the real state of the system will disagree with rolekit's view of
it. To be sure that we are aligned, it makes the most sense to just
ensure that all roles are deployed into the RUNNING state.


Diffs
-----

  src/rolekit/server/rolebase.py 7f960bf41206c2552996936839a100325382e3be 

Diff: http://reviewboard-fedoraserver.rhcloud.com/r/124/diff/


Testing
-------

Deployed a domain controller and verified that after deployment, 'rolectl status
domaincontroller/teeceetwo.sgallagh.rht' reported "running" and
'systemctl status role-domaincontroller-teeceetwo.sgallagh.rht.target' reported
"active".


Thanks,

Stephen Gallagher

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-fedoraserver.rhcloud.com/r/124/#review361
-----------------------------------------------------------


What do you thing about an additional parameter for deploy to enable/disable start right
after deploying?

- Thomas Woerner


On Nov. 21, 2014, 5:02 p.m., Stephen Gallagher wrote:
>  
>  -----------------------------------------------------------
>  This is an automatically generated e-mail. To reply, visit:
>  http://reviewboard-fedoraserver.rhcloud.com/r/124/
>  -----------------------------------------------------------
>  
>  (Updated Nov. 21, 2014, 5:02 p.m.)
>  
>  
>  Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, Simo Sorce,
> and Thomas Woerner.
>  
>  
>  Bugs: 35
>      https://fedorahosted.org/rolekit/ticket/35
>  
>  
>  Repository: rolekit
>  
>  
>  Description
>  -------
>  
>  Many server installers will automatically start their services as
>  soon as installation is complete (such as FreeIPA). This means that
>  the real state of the system will disagree with rolekit's view of
>  it. To be sure that we are aligned, it makes the most sense to just
>  ensure that all roles are deployed into the RUNNING state.
>  
>  
>  Diffs
>  -----
>  
>    src/rolekit/server/rolebase.py 7f960bf41206c2552996936839a100325382e3be 
>  
>  Diff: http://reviewboard-fedoraserver.rhcloud.com/r/124/diff/
>  
>  
>  Testing
>  -------
>  
>  Deployed a domain controller and verified that after deployment, 'rolectl status
> domaincontroller/teeceetwo.sgallagh.rht' reported "running" and
> 'systemctl status role-domaincontroller-teeceetwo.sgallagh.rht.target' reported
> "active".
>  
>  
>  Thanks,
>  
>  Stephen Gallagher
>  
>

[Stephen Gallagher]

>  On Dec. 9, 2014, 1:13 p.m., Thomas Woerner wrote:
>  > What do you thing about an additional parameter for deploy to enable/disable start
> right after deploying? 
Well, if we had to allow it to start disabled, this actually requires us to start it and
then stop it again, for the same reason as this was originally filed: some (many)
installers will auto-start when they conclude.

I *can* add another option to allow starting disabled, but I think that's probably
unnecessary. Presumably, if someone is calling 'deploy', it's probably because
they actually want it to be running.


- Stephen


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-fedoraserver.rhcloud.com/r/124/#review361
-----------------------------------------------------------


On Nov. 21, 2014, 5:02 p.m., Stephen Gallagher wrote:
>  
>  -----------------------------------------------------------
>  This is an automatically generated e-mail. To reply, visit:
>  http://reviewboard-fedoraserver.rhcloud.com/r/124/
>  -----------------------------------------------------------
>  
>  (Updated Nov. 21, 2014, 5:02 p.m.)
>  
>  
>  Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, Simo Sorce,
> and Thomas Woerner.
>  
>  
>  Bugs: 35
>      https://fedorahosted.org/rolekit/ticket/35
>  
>  
>  Repository: rolekit
>  
>  
>  Description
>  -------
>  
>  Many server installers will automatically start their services as
>  soon as installation is complete (such as FreeIPA). This means that
>  the real state of the system will disagree with rolekit's view of
>  it. To be sure that we are aligned, it makes the most sense to just
>  ensure that all roles are deployed into the RUNNING state.
>  
>  
>  Diffs
>  -----
>  
>    src/rolekit/server/rolebase.py 7f960bf41206c2552996936839a100325382e3be 
>  
>  Diff: http://reviewboard-fedoraserver.rhcloud.com/r/124/diff/
>  
>  
>  Testing
>  -------
>  
>  Deployed a domain controller and verified that after deployment, 'rolectl status
> domaincontroller/teeceetwo.sgallagh.rht' reported "running" and
> 'systemctl status role-domaincontroller-teeceetwo.sgallagh.rht.target' reported
> "active".
>  
>  
>  Thanks,
>  
>  Stephen Gallagher
>  
>

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-fedoraserver.rhcloud.com/r/124/
-----------------------------------------------------------

(Updated Jan. 20, 2015, 1:19 p.m.)


Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, Simo Sorce,
and Thomas Woerner.


Bugs: 31 and 35
    https://fedorahosted.org/rolekit/ticket/31
    https://fedorahosted.org/rolekit/ticket/35


Repository: rolekit


Description
-------

Many server installers will automatically start their services as
soon as installation is complete (such as FreeIPA). This means that
the real state of the system will disagree with rolekit's view of
it. To be sure that we are aligned, it makes the most sense to just
ensure that all roles are deployed into the RUNNING state.


Diffs
-----

  src/rolekit/server/rolebase.py 7f960bf41206c2552996936839a100325382e3be 

Diff: http://reviewboard-fedoraserver.rhcloud.com/r/124/diff/


Testing
-------

Deployed a domain controller and verified that after deployment, 'rolectl status
domaincontroller/teeceetwo.sgallagh.rht' reported "running" and
'systemctl status role-domaincontroller-teeceetwo.sgallagh.rht.target' reported
"active".


Thanks,

Stephen Gallagher

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-fedoraserver.rhcloud.com/r/124/#review366
-----------------------------------------------------------


What about rolekit use within anaconda?  Wouldn’t it be cleaner to modify the installers
not to start the servers, instead?

- Miloslav Trmac


On Led. 20, 2015, 2:19 odp., Stephen Gallagher wrote:
>  
>  -----------------------------------------------------------
>  This is an automatically generated e-mail. To reply, visit:
>  http://reviewboard-fedoraserver.rhcloud.com/r/124/
>  -----------------------------------------------------------
>  
>  (Updated Led. 20, 2015, 2:19 odp.)
>  
>  
>  Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, Simo Sorce,
> and Thomas Woerner.
>  
>  
>  Bugs: 31 and 35
>      https://fedorahosted.org/rolekit/ticket/31
>      https://fedorahosted.org/rolekit/ticket/35
>  
>  
>  Repository: rolekit
>  
>  
>  Description
>  -------
>  
>  Many server installers will automatically start their services as
>  soon as installation is complete (such as FreeIPA). This means that
>  the real state of the system will disagree with rolekit's view of
>  it. To be sure that we are aligned, it makes the most sense to just
>  ensure that all roles are deployed into the RUNNING state.
>  
>  
>  Diffs
>  -----
>  
>    src/rolekit/server/rolebase.py 7f960bf41206c2552996936839a100325382e3be 
>  
>  Diff: http://reviewboard-fedoraserver.rhcloud.com/r/124/diff/
>  
>  
>  Testing
>  -------
>  
>  Deployed a domain controller and verified that after deployment, 'rolectl status
> domaincontroller/teeceetwo.sgallagh.rht' reported "running" and
> 'systemctl status role-domaincontroller-teeceetwo.sgallagh.rht.target' reported
> "active".
>  
>  
>  Thanks,
>  
>  Stephen Gallagher
>  
>

[Stephen Gallagher]

>  On Jan. 20, 2015, 7:53 p.m., Miloslav Trmac wrote:
>  > What about rolekit use within anaconda?  Wouldn’t it be cleaner to modify the
> installers not to start the servers, instead? 
The planned approach for rolekit use "within" anaconda is actually to have
anaconda generate a one-time systemd unit that will run rolectl in the first-boot
environment. So in that case, it should work fine.

We can't modify the installers not to start the servers in any case, as some (like
postgresql) must be running in order to complete their configuration (such as creating a
database instance and granting a user ownership of it).


- Stephen


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-fedoraserver.rhcloud.com/r/124/#review366
-----------------------------------------------------------


On Jan. 20, 2015, 1:19 p.m., Stephen Gallagher wrote:
>  
>  -----------------------------------------------------------
>  This is an automatically generated e-mail. To reply, visit:
>  http://reviewboard-fedoraserver.rhcloud.com/r/124/
>  -----------------------------------------------------------
>  
>  (Updated Jan. 20, 2015, 1:19 p.m.)
>  
>  
>  Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, Simo Sorce,
> and Thomas Woerner.
>  
>  
>  Bugs: 31 and 35
>      https://fedorahosted.org/rolekit/ticket/31
>      https://fedorahosted.org/rolekit/ticket/35
>  
>  
>  Repository: rolekit
>  
>  
>  Description
>  -------
>  
>  Many server installers will automatically start their services as
>  soon as installation is complete (such as FreeIPA). This means that
>  the real state of the system will disagree with rolekit's view of
>  it. To be sure that we are aligned, it makes the most sense to just
>  ensure that all roles are deployed into the RUNNING state.
>  
>  
>  Diffs
>  -----
>  
>    src/rolekit/server/rolebase.py 7f960bf41206c2552996936839a100325382e3be 
>  
>  Diff: http://reviewboard-fedoraserver.rhcloud.com/r/124/diff/
>  
>  
>  Testing
>  -------
>  
>  Deployed a domain controller and verified that after deployment, 'rolectl status
> domaincontroller/teeceetwo.sgallagh.rht' reported "running" and
> 'systemctl status role-domaincontroller-teeceetwo.sgallagh.rht.target' reported
> "active".
>  
>  
>  Thanks,
>  
>  Stephen Gallagher
>  
>

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-fedoraserver.rhcloud.com/r/124/#review375
-----------------------------------------------------------

Ship it!


Ship It!

- Stephen Gallagher


On Jan. 20, 2015, 1:19 p.m., Stephen Gallagher wrote:
>  
>  -----------------------------------------------------------
>  This is an automatically generated e-mail. To reply, visit:
>  http://reviewboard-fedoraserver.rhcloud.com/r/124/
>  -----------------------------------------------------------
>  
>  (Updated Jan. 20, 2015, 1:19 p.m.)
>  
>  
>  Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, Simo Sorce,
> and Thomas Woerner.
>  
>  
>  Bugs: 31 and 35
>      https://fedorahosted.org/rolekit/ticket/31
>      https://fedorahosted.org/rolekit/ticket/35
>  
>  
>  Repository: rolekit
>  
>  
>  Description
>  -------
>  
>  Many server installers will automatically start their services as
>  soon as installation is complete (such as FreeIPA). This means that
>  the real state of the system will disagree with rolekit's view of
>  it. To be sure that we are aligned, it makes the most sense to just
>  ensure that all roles are deployed into the RUNNING state.
>  
>  
>  Diffs
>  -----
>  
>    src/rolekit/server/rolebase.py 7f960bf41206c2552996936839a100325382e3be 
>  
>  Diff: http://reviewboard-fedoraserver.rhcloud.com/r/124/diff/
>  
>  
>  Testing
>  -------
>  
>  Deployed a domain controller and verified that after deployment, 'rolectl status
> domaincontroller/teeceetwo.sgallagh.rht' reported "running" and
> 'systemctl status role-domaincontroller-teeceetwo.sgallagh.rht.target' reported
> "active".
>  
>  
>  Thanks,
>  
>  Stephen Gallagher
>  
>

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-fedoraserver.rhcloud.com/r/124/
-----------------------------------------------------------

(Updated Jan. 22, 2015, 8:43 p.m.)


Status
------

This change has been marked as submitted.


Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, Simo Sorce,
and Thomas Woerner.


Bugs: 31 and 35
    https://fedorahosted.org/rolekit/ticket/31
    https://fedorahosted.org/rolekit/ticket/35


Repository: rolekit


Description
-------

Many server installers will automatically start their services as
soon as installation is complete (such as FreeIPA). This means that
the real state of the system will disagree with rolekit's view of
it. To be sure that we are aligned, it makes the most sense to just
ensure that all roles are deployed into the RUNNING state.


Diffs
-----

  src/rolekit/server/rolebase.py 7f960bf41206c2552996936839a100325382e3be 

Diff: http://reviewboard-fedoraserver.rhcloud.com/r/124/diff/


Testing
-------

Deployed a domain controller and verified that after deployment, 'rolectl status
domaincontroller/teeceetwo.sgallagh.rht' reported "running" and
'systemctl status role-domaincontroller-teeceetwo.sgallagh.rht.target' reported
"active".


Thanks,

Stephen Gallagher