Review Request 111: docs: Updated global rolekit man page.

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-fedoraserver.rhcloud.com/r/111/
-----------------------------------------------------------

Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, and Thomas
Woerner.


Repository: rolekit


Description
-------

docs: Updated global rolekit man page.


Diffs
-----

  doc/xml/rolekit.xml ce3a709c84446534bac19d9ec2fce6a1133de241 
  doc/xml/transform-man.xsl.in 066644b61861a39e22eb7807e26417392eac2c8c 

Diff: http://reviewboard-fedoraserver.rhcloud.com/r/111/diff/


Testing
-------


Thanks,

Thomas Woerner

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-fedoraserver.rhcloud.com/r/111/#review337
-----------------------------------------------------------



doc/xml/rolekit.xml
<http://reviewboard-fedoraserver.rhcloud.com/r/111/#comment179>

    "avilable" -> "available"
    
    Also, there's a trailing space.



doc/xml/rolekit.xml
<http://reviewboard-fedoraserver.rhcloud.com/r/111/#comment181>

    config.rolekit_roles and the etc variant do not get substituted in the HTML
documentation.



doc/xml/rolekit.xml
<http://reviewboard-fedoraserver.rhcloud.com/r/111/#comment182>

    "instances->instance"



doc/xml/rolekit.xml
<http://reviewboard-fedoraserver.rhcloud.com/r/111/#comment183>

    These two items are reversed. We do the installation and only set up the firewall
rules when it's completed successfully.


- Stephen Gallagher


On Oct. 31, 2014, 3:47 p.m., Thomas Woerner wrote:
>  
>  -----------------------------------------------------------
>  This is an automatically generated e-mail. To reply, visit:
>  http://reviewboard-fedoraserver.rhcloud.com/r/111/
>  -----------------------------------------------------------
>  
>  (Updated Oct. 31, 2014, 3:47 p.m.)
>  
>  
>  Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, and Thomas
> Woerner.
>  
>  
>  Repository: rolekit
>  
>  
>  Description
>  -------
>  
>  docs: Updated global rolekit man page.
>  
>  
>  Diffs
>  -----
>  
>    doc/xml/rolekit.xml ce3a709c84446534bac19d9ec2fce6a1133de241 
>    doc/xml/transform-man.xsl.in 066644b61861a39e22eb7807e26417392eac2c8c 
>  
>  Diff: http://reviewboard-fedoraserver.rhcloud.com/r/111/diff/
>  
>  
>  Testing
>  -------
>  
>  
>  Thanks,
>  
>  Thomas Woerner
>  
>

[Stephen Gallagher]

>  On Oct. 31, 2014, 7:50 p.m., Stephen Gallagher wrote:
>  > doc/xml/rolekit.xml, lines 122-132
>  >
> <http://reviewboard-fedoraserver.rhcloud.com/r/111/diff/1/?file=470#file47...
>  >
>  >     These two items are reversed. We do the installation and only set up the
> firewall rules when it's completed successfully. 
The ports might already be needed for deploying, therefore dropping this request.


- Thomas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-fedoraserver.rhcloud.com/r/111/#review337
-----------------------------------------------------------


On Oct. 31, 2014, 3:47 p.m., Thomas Woerner wrote:
>  
>  -----------------------------------------------------------
>  This is an automatically generated e-mail. To reply, visit:
>  http://reviewboard-fedoraserver.rhcloud.com/r/111/
>  -----------------------------------------------------------
>  
>  (Updated Oct. 31, 2014, 3:47 p.m.)
>  
>  
>  Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, and Thomas
> Woerner.
>  
>  
>  Repository: rolekit
>  
>  
>  Description
>  -------
>  
>  docs: Updated global rolekit man page.
>  
>  
>  Diffs
>  -----
>  
>    doc/xml/rolekit.xml ce3a709c84446534bac19d9ec2fce6a1133de241 
>    doc/xml/transform-man.xsl.in 066644b61861a39e22eb7807e26417392eac2c8c 
>  
>  Diff: http://reviewboard-fedoraserver.rhcloud.com/r/111/diff/
>  
>  
>  Testing
>  -------
>  
>  
>  Thanks,
>  
>  Thomas Woerner
>  
>

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-fedoraserver.rhcloud.com/r/111/#review350
-----------------------------------------------------------



doc/xml/rolekit.xml
<http://reviewboard-fedoraserver.rhcloud.com/r/111/#comment184>

    "Each role has his own sub directory and is named as the directory." sounds
a bit twisted and potentially unclear.
    Maybe something like:
    "Each role owns a directory named after the role itself."
    
    Also do we really need to add details about role.py / RoleBase here ? BEcause if so
then we need to be clearer as a file cannot derive from a class (and we should probably
say 'inherit' ?) :-)



doc/xml/rolekit.xml
<http://reviewboard-fedoraserver.rhcloud.com/r/111/#comment185>

    Convoluted, possible alternative: "Each role instance owns a sub directory in
<filename><config.etc_rolekit_roles/></filename>, named after the role.
The directory contains..."


- Simo Sorce


On Oct. 31, 2014, 3:47 p.m., Thomas Woerner wrote:
>  
>  -----------------------------------------------------------
>  This is an automatically generated e-mail. To reply, visit:
>  http://reviewboard-fedoraserver.rhcloud.com/r/111/
>  -----------------------------------------------------------
>  
>  (Updated Oct. 31, 2014, 3:47 p.m.)
>  
>  
>  Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, and Thomas
> Woerner.
>  
>  
>  Repository: rolekit
>  
>  
>  Description
>  -------
>  
>  docs: Updated global rolekit man page.
>  
>  
>  Diffs
>  -----
>  
>    doc/xml/rolekit.xml ce3a709c84446534bac19d9ec2fce6a1133de241 
>    doc/xml/transform-man.xsl.in 066644b61861a39e22eb7807e26417392eac2c8c 
>  
>  Diff: http://reviewboard-fedoraserver.rhcloud.com/r/111/diff/
>  
>  
>  Testing
>  -------
>  
>  
>  Thanks,
>  
>  Thomas Woerner
>  
>

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-fedoraserver.rhcloud.com/r/111/
-----------------------------------------------------------

(Updated Nov. 7, 2014, 5:57 p.m.)


Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, and Thomas
Woerner.


Repository: rolekit


Description
-------

docs: Updated global rolekit man page.


Diffs (updated)
-----

  doc/xml/rolekit.xml ce3a709c84446534bac19d9ec2fce6a1133de241 
  doc/xml/transform-html.xsl.in 18cb861598bc59d35efbe479f5578bf2eec36d76 
  doc/xml/transform-man.xsl.in 066644b61861a39e22eb7807e26417392eac2c8c 

Diff: http://reviewboard-fedoraserver.rhcloud.com/r/111/diff/


Testing
-------


Thanks,

Thomas Woerner

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-fedoraserver.rhcloud.com/r/111/#review352
-----------------------------------------------------------

Ship it!


Ship It!

- Stephen Gallagher


On Nov. 7, 2014, 5:57 p.m., Thomas Woerner wrote:
>  
>  -----------------------------------------------------------
>  This is an automatically generated e-mail. To reply, visit:
>  http://reviewboard-fedoraserver.rhcloud.com/r/111/
>  -----------------------------------------------------------
>  
>  (Updated Nov. 7, 2014, 5:57 p.m.)
>  
>  
>  Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, and Thomas
> Woerner.
>  
>  
>  Repository: rolekit
>  
>  
>  Description
>  -------
>  
>  docs: Updated global rolekit man page.
>  
>  
>  Diffs
>  -----
>  
>    doc/xml/rolekit.xml ce3a709c84446534bac19d9ec2fce6a1133de241 
>    doc/xml/transform-html.xsl.in 18cb861598bc59d35efbe479f5578bf2eec36d76 
>    doc/xml/transform-man.xsl.in 066644b61861a39e22eb7807e26417392eac2c8c 
>  
>  Diff: http://reviewboard-fedoraserver.rhcloud.com/r/111/diff/
>  
>  
>  Testing
>  -------
>  
>  
>  Thanks,
>  
>  Thomas Woerner
>  
>

[Stephen Gallagher]

>  On Nov. 7, 2014, 5:59 p.m., Stephen Gallagher wrote:
>  > Ship It! 
Pushed:
https://git.fedorahosted.org/cgit/rolekit.git/commit/?id=8dcab20570e1b4b9...


- Thomas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-fedoraserver.rhcloud.com/r/111/#review352
-----------------------------------------------------------


On Nov. 7, 2014, 5:57 p.m., Thomas Woerner wrote:
>  
>  -----------------------------------------------------------
>  This is an automatically generated e-mail. To reply, visit:
>  http://reviewboard-fedoraserver.rhcloud.com/r/111/
>  -----------------------------------------------------------
>  
>  (Updated Nov. 7, 2014, 5:57 p.m.)
>  
>  
>  Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, and Thomas
> Woerner.
>  
>  
>  Repository: rolekit
>  
>  
>  Description
>  -------
>  
>  docs: Updated global rolekit man page.
>  
>  
>  Diffs
>  -----
>  
>    doc/xml/rolekit.xml ce3a709c84446534bac19d9ec2fce6a1133de241 
>    doc/xml/transform-html.xsl.in 18cb861598bc59d35efbe479f5578bf2eec36d76 
>    doc/xml/transform-man.xsl.in 066644b61861a39e22eb7807e26417392eac2c8c 
>  
>  Diff: http://reviewboard-fedoraserver.rhcloud.com/r/111/diff/
>  
>  
>  Testing
>  -------
>  
>  
>  Thanks,
>  
>  Thomas Woerner
>  
>

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-fedoraserver.rhcloud.com/r/111/
-----------------------------------------------------------

(Updated Nov. 7, 2014, 6:04 p.m.)


Status
------

This change has been marked as submitted.


Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, and Thomas
Woerner.


Repository: rolekit


Description
-------

docs: Updated global rolekit man page.


Diffs
-----

  doc/xml/rolekit.xml ce3a709c84446534bac19d9ec2fce6a1133de241 
  doc/xml/transform-html.xsl.in 18cb861598bc59d35efbe479f5578bf2eec36d76 
  doc/xml/transform-man.xsl.in 066644b61861a39e22eb7807e26417392eac2c8c 

Diff: http://reviewboard-fedoraserver.rhcloud.com/r/111/diff/


Testing
-------


Thanks,

Thomas Woerner