Please review (memory leak): [389 Project] #48252: db2index creates index entry from deleted records

[Noriko Hosoi]

https://fedorahosted.org/389/ticket/48252

https://fedorahosted.org/389/attachment/ticket/48252/0001-Ticket-48252-db2in...

Description: Commit ca4d38dff3bd820af2bf60c9bcc82fd64aac2556 fixing
     ticket #48252 introduced memory leaks.
     . nstombstone_vals needs to be allocated just once and freed at the 
end.
     . when skipping to index an entry for being a tombstone, the entry 
needs
       to be freed.

[Ludwig Krispenz]

Thanks for this, it not only fixes a memory leak but also a regression. 
with the previous version of the fix after the processing of the first 
tombstone nstombstone_vals was set an duse in deciding what to index :-)

On 08/28/2015 02:19 AM, Noriko Hosoi wrote:
> https://fedorahosted.org/389/ticket/48252
>
> https://fedorahosted.org/389/attachment/ticket/48252/0001-Ticket-48252-db2in...
> Description: Commit ca4d38dff3bd820af2bf60c9bcc82fd64aac2556 fixing
> ticket #48252 introduced memory leaks.
> . nstombstone_vals needs to be allocated just once and freed at 
>
> the end.
>     . when skipping to index an entry for being a tombstone, the entry 
> needs
>       to be freed.
>
> -- 
> 389-devel mailing list
> [e-mail]
> https://admin.fedoraproject.org/mailman/listinfo/389-devel