On Tue, Jan 24, 2017 at 01:36:59PM +0100, Michal Novotny wrote:
On Tue, Jan 24, 2017 at 11:44 AM, Pierre-Yves Chibon
On Tue, Jan 24, 2017 at 11:30:33AM +0100, Michal Novotny wrote:
>Â Â Yes, untested changes got into production. We are sorry. I am
>Â Â working on a fix.
If that made it up to production, then we'll need to adjust fedmsg_meta
support these messages as well.
fedmsg_meta should work for all our published messages (published and
Okay, these messages have all empty body (the "msg" attribute), e.g
Does fedmsg_meta need to be adjusted even so?
Yeah, fedmsg_meta should be able to process all the messages stored in
datagrepper, otherwise it breaks datagrepper and a few other apps.
So we'll end up with some not so useful message: "a build ended in copr" but
should add them.
The easiest for this type of changes is to use test-driven-development, add the
new message to the test, fill in the expectations and then adjust the processor
to handle those cases.