On Tue, Jan 24, 2017 at 03:12:10PM +0100, Michal Novotny wrote:
Otherwise, in the fix that I am going to apply tomorrow, there
will some
additional fields for chroot.start and build.start messages.
For chroot.start:
- status (int)
- version (str)
For build.start:
- status (int)
- version (str)
- chroot (str)
The old fields will be all there with the same type. Only some new fields
will be added. I hope that does not represent a problem for fedmsg_meta or
anybody. I am aware that an ideal way would be to just leave the old
message interface as it was but the code would get very ugly. Of course,
I will do it if needed.
Adding new fields is not a problem for fedmsg_meta as long as it can access the
old ones.
We can adjust fedmsg_meta to benefit from the new fields if we want. The way is
then to rename the tests TestFoo to LegacyTestFoo (so we keep supporting the old
formats) and then add a new TestFoo where the message is of the new format and
adjust the processor to support the new format (while still supporting the old
one).
For example:
https://github.com/fedora-infra/fedmsg_meta_fedora_infrastructure/pull/403
Pierre