This replaces the other FBR I filed today. I would like to manually apply (i.e., hotfix) this patch to bodhi-backend01 as a temporary workaround for #7194[0]:
diff --git a/bodhi/server/consumers/masher.py b/bodhi/server/consumers/masher.py index ecf88fd3..43c2ac5f 100644 --- a/bodhi/server/consumers/masher.py +++ b/bodhi/server/consumers/masher.py @@ -432,7 +432,6 @@ class ComposerThread(threading.Thread):
# Clean old composes self.save_state(ComposeState.cleaning) - clean_old_mashes.remove_old_composes()
self.save_state(ComposeState.success) self.success = True
For a longer term fix, I will wrap the above dropped line in an if statement that checks a new setting for whether Bodhi should auto-cleanup old composes, and I will include that patch in Bodhi 3.10.0 (planned for release after the current freeze).
On 08/29/2018 11:43 AM, Randy Barlow wrote:
This replaces the other FBR I filed today. I would like to manually apply (i.e., hotfix) this patch to bodhi-backend01 as a temporary workaround for #7194[0]:
diff --git a/bodhi/server/consumers/masher.py b/bodhi/server/consumers/masher.py index ecf88fd3..43c2ac5f 100644 --- a/bodhi/server/consumers/masher.py +++ b/bodhi/server/consumers/masher.py @@ -432,7 +432,6 @@ class ComposerThread(threading.Thread):
# Clean old composes self.save_state(ComposeState.cleaning)
clean_old_mashes.remove_old_composes() self.save_state(ComposeState.success) self.success = True
For a longer term fix, I will wrap the above dropped line in an if statement that checks a new setting for whether Bodhi should auto-cleanup old composes, and I will include that patch in Bodhi 3.10.0 (planned for release after the current freeze).
LGTM
LGTM +1
On Wed, Aug 29, 2018 at 12:27 PM Kevin Fenzi kevin@scrye.com wrote:
+1 and we can think about this and revisit after freeze.
kevin
infrastructure mailing list -- infrastructure@lists.fedoraproject.org To unsubscribe send an email to infrastructure-leave@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/infrastructure@lists.fedorapro...
On 08/29/2018 11:43 AM, Randy Barlow wrote:
clean_old_mashes.remove_old_composes()
OK, this is now in place on backend01 - Mohan if you resume the failed mash I think it'll succeed now.
I am preparing a better fix upstream today:
infrastructure@lists.fedoraproject.org