Help fixing the ansible-review warnings

[Clement Verna]

Hi all,

If you would like to help in solving some of the warnings reported by the
ansible-review tool, there are a few steps on how to run the tool and get
the report in this ticket
https://pagure.io/fedora-infrastructure/issue/8157#comment-611372

You can send your patch to this list for review :-)

Thanks
Clément

[Kevin Sandy]

Are the example lint and standards files included with ansible-review the ones to use, or are there / should there be Fedora Infrastructure specific files? I see there is a repo at https://pagure.io/cpe/ansible-review-templates/ https://pagure.io/cpe/ansible-review-templates/, but it appears to be empty.

One of the warnings for playbooks/check-for-nonvirt-updates.yml is "WARN: Playbook check-for-nonvirt-updates.yml does not present standards version. Using latest standards version 0.1”, and updating the playbook to include the version number from an example file feels a bit odd.

-- kevin
> On Nov 21, 2019, at 10:43 AM, Clement Verna  wrote:
>
> Hi all,
>
> If you would like to help in solving some of the warnings reported by the ansible-review tool, there are a few steps on how to run the tool and get the report in this ticket https://pagure.io/fedora-infrastructure/issue/8157#comment-611372 https://pagure.io/fedora-infrastructure/issue/8157#comment-611372
>
> You can send your patch to this list for review :-)
>
> Thanks
> Clément
> _______________________________________________
> infrastructure mailing list -- [e-mail]
> To unsubscribe send an email to [e-mail]
> Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
> List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
> List Archives: https://lists.fedoraproject.org/archives/list/[e-mail]...

[Kevin Fenzi]

On Fri, Nov 22, 2019 at 08:09:51AM -0500, Kevin Sandy wrote:
> Are the example lint and standards files included with ansible-review the ones to use, or are there / should there be Fedora Infrastructure specific files? I see there is a repo at https://pagure.io/cpe/ansible-review-templates/ https://pagure.io/cpe/ansible-review-templates/, but it appears to be empty.

Yeah, we agreed to use that repo, but then we decided for now at least
that the default rules were fine.
> One of the warnings for playbooks/check-for-nonvirt-updates.yml is "WARN: Playbook check-for-nonvirt-updates.yml does not present standards version. Using latest standards version 0.1”, and updating the playbook to include the version number from an example file feels a bit odd.

Yeah, that one does. Perhaps we should keep a list of tests that we
don't care for/don't want, and we can supress those?

kevin