Freeze Break Request: fix git hooks on new packages

[Kevin Fenzi]

Greetings.

It seems the git-check-perms cron job is still not 100% right. ;)

Currently it's running as 'nobody' and thus doesn't have perms to setup
right right hooks. ;(

I think the following should fix it (also removes a MAILTO that doesn't
matter anymore).

diff --git a/roles/gitolite/check_fedmsg_hooks/tasks/main.yml
b/roles/gitolite/check_fedmsg_hooks/tasks/main.yml
index a22018e..51bff93 100644
--- a/roles/gitolite/check_fedmsg_hooks/tasks/main.yml
+++ b/roles/gitolite/check_fedmsg_hooks/tasks/main.yml
@@ -7,8 +7,8 @@
     cron_file=ansible-git-check-perms
     minute=10
     hour="0, 12"
-    user=nobody
-    job="MAILTO=root /usr/local/bin/git-check-perms
/srv/git/repositories --check=fedmsg-hook -f"
+    user=root
+    job="/usr/local/bin/git-check-perms /srv/git/repositories
--check=fedmsg-hook -f"
   tags:
   - git
   - gitolite

+1s?

kevin

[Patrick マルタインアンドレアス Uiterwijk]

+1

[Stephen John Smoogen]

Can it run as pagure instead with the old MAILTO?

On 16 March 2018 at 21:01, Patrick  マルタインアンドレアス  Uiterwijk
 wrote:
> +1
> _______________________________________________
> infrastructure mailing list -- [e-mail]
> To unsubscribe send an email to [e-mail]

[Kevin Fenzi]

On 03/16/2018 06:11 PM, Stephen John Smoogen wrote:
> Can it run as pagure instead with the old MAILTO?
>
> On 16 March 2018 at 21:01, Patrick  マルタインアンドレアス  Uiterwijk
>  wrote:
> > +1

It can, and thats what I pushed (got the ok from Patrick on irc).

kevin