On Wed, Oct 10, 2018 at 09:32:15AM -0700, Kevin Fenzi wrote:
On 10/10/18 6:35 AM, Pierre-Yves Chibon wrote:
> Good Morning Everyone,
> Today people started to indicate some issues with merging, accessing or delete
> branches in some projects. All what these persons had in common, they had access
> to the project via a group.
> It turns out, in 5.1 the logic to determine if a person is a committer to a
> project has been changed and our test suite seems to be incomplete here as
> people having commit via a group are not considered committers.
> I've spent sometime getting this fixed in a way that remains compatible with
> reason it was changed in the first place and added more tests for this.
> Seeing that the changelog since the 5.1.1 release isn't large:
> * 7dbcb0e5 Add test checking that group with ticket access aren't committer
> * 8bba7704 Add test to ensure committers in a group with commit access are
> * 695f8cad Ensure there is a session in flask.g and patch it correctly
> * 2a1d4db8 Fix detecting if the user is a committer via a group
> * a3c93a3d Also provide PATH and content encoding for clone.py
> * 557a7ab3 Use the manually updated updated_on field rather than last_updated
> * 6764e6aa Make the sshkey migration more flexible
> * 6387abb7 Fix underline length in the doc - fixes warning in sphinx
> * 20456fac Add some documentation about MIRROR_SSHKEYS_FOLDER
> * 3e055021 If a value is None, insert empty strings into the arguments
> (This is including the commits fixing the issue, PR pending at:
> I am considering just doing a 5.1.2 bug fix release and I would like to request
> permission to push this to pagure.io.
Does this version have any schema changes? ie, can we go back if we need to?
No DB changes, going back would be downgrading the RPM and restarting the
In any case +1, but do make sure it's solid in stg and everything
need to fix is collected.
Will do, thanks :)