Freeze break request: fix backups for qadevel.qa.fedoraproject.org

[Kevin Fenzi]

qadevel.qa.fedoraproject.org uses port 222 for ssh shell access. 

ansible is happy using port 222 just fine, but rdiff-backup isn't.
It uses port 22 by default, and fails. 

The following patch should fix this issue. 

+1s? I would apply this, run the backup playbook and then watch
tomorrow's backups to confirm they work. If not we could revert this. 

kevin
--
diff --git a/playbooks/rdiff-backup.yml b/playbooks/rdiff-backup.yml
index 9accda6..fd9dec7 100644
--- a/playbooks/rdiff-backup.yml
+++ b/playbooks/rdiff-backup.yml
@@ -20,11 +20,11 @@
 
   tasks:
   - name: run rdiff-backup hitting all the global targets
-    local_action: "shell rdiff-backup --create-full-path --print-statistics {{
inventory_hostname }}::{{ item }} /fedora_backups/{{ inventory_hostname }}/`basename {{
item }}` | mail -r sysadmin-backup-members(a)fedoraproject.org -s 'rdiff-backup: {{
inventory_hostname }}:{{ item }}' sysadmin-backup-members(a)fedoraproject.org"
+    local_action: "shell rdiff-backup --remote-schema 'ssh -p {{
ansible_ssh_port }} -C %s rdiff-backup --server' --create-full-path --print-statistics
{{ inventory_hostname }}::{{ item }} /fedora_backups/{{ inventory_hostname }}/`basename {{
item }}` | mail -r sysadmin-backup-members(a)fedoraproject.org -s 'rdiff-backup: {{
inventory_hostname }}:{{ item }}' sysadmin-backup-members(a)fedoraproject.org"
     with_items: global_backup_targets
     when: global_backup_targets is defined
 
   - name: run rdiff-backup hitting all the host targets
-    local_action: "shell rdiff-backup --exclude='**git-seed*'
--exclude='**git_seed' --exclude='**.snapshot' --create-full-path
--print-statistics {{ inventory_hostname }}::{{ item }} /fedora_backups/{{
inventory_hostname }}/`basename {{ item }}` | mail -r
sysadmin-backup-members(a)fedoraproject.org -s 'rdiff-backup: {{ inventory_hostname
}}:{{ item }}' sysadmin-backup-members(a)fedoraproject.org"
+    local_action: "shell rdiff-backup --remote-schema 'ssh -p {{
ansible_ssh_port }} -C %s rdiff-backup --server' --exclude='**git-seed*'
--exclude='**git_seed' --exclude='**.snapshot' --create-full-path
--print-statistics {{ inventory_hostname }}::{{ item }} /fedora_backups/{{
inventory_hostname }}/`basename {{ item }}` | mail -r
sysadmin-backup-members(a)fedoraproject.org -s 'rdiff-backup: {{ inventory_hostname
}}:{{ item }}' sysadmin-backup-members(a)fedoraproject.org"
     with_items: host_backup_targets
     when: host_backup_targets is defined

[Tim Flink]

On Mon, 3 Aug 2015 14:07:56 -0600
Kevin Fenzi <kevin(a)scrye.com&gt; wrote:

>  qadevel.qa.fedoraproject.org uses port 222 for ssh shell access. 
>  
>  ansible is happy using port 222 just fine, but rdiff-backup isn't.
>  It uses port 22 by default, and fails. 
>  
>  The following patch should fix this issue. 
>  
>  +1s? I would apply this, run the backup playbook and then watch
>  tomorrow's backups to confirm they work. If not we could revert this.  
+1 from me

It's a local, easily revertible change and the backups aren't happening
as it is - I don't see much risk in the change.

Tim

[Stephen John Smoogen]

On 3 August 2015 at 14:07, Kevin Fenzi <kevin(a)scrye.com&gt; wrote:
>  qadevel.qa.fedoraproject.org uses port 222 for ssh shell access.
>
>  ansible is happy using port 222 just fine, but rdiff-backup isn't.
>  It uses port 22 by default, and fails.
>
>  The following patch should fix this issue.
>
>  +1s? I would apply this, run the backup playbook and then watch
>  tomorrow's backups to confirm they work. If not we could revert this.
>  
+1 please apply.



-- 
Stephen J Smoogen.

[Kevin Fenzi]

Applied, thanks. 

kevin