How do we turn zchunk on for updates-testing for F30?

[Jonathan Dieter]

Hey, I just noticed that, while we have zchunked metadata for the F30
base repository, it's not enabled to for updates-testing.

I've looked in the ansible repo and in pungi, but I can't see where
createrepo_c is actually called for updates-testing.  Can someone
please point me in the right direction?

Jonathan

[Neal Gompa]

On Sat, Mar 9, 2019 at 8:28 AM Jonathan Dieter <jdieter(a)gmail.com&gt; wrote:
>  Hey, I just noticed that, while we have zchunked metadata for the F30
>  base repository, it's not enabled to for updates-testing.
>
>  I've looked in the ansible repo and in pungi, but I can't see where
>  createrepo_c is actually called for updates-testing.  Can someone
>  please point me in the right direction?
>  
Updates repos are handled by Bodhi, so you'll want to look there.


-- 
真実はいつも一つ！/ Always, there's only one truth!

[Jonathan Dieter]

On Sat, 2019-03-09 at 09:43 -0500, Neal Gompa wrote:
>  On Sat, Mar 9, 2019 at 8:28 AM Jonathan Dieter
> <jdieter(a)gmail.com&gt;
>  wrote:
>  > Hey, I just noticed that, while we have zchunked metadata for the
>  > F30
>  > base repository, it's not enabled to for updates-testing.
>  > 
>  > I've looked in the ansible repo and in pungi, but I can't see where
>  > createrepo_c is actually called for updates-testing.  Can someone
>  > please point me in the right direction?
>  > 
>  
>  Updates repos are handled by Bodhi, so you'll want to look there. 
If I'm reading the code correctly looks like Bodhi creates the repodata
using pungi.  Currently, fedora.conf in the pungi-fedora repo is set to
create zchunk metadata for the branches f30 and master.  Could updates-
testing maybe be using a different branch?

Jonathan

[Mikolaj Izdebski]

On Sat, Mar 9, 2019 at 2:29 PM Jonathan Dieter <jdieter(a)gmail.com&gt; wrote:
>  Hey, I just noticed that, while we have zchunked metadata for the F30
>  base repository, it's not enabled to for updates-testing.
>
>  I've looked in the ansible repo and in pungi, but I can't see where
>  createrepo_c is actually called for updates-testing.  Can someone
>  please point me in the right direction? 
createrepo for updates-testing is ran by pungi. I believe you need to
enable zchunk in pungi.conf (createrepo_extra_args option). For
non-modular updates-testing the config is
roles/bodhi2/backend/templates/pungi.rpm.conf.j2 in ansible.git.
Similarly, for modular equivalent, pungi config is located at
roles/bodhi2/backend/templates/pungi.module.conf.j2

--
Mikolaj Izdebski

[Jonathan Dieter]

On Sat, 2019-03-09 at 21:29 +0100, Mikolaj Izdebski wrote:
>  On Sat, Mar 9, 2019 at 2:29 PM Jonathan Dieter
> <jdieter(a)gmail.com&gt;
>  wrote:
>  > Hey, I just noticed that, while we have zchunked metadata for the
>  > F30
>  > base repository, it's not enabled to for updates-testing.
>  > 
>  > I've looked in the ansible repo and in pungi, but I can't see where
>  > createrepo_c is actually called for updates-testing.  Can someone
>  > please point me in the right direction?
>  
>  createrepo for updates-testing is ran by pungi. I believe you need to
>  enable zchunk in pungi.conf (createrepo_extra_args option). For
>  non-modular updates-testing the config is
>  roles/bodhi2/backend/templates/pungi.rpm.conf.j2 in ansible.git.
>  Similarly, for modular equivalent, pungi config is located at
>  roles/bodhi2/backend/templates/pungi.module.conf.j2 
Thanks for pointing me in the right direction.  I think I've got it,
complete with a conditional so we don't start generating zchunk
metadata for F29 updates.

There doesn't seem to be a way to generate pull requests on 
https://infrastructure.fedoraproject.org/cgit/ansible.git, so I'm
attaching the support as a patch.  If there's a better way for me to
send it in, please let me know.

Jonathan

P.S. It may be a small and simple patch, but I haven't actually tested
it and am not sure how to go about doing so.

[Peter Robinson]

>  On Sat, 2019-03-09 at 21:29 +0100, Mikolaj Izdebski wrote:
>  > On Sat, Mar 9, 2019 at 2:29 PM Jonathan Dieter <jdieter(a)gmail.com&gt;
>  > wrote:
>  > > Hey, I just noticed that, while we have zchunked metadata for the
>  > > F30
>  > > base repository, it's not enabled to for updates-testing.
>  > >
>  > > I've looked in the ansible repo and in pungi, but I can't see where
>  > > createrepo_c is actually called for updates-testing.  Can someone
>  > > please point me in the right direction?
>  >
>  > createrepo for updates-testing is ran by pungi. I believe you need to
>  > enable zchunk in pungi.conf (createrepo_extra_args option). For
>  > non-modular updates-testing the config is
>  > roles/bodhi2/backend/templates/pungi.rpm.conf.j2 in ansible.git.
>  > Similarly, for modular equivalent, pungi config is located at
>  > roles/bodhi2/backend/templates/pungi.module.conf.j2
>
>  Thanks for pointing me in the right direction.  I think I've got it,
>  complete with a conditional so we don't start generating zchunk
>  metadata for F29 updates.
>
>  There doesn't seem to be a way to generate pull requests on
>  https://infrastructure.fedoraproject.org/cgit/ansible.git, so I'm
>  attaching the support as a patch.  If there's a better way for me to
>  send it in, please let me know. 
git send-email so it's inline on the list for easy review.

[Jonathan Dieter]

On Sun, 2019-03-10 at 15:47 +0000, Peter Robinson wrote:
>  git send-email so it's inline on the list for easy review.
Thanks for the tip!  Just sent it using git send-email.

Jonathan