[PATCH] use a simpler syntax for the nrpe config

[Michael Scherer]

From: Michael Scherer

---
 roles/nagios_client/tasks/main.yml | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/roles/nagios_client/tasks/main.yml b/roles/nagios_client/tasks/main.yml
index a04e3fb..373cd60 100644
--- a/roles/nagios_client/tasks/main.yml
+++ b/roles/nagios_client/tasks/main.yml
@@ -43,15 +43,15 @@
   - config

- name: install nrpe client configs
-  template: src={{ item.src }} dest=/etc/nrpe.d/{{ item.dest }}
+  template: src={{ item }}.j2 dest=/etc/nrpe.d/{{ item.dest }}
   with_items:
-  - { src: 'check_mirrorlist_cache.cfg.j2', dest: 'check_mirrorlist_cache.cfg' }
-  - { src: 'check_raid.cfg.j2', dest: 'check_raid.cfg' }
-  - { src: 'check_cron.cfg.j2', dest: 'check_cron.cfg' }
-  - { src: 'check_disk.cfg.j2', dest: 'check_disk.cfg' }
-  - { src: 'check_swap.cfg.j2', dest: 'check_swap.cfg' }
-  - { src: 'check_postfix_queue.cfg.j2', dest: 'check_postfix_queue.cfg' }
-  - { src: 'check_lock.cfg.j2', dest: 'check_lock.cfg' }
+  - check_mirrorlist_cache.cfg
+  - check_raid.cfg
+  - check_cron.cfg
+  - check_disk.cfg
+  - check_swap.cfg
+  - check_postfix_queue.cfg
+  - check_lock.cfg
   notify:
   - restart nrpe
   tags:

[Kevin Fenzi]

On Sat, 24 Aug 2013 13:47:22 +0200
[e-mail] wrote:
> From: Michael Scherer
>
> roles/nagios_client/tasks/main.yml | 16 ++++++++--------
>  1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/roles/nagios_client/tasks/main.yml
> b/roles/nagios_client/tasks/main.yml index a04e3fb..373cd60 100644
> --- a/roles/nagios_client/tasks/main.yml
> +++ b/roles/nagios_client/tasks/main.yml
> @@ -43,15 +43,15 @@
>
> config
>
> name: install nrpe client configs
>
> template: src={{ item.src }} dest=/etc/nrpe.d/{{ item.dest }}
> template: src={{ item }}.j2 dest=/etc/nrpe.d/{{ item.dest }}

ok, but item.dest no longer exists in your simplification, just
item. ;)

But thanks for the simplifcation.

kevin

[Michael Scherer]

Le samedi 24 août 2013 à 12:50 -0600, Kevin Fenzi a écrit :
> On Sat, 24 Aug 2013 13:47:22 +0200
> [e-mail] wrote:
> > From: Michael Scherer
> >
> > roles/nagios_client/tasks/main.yml | 16 ++++++++--------
> >  1 file changed, 8 insertions(+), 8 deletions(-)
> >
> > diff --git a/roles/nagios_client/tasks/main.yml
> > b/roles/nagios_client/tasks/main.yml index a04e3fb..373cd60 100644
> > --- a/roles/nagios_client/tasks/main.yml
> > +++ b/roles/nagios_client/tasks/main.yml
> > @@ -43,15 +43,15 @@
> >
> > config
> >
> > name: install nrpe client configs
> >
> > template: src={{ item.src }} dest=/etc/nrpe.d/{{ item.dest }}
> > template: src={{ item }}.j2 dest=/etc/nrpe.d/{{ item.dest }}
>
> ok, but item.dest no longer exists in your simplification, just
> item. ;)

Indeed :/

I guess it would be simpler if I tested it before, but I didn't look how
hard it would do to use some vm for that.