Bodhi 3.7.0-0.0.beta deployed to stg

[Randy Barlow]

Greetings!

I just deployed a Bodhi 3.7.0 beta[0] build to stg[1]. This is a pretty
targeted release with only 4 patches, all aimed at improving the
developer experience with respect to package gating. Testing is appreciated!


[0]
https://bodhi.stg.fedoraproject.org/docs/user/release_notes.html#v3-7-0[1]
https://bodhi.stg.fedoraproject.org/

[Randy Barlow]

On 04/27/2018 02:04 PM, Randy Barlow wrote:
>  I just deployed a Bodhi 3.7.0 beta[0] build to stg[1]. 
I've found two release blocking bugs:

https://github.com/fedora-infra/bodhi/issues/2334
https://github.com/fedora-infra/bodhi/issues/2335


Pierre-Yves, I am unsure how to test (or if it is possible to test)
three of the changes:


* Include the missing tests in the summary about greenwave’s decision
  (#2273).

Though this summary string is getting set to the expected value, it
doesn't work in the JS:

https://github.com/fedora-infra/bodhi/issues/2335


* Show waivers about an update on its page for easier access to users
  and admins (#2277).

I've been struggling to find updates that have waivers in staging. This
is possibly due to staging Bodhi and WaiverDB not being synced from
production at the same time, but I also don't have a way in Bodhi to
tell which updates even have waivers. You had linked to an update that
had a waiver in the PR, but I don't see any mention of the waiver on its
page:

https://bodhi.stg.fedoraproject.org/updates/FEDORA-2017-ded3dc24e1

Is it broken?


* Properly call the WaiverDB API when waiving tests from the UI (#2272).

Staging Bodhi doesn't have a WaiverDB token, so I've been unable to test
this one:

https://pagure.io/fedora-infrastructure/issue/6891

If we give staging Bodhi a WaiverDB token, I can hopefully use it to
create a waiver, which would help me to test the previous one.


* Only ask greenwave about updates in active releases when asking their
  gating status (#2121).

This one I tested in stg with a time operation. It completed in 18
minutes. I did find a release blocking bug when testing this one that
was introduced by the fix in #2273:

https://github.com/fedora-infra/bodhi/issues/2334

[Randy Barlow]

On 04/27/2018 04:06 PM, Randy Barlow wrote:
>  On 04/27/2018 02:04 PM, Randy Barlow wrote:
> > I just deployed a Bodhi 3.7.0 beta[0] build to stg[1]. 
bodhi-3.7.0[0] has now been deployed to production.


>  * Include the missing tests in the summary about greenwave’s
> decision
>    (#2273). 
This still doesn't work in staging because staging Greenwave doesn't
show the same response as production Greenwave[1] - however, I think
this will work in production as long as the newer Greenwave from staging
is not deployed to production. I'm hoping I can figure this out with the
Greenwave developers before they need to deploy - it may require a patch
in Greenwave or a patch in Bodhi or both. In the meantime, I expect that
this is working now.


>  * Show waivers about an update on its page for easier access to
> users
>    and admins (#2277).
>  
>  You had linked to an update that
>  had a waiver in the PR, but I don't see any mention of the waiver on its
>  page:
>  
>  https://bodhi.stg.fedoraproject.org/updates/FEDORA-2017-ded3dc24e1
>  
>  Is it broken? 
It turns out that this was broken, so Patrick fixed it yesterday[2].


>  * Properly call the WaiverDB API when waiving tests from the UI
> (#2272).
>  
>  Staging Bodhi doesn't have a WaiverDB token, so I've been unable to test
>  this one:
>  
>  https://pagure.io/fedora-infrastructure/issue/6891 
Staging now has a token, and I was able to use it to test the WaiverDB
integration myself for the first time. There were a number of
significant usability issues[3-6] that are sure to get lots of
complaints if we enable it in production. I personally think the UI is
probably still better than the CLI even with these issues, but threebean
suggested that we should improve the UX before enabling it. I had been a
bit on the fence due to not wanting a flood of support questions in
#fedora-admin, so I'm going with threebean's recommendation for now to
continue to leave the WaiverDB UI turned off in Bodhi until it works
reasonably.


[0] https://bodhi.fedoraproject.org/docs/user/release_notes.html
[1] https://pagure.io/greenwave/issue/169#comment-511094
[2] https://github.com/fedora-infra/bodhi/issues/2360
[3] https://github.com/fedora-infra/bodhi/issues/2361
[4] https://github.com/fedora-infra/bodhi/issues/2363
[5] https://github.com/fedora-infra/bodhi/issues/2364
[6] https://github.com/fedora-infra/bodhi/issues/2365

[Randy Barlow]

On 05/09/2018 10:40 AM, Randy Barlow wrote:
> > * Include the missing tests in the summary about greenwave’s
> decision
> >   (#2273). 
>  This still doesn't work in staging because staging Greenwave
> doesn't
>  show the same response as production Greenwave[1] - however, I think
>  this will work in production as long as the newer Greenwave from staging
>  is not deployed to production. I'm hoping I can figure this out with the
>  Greenwave developers before they need to deploy - it may require a patch
>  in Greenwave or a patch in Bodhi or both. In the meantime, I expect that
>  this is working now. 
Aaaaaaand it also doesn't work in production. I tested the Greenwave API
just yesterday and it did return the data that Bodhi looks for. Today
the exact same query omits the specific data that Bodhi looks for, which
means that Bodhi does *not* tell users which tests are missing.

[Randy Barlow]

On 05/09/2018 12:07 PM, Randy Barlow wrote:
>  Aaaaaaand it also doesn't work in production. I tested the
> Greenwave API
>  just yesterday and it did return the data that Bodhi looks for. Today
>  the exact same query omits the specific data that Bodhi looks for, which
>  means that Bodhi does *not* tell users which tests are missing. 
https://pagure.io/greenwave/issue/169#comment-511247

[Ralph Bean]

On Wed, May 09, 2018 at 12:12:50PM -0400, Randy Barlow wrote:
>  On 05/09/2018 12:07 PM, Randy Barlow wrote:
>  > Aaaaaaand it also doesn't work in production. I tested the Greenwave API
>  > just yesterday and it did return the data that Bodhi looks for. Today
>  > the exact same query omits the specific data that Bodhi looks for, which
>  > means that Bodhi does *not* tell users which tests are missing.
>
>  https://pagure.io/greenwave/issue/169#comment-511247 
We talked about this in IRC after the fact.  Here, the difference was
that a user waived the koji_build failure and so greenwave stopped
returning it as an unsatisfied requirement.  It was satisfied.  The
greenwave API didn't change on this one.