Freeze Break Request - eu-central-1 for fedimg

[Ralph Bean]

I've got this patch lined up to add a new region to fedimg's workload.  We
haven't been uploading images to eu-central-1, but we should be.  If it ends up
being problematic, we can always revert the commit and push the old config back
out.

I talked it over with dgilmore this afternoon and we shouldn't need to make any
further changes in the AWS console for this.

This is for:

- https://github.com/fedora-infra/fedimg/issues/36
- https://fedorahosted.org/rel-eng/ticket/6259

[PATCH] Add eu-central-1 to the fedimg wonderland.

[Ralph Bean]

---
 roles/fedimg/templates/fedimg.cfg | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/roles/fedimg/templates/fedimg.cfg b/roles/fedimg/templates/fedimg.cfg
index bafe26e..e372e53 100644
--- a/roles/fedimg/templates/fedimg.cfg
+++ b/roles/fedimg/templates/fedimg.cfg
@@ -36,6 +36,7 @@ amis = us-east-1|RHEL|6.5|x86_64|ami-be6a98d6|aki-919dcaf8
        ap-northeast-1|RHEL|6.5|x86_64|ami-e7aee0e6|aki-176bf516
        ap-southeast-1|RHEL|6.5|x86_64|ami-c683df94|aki-503e7402
        ap-southeast-2|RHEL|6.5|x86_64|ami-41ra8f7b|aki-c362fff9
+       eu-central-1|RHEL|6.5|x86_64|ami-76eddb6b|aki-184c7a05
        eu-west-1|RHEL|6.5|x86_64|ami-81f23cf6|aki-52a34525
        sa-east-1|RHEL|6.5|x86_64|ami-b7ec43aa|aki-5553f448
        us-west-1|RHEL|6.5|x86_64|ami-fc393eb9|aki-880531cd
@@ -44,6 +45,7 @@ amis = us-east-1|RHEL|6.5|x86_64|ami-be6a98d6|aki-919dcaf8
        ap-northeast-1|RHEL|6.5|i386|ami-c7bff1c6|aki-136bf512
        ap-southeast-1|RHEL|6.5|i386|ami-9eb8e4cc|aki-ae3973fc
        ap-southeast-2|RHEL|6.5|i386|ami-87f194bd|aki-cd62fff7
+       eu-central-1|RHEL|6.5|i386|ami-76eddb6b|aki-184c7a05
        eu-west-1|RHEL|6.5|i386|ami-7101cf06|aki-68a3451f
        sa-east-1|RHEL|6.5|i386|ami-e9e847f4|aki-5b53f446
        us-west-1|RHEL|6.5|i386|ami-eacfc8af|aki-8e0531cb
-- 
1.8.3.1

[PATCH] Add eu-central-1 to the fedimg wonderland.

[Dennis Gilmore]

On Thursday, October 15, 2015 03:07:50 PM Ralph Bean wrote:
>  ---
>   roles/fedimg/templates/fedimg.cfg | 2 ++
>   1 file changed, 2 insertions(+)
>  
>  diff --git a/roles/fedimg/templates/fedimg.cfg
>  b/roles/fedimg/templates/fedimg.cfg index bafe26e..e372e53 100644
>  --- a/roles/fedimg/templates/fedimg.cfg
>  +++ b/roles/fedimg/templates/fedimg.cfg
>  @@ -36,6 +36,7 @@ amis = us-east-1|RHEL|6.5|x86_64|ami-be6a98d6|aki-919dcaf8
>  ap-northeast-1|RHEL|6.5|x86_64|ami-e7aee0e6|aki-176bf516
>          ap-southeast-1|RHEL|6.5|x86_64|ami-c683df94|aki-503e7402
>          ap-southeast-2|RHEL|6.5|x86_64|ami-41ra8f7b|aki-c362fff9
>  +       eu-central-1|RHEL|6.5|x86_64|ami-76eddb6b|aki-184c7a05
>          eu-west-1|RHEL|6.5|x86_64|ami-81f23cf6|aki-52a34525
>          sa-east-1|RHEL|6.5|x86_64|ami-b7ec43aa|aki-5553f448
>          us-west-1|RHEL|6.5|x86_64|ami-fc393eb9|aki-880531cd
>  @@ -44,6 +45,7 @@ amis = us-east-1|RHEL|6.5|x86_64|ami-be6a98d6|aki-919dcaf8
>  ap-northeast-1|RHEL|6.5|i386|ami-c7bff1c6|aki-136bf512
>          ap-southeast-1|RHEL|6.5|i386|ami-9eb8e4cc|aki-ae3973fc
>          ap-southeast-2|RHEL|6.5|i386|ami-87f194bd|aki-cd62fff7
>  +       eu-central-1|RHEL|6.5|i386|ami-76eddb6b|aki-184c7a05
>          eu-west-1|RHEL|6.5|i386|ami-7101cf06|aki-68a3451f
>          sa-east-1|RHEL|6.5|i386|ami-e9e847f4|aki-5b53f446
>          us-west-1|RHEL|6.5|i386|ami-eacfc8af|aki-8e0531cb 
ack +1

[PATCH] Add eu-central-1 to the fedimg wonderland.

[Ralph Bean]

On Thu, Oct 15, 2015 at 02:31:48PM -0500, Dennis Gilmore wrote:
>  On Thursday, October 15, 2015 03:07:50 PM Ralph Bean wrote:
>  > ---
>  >  roles/fedimg/templates/fedimg.cfg | 2 ++
>  >  1 file changed, 2 insertions(+)
>  > 
>  > diff --git a/roles/fedimg/templates/fedimg.cfg
>  > b/roles/fedimg/templates/fedimg.cfg index bafe26e..e372e53 100644
>  > --- a/roles/fedimg/templates/fedimg.cfg
>  > +++ b/roles/fedimg/templates/fedimg.cfg
>  > @@ -36,6 +36,7 @@ amis = us-east-1|RHEL|6.5|x86_64|ami-be6a98d6|aki-919dcaf8
>  > ap-northeast-1|RHEL|6.5|x86_64|ami-e7aee0e6|aki-176bf516
>  >         ap-southeast-1|RHEL|6.5|x86_64|ami-c683df94|aki-503e7402
>  >         ap-southeast-2|RHEL|6.5|x86_64|ami-41ra8f7b|aki-c362fff9
>  > +       eu-central-1|RHEL|6.5|x86_64|ami-76eddb6b|aki-184c7a05
>  >         eu-west-1|RHEL|6.5|x86_64|ami-81f23cf6|aki-52a34525
>  >         sa-east-1|RHEL|6.5|x86_64|ami-b7ec43aa|aki-5553f448
>  >         us-west-1|RHEL|6.5|x86_64|ami-fc393eb9|aki-880531cd
>  > @@ -44,6 +45,7 @@ amis = us-east-1|RHEL|6.5|x86_64|ami-be6a98d6|aki-919dcaf8
>  > ap-northeast-1|RHEL|6.5|i386|ami-c7bff1c6|aki-136bf512
>  >         ap-southeast-1|RHEL|6.5|i386|ami-9eb8e4cc|aki-ae3973fc
>  >         ap-southeast-2|RHEL|6.5|i386|ami-87f194bd|aki-cd62fff7
>  > +       eu-central-1|RHEL|6.5|i386|ami-76eddb6b|aki-184c7a05
>  >         eu-west-1|RHEL|6.5|i386|ami-7101cf06|aki-68a3451f
>  >         sa-east-1|RHEL|6.5|i386|ami-e9e847f4|aki-5b53f446
>  >         us-west-1|RHEL|6.5|i386|ami-eacfc8af|aki-8e0531cb
>  ack +1
>   
So, this failed.

- fedimg had a hardcoded list of regions.  eu-central-1 was missing.
- I tried adding the eu-central-1 region, but libcloud didn't have a
  definition for it.
- I tried monkey patching libcloud from fedimg to support
  eu-central-1, and it worked!  https://github.com/fedora-infra/fedimg/pull/39
- I then discovered an older entry from the libcloud changelog that
  showed that the way that fedimg is accessessing the ec2 drivers is
  deprecated.  That's why there's no eu-central-1 definition there,
  because they're trying to phase it out.
- I've got a new patch now that uses this new method.  It works as
  best as I can tell.
  https://github.com/fedora-infra/fedimg/pull/40

With that reviewed, released, and deployed, we should be good to go.

[PATCH] Add eu-central-1 to the fedimg wonderland.

[Kevin Fenzi]

+1 here. 

Side note: Why does it say "RHEL 6.5" for all these? 
I mean 6.7 is current there, but does this mean something to amazon? 
If so, a comment would be nice. :) 

kevin

[PATCH] Add eu-central-1 to the fedimg wonderland.

[Ralph Bean]

On Thu, Oct 15, 2015 at 01:36:00PM -0600, Kevin Fenzi wrote:
>  +1 here. 
>  
>  Side note: Why does it say "RHEL 6.5" for all these? 
>  I mean 6.7 is current there, but does this mean something to amazon? 
>  If so, a comment would be nice. :) 
>  
>  kevin 
Looking through the code, it seems like it doesn't use either the
'RHEL' field or the '6.5' field.  I'll file an issue to have those
dropped.

[Ralph Bean]

On Thu, Oct 15, 2015 at 03:07:49PM -0400, Ralph Bean wrote:
>  I've got this patch lined up to add a new region to fedimg's
> workload.  We
>  haven't been uploading images to eu-central-1, but we should be.  If it ends up
>  being problematic, we can always revert the commit and push the old config back
>  out.
>  
>  I talked it over with dgilmore this afternoon and we shouldn't need to make any
>  further changes in the AWS console for this.
>  
>  This is for:
>  
>  - https://github.com/fedora-infra/fedimg/issues/36
>  - https://fedorahosted.org/rel-eng/ticket/6259 
Forgot to ask explicitly:  can I get two +1s for this?

[Ralph Bean]

On Thu, Oct 15, 2015 at 03:07:49PM -0400, Ralph Bean wrote:
>  I've got this patch lined up to add a new region to fedimg's
> workload.  We
>  haven't been uploading images to eu-central-1, but we should be.  If it ends up
>  being problematic, we can always revert the commit and push the old config back
>  out.
>  
>  I talked it over with dgilmore this afternoon and we shouldn't need to make any
>  further changes in the AWS console for this.
>  
>  This is for:
>  
>  - https://github.com/fedora-infra/fedimg/issues/36
>  - https://fedorahosted.org/rel-eng/ticket/6259 
This was applied, but didn't work at first.  We had to patch and
create another release of fedimg (0.6.3), which is in place now, and
it seems to be working:

https://apps.fedoraproject.org/datagrepper/raw?category=fedimg&contai...