Some patches for the eclipse specfile editor

[alcapcom]

Hi all,

Last weeks I have make some changes on org.eclipse.cdt.rpm.editor
eclipse plugin, these changes work like a charm here and I found them
really useful.
 
I would really like to work more on this plugin, but before that I
prefer to contact the devs to know if help is welcome and which type of
functionality should be implement in first time.

Modifications are separate into 3 patches (macro-hover,
sections-folding, completion-support)

1. macro-hover patch:
---------------------
When the cursor is placed hover a macro the content of the macro is
showed into the tooltip text.

At the moment content is searched in these two hardcoded files,
/usr/lib/rpm/macros and ~/.rpmmacros.
We can replace these hardcoded string with properties in a preference
page contain a sortable list of rpm-macro-definitions-file-to-include,
that can be useful for example to overwrite system macros definitions by
user macros definitions and vis versa.


2. folding-section patch:
-------------------------
Add folding on each section (preambule, %pre, %build, %install, %
changelog).

It use the existing .getSections() method to get the folding position,
but as a quick fix the preambule section begin always at the first line.


3. completion support:
----------------------
This patch add completion for macro, rpm package and contextual content
assist templates.

Macro completion use the same code as hover macro to retrieve the macro
proposals, the content of the macro is used as description.

There is specific content assist templates for each section, so %patch
template is usable only in the %build section.

Rpm package completion can be used only in the preambule section, there
is a preference page to build the RPM list file (this file must contain
one package per line).
Informations on the packages are retrieve using "rpm -qi", so
description of the packages is show only if the proposals list is less
than 10 items.



I hope that these patches have chance to be included in upstream, so if
some modifications are require in order to be approved, let me know.

Voilà,
Have fun ;)

-- 
Regards,
Alphonse

[Andrew Overholt]

Hi Alphonse,

On Thu, 2007-08-03 at 20:54 +0100, alcapcom wrote:
>  
>  Last weeks I have make some changes on org.eclipse.cdt.rpm.editor
>  eclipse plugin, these changes work like a charm here and I found them
>  really useful. 
The functionality you added was all stuff we were hoping to add.  That's
awesome!  :)

>  I would really like to work more on this plugin, but before that I
>  prefer to contact the devs to know if help is welcome and which type of
>  functionality should be implement in first time. 
We're *definitely* open to help.

I'll take a look at your patches tomorrow and get back to you then.
Thanks so much for doing the work!

Andrew

[alcapcom]

Have just see that's really difficult to test the plugin modifications
with the provided patches, so I have exported the project with the
build-in eclipse export tools. If another form of sources are preferred,
let me know.

Some change have ben made on the RPM proposals preferences page (add a
button to build the list, run it thought .performOk() look to buggy) and
an other page with a ListEditor was added for the
rpm-macro-definitions-file-to-include.

-- 
Regards,
Alphonse

[Benjamin Konrath]

Hi, 

Just so you know, the RPM plugin has moved to the subversion repository
in linux distros project on Eclipse.org:

http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.linuxtools/?root=Tec...

I don't work on the RPM plugin itself but I do work on the linux distros
project and I know that we are always open to contributions. In order
for an eclipse.org project to accept contributions, the patches must be
attached to the eclipse.org bugzilla. So could you open a new bug and
attach these patches? You'll have to navigate to Technology -> Linux
Distros and choose the RPM component. 

Also, you might want to subscribe to the eclipse linux distros project
list as it's probably a more appropriate place to discus the RPM plugin:
 
https://dev.eclipse.org/mailman/listinfo/linux-distros-dev

Thanks for the patches!

Cheers, Ben

[alcapcom]

Le lundi 12 mars 2007 à 19:50 -0400, Ben Konrath a écrit :
>  Hi, 
>  
>  Just so you know, the RPM plugin has moved to the subversion repository
>  in linux distros project on Eclipse.org: 

Hi Ben,

Thanks to point me the current source repository and the mailing list, I
have see that the specfile plug-in sources have moved sometimes and I
was a little confuse with that.

Currently the related code is not on the SVN, any idea why?

Andrew should take a look on the patches these w-e and say me what we
will do.

PS: There was a problem with mailman which can appear as nobody still
answered to this mail. Andrew have reply but him mail was not take in
account by mailman (the reply was send when the mail was waiting for
validation because of a size problem -- a mailman bug?)

-- 
Regards,
Alphonse

[Benjamin Konrath]

On Tue, 2007-03-13 at 13:40 +0100, alcapcom wrote:
>  Le lundi 12 mars 2007 à 19:50 -0400, Ben Konrath a écrit :
>  > Hi, 
>  > 
>  > Just so you know, the RPM plugin has moved to the subversion repository
>  > in linux distros project on Eclipse.org:
>  
>  
>  Hi Ben,
>  
>  Thanks to point me the current source repository and the mailing list, I
>  have see that the specfile plug-in sources have moved sometimes and I
>  was a little confuse with that.
>  
>  Currently the related code is not on the SVN, any idea why? 
Oh sorry about that, it seems that the specfile code is in the
sourceware.org repository. I just talked to Andrew about this and he
said that he was going to move that code to the eclipse.org repo
sometime soon so that you can contribute the changes to the eclipse.org
repo.

Andrew, please correct me if I've misinterpreted anything.

Thanks, Ben

[Andrew Overholt]

* Ben Konrath <bkonrath(a)redhat.com&gt; [2007-03-13 14:10]:
>  
>  Andrew, please correct me if I've misinterpreted anything. 
No, this is correct.

Alphonse:  it turns out that it'll be *way* easier if I commit the
specfile editor to the eclipse.org repository first and then commit your
patches on top of that.  There will be less legal stuff to worry about
that way.  I'll commit the specfile editor tomorrow and then look at
your patches.  In the meantime, can you attached the patches to bug
reports in Eclipse bugzilla?  Use this URL:

https://bugs.eclipse.org/bugs/enter_bug.cgi?product=Linux%20Distros&c...

Sorry for the procedural hoops :(

Thanks,

Andrew

[alcapcom]

Le mardi 13 mars 2007 à 17:06 -0400, Andrew Overholt a écrit :
>  * Ben Konrath <bkonrath(a)redhat.com&gt; [2007-03-13 14:10]:
>  > 
>  > Andrew, please correct me if I've misinterpreted anything.
>  
>  No, this is correct.
>  
>  Alphonse:  it turns out that it'll be *way* easier if I commit the
>  specfile editor to the eclipse.org repository first and then commit your
>  patches on top of that.  There will be less legal stuff to worry about
>  that way.  I'll commit the specfile editor tomorrow and then look at
>  your patches.  In the meantime, can you attached the patches to bug
>  reports in Eclipse bugzilla?  Use this URL:
>  
>
> https://bugs.eclipse.org/bugs/enter_bug.cgi?product=Linux%20Distros&c...
>  
>  Sorry for the procedural hoops :(
>  
>  Thanks,
>  
>  Andrew 
No problemo, it's done.

-- 
Regards,
Alphonse