[PATCH] livecd-iso-to-disk giving wrong directory path to extlinux

[Warren Togami]

There is a similar problem with vfat filesystems, where syslinux is a 
path that does not exist, and mmove subsequently segfaults because it 
doesn't know how to handle it.  I'm working on that issue separately.

[PATCH] livecd-iso-to-disk giving wrong directory path to extlinux

diff --git a/tools/livecd-iso-to-disk.sh b/tools/livecd-iso-to-disk.sh
index 7d5ba1d..78afec7 100755
--- a/tools/livecd-iso-to-disk.sh
+++ b/tools/livecd-iso-to-disk.sh
@@ -678,7 +678,7 @@ elif [ "$USBFS" = "ext2" -o "$USBFS" =
"ext3" ]; then
      # extlinux expects the config to be named extlinux.conf
      # and has to be run with the file system mounted
      mv $USBMNT/$SYSLINUXPATH/isolinux.cfg 
$USBMNT/$SYSLINUXPATH/extlinux.conf
-    extlinux -i $USBMNT/syslinux
+    extlinux -i $USBMNT/LiveOS/syslinux
      cleanup
  fi

[Warren Togami]

Warren Togami wrote:
>  There is a similar problem with vfat filesystems, where syslinux is a
>
>  path that does not exist, and mmove subsequently segfaults because it 
>  doesn't know how to handle it.  I'm working on that issue separately.
>   
The previous patch to make the extlinux code-path work is confirmed to work.

The syslinux code path however is proving to be trickier.  It appears 
that livecd-iso-to-disk is doing something wrong, then mmove via 
syslinux crashes.  mtools itself is buggy in crashing here, but it 
appears to be livecd-iso-to-disk's fault.  I am still figuring this...

Core was generated by `mmove -D o -D O s:/ldlinux.sys 
s:/LiveOS/syslinux/ldlinux.sys'.
Program terminated with signal 11, Segmentation fault.
#0  0x080610ef in _mwrite_one (Dir=0x0, argname=0x9b99f40 "ldlinux.sys", 
shortname=0x0, cb=0x8062a1c <renameit>,
     arg=0xbffcb060, ch=0xbffcb53c) at mk_direntry.c:522
522		doscp_t *cp = GET_DOSCONVERT(Dir);
(gdb) bt
#0  0x080610ef in _mwrite_one (Dir=0x0, argname=0x9b99f40 "ldlinux.sys", 
shortname=0x0, cb=0x8062a1c <renameit>,
     arg=0xbffcb060, ch=0xbffcb53c) at mk_direntry.c:522
#1  0x080614c9 in mwrite_one (Dir=0x0, _argname=0xbffcb138 
"ldlinux.sys", _shortname=0x0, cb=0x8062a1c <renameit>,
     arg=0xbffcb060, ch=0xbffcb53c) at mk_direntry.c:639
#2  0x08062dac in rename_file (entry=0xbffcab6c, mp=0xbffcb068) at 
mmove.c:132
#3  0x08055be6 in handle_leaf (direntry=0xbffcab6c, mp=0xbffcb068, 
lookupState=0x0) at mainloop.c:224
#4  0x0805630d in recurs_dos_loop (mp=0xbffcb068, filename0=0xbffcb914 
"ldlinux.sys", filename1=0x0, lookupState=0x0)
     at mainloop.c:389
#5  0x08056507 in common_dos_loop (mp=0xbffcb068, pathname=0xbffcb913 
"/ldlinux.sys", lookupState=0x0, open_mode=2)
     at mainloop.c:437
#6  0x0805657e in dos_loop (mp=0xbffcb068, arg=0xbffcb911 
"s:/ldlinux.sys") at mainloop.c:450
#7  0x08056890 in main_loop (mp=0xbffcb068, argv=0xbffcb7a8, argc=1) at 
mainloop.c:553
#8  0x08063414 in mmove (argc=7, argv=0xbffcb794, oldsyntax=0) at 
mmove.c:302
#9  0x08066d26 in main (argc=7, argv=0xbffcb794) at mtools.c:167

Warren Togami
wtogami(a)redhat.com

[Warren Togami]

Warren Togami wrote:
>  Warren Togami wrote:
> > There is a similar problem with vfat filesystems, where syslinux is a 
> > path that does not exist, and mmove subsequently segfaults because it 
> > doesn't know how to handle it.  I'm working on that issue separately.
> >
>  
>  The previous patch to make the extlinux code-path work is confirmed to 
>  work.
>  
>  The syslinux code path however is proving to be trickier.  It appears 
>  that livecd-iso-to-disk is doing something wrong, then mmove via 
>  syslinux crashes.  mtools itself is buggy in crashing here, but it 
>  appears to be livecd-iso-to-disk's fault.  I am still figuring this... 
s:/LiveOS/syslinux/ldlinux.sys: no match for target
syslinux: warning: unable to move ldlinux.sys

These error messages print while it fails here.

Warren

[Jeremy Katz]

On Thursday, March 05 2009, Warren Togami said:

>  Warren Togami wrote:
> > There is a similar problem with vfat filesystems, where syslinux is a  
> > path that does not exist, and mmove subsequently segfaults because it  
> > doesn't know how to handle it.  I'm working on that issue separately.
>
>  The previous patch to make the extlinux code-path work is confirmed to work.
>
>  The syslinux code path however is proving to be trickier.  It appears  
>  that livecd-iso-to-disk is doing something wrong, then mmove via  
>  syslinux crashes.  mtools itself is buggy in crashing here, but it  
>  appears to be livecd-iso-to-disk's fault.  I am still figuring this... 
With the path changes reverted (and thus, basically exactly what shipped in 
F10), I still hit this.  Going back to F10's mtools works fine.  And
trying a newer version from upstream (4.0.9) seems to fix things also,
so I've bounced this over to the mtools maintainer to do an update

Jeremy

[Jeremy Katz]

On Wednesday, March 04 2009, Warren Togami said:
>  [PATCH] livecd-iso-to-disk giving wrong directory path to extlinux
This is actually a result of something I was trying out for multiple
images on a key that I didn't realize I had pushed.  It didn't work out,
so I'm just going to revert the commit in question instead (and push the
revert :)

Jeremy