Hi Jeremy and Mark,
On Dec 18, 2007 1:44 AM, Mark McLoughlin <markmc(a)redhat.com> wrote:
On Sun, 2007-12-16 at 23:58 +0800, Tan Swee Heng wrote:
> - (string.join(args, " "), ret))
> + (" ".join(args), ret))
Agree with Jeremy - I'm not a fan of this construct; it's just a wee
bit too clever and obtuse for my liking.
Actually I did find it awkward in the past too... but I must have
gotten used to it. :-P
> - l = string.split(hostname, ".")
> + l = hostname.split(".")
I do prefer this construct, though.
Ok since there are two votes in favor of this, here's the updated
patch that just modify imgcreate/kickstart.py. I've left fs.py
untouched. Feel free to apply / not apply this. It is not a
show-stopper bug after all. :-)
Swee Heng