kellin commented on the pull-request: `DNF & Python3 Updates for Critpath.py` that you
are following:
``
Updates have been made.
@ngompa & @puiterwijk - I changed the static release list to a range generator.
@puiterwijk - renamed functions to expand_X_critpath per request and moved dnf code into
its own spot. I didn't do this because originally this had caused major breakages but
it looks like somewhere along the way I cleaned up what had caused those in the first
place.
@puiterwijk - I had renamed the import to tempdir because originally had been using
TemporaryDirectory from Python3 and was renaming on import to use the same thing in two
places. Eventually this gave way to the form it was in, so the renaming was superfluous.
Changed it back to a straight import of mkdtemp
@puiterwijk - removed the oddly renamed unused import - it was a relic borne out of late
night frustration sometime last week that I didn't remember to remove.
@puiterwijk - the yum version comparison now uses tuples, thanks for the suggestion though
it wasn't something I'd changed in this PR, just moved the code to another spot.
@ausil - I removed the verbage for calling it a hack, however, it's not a good thing
to use a hard coded list of releases.
@puiterwijk - added the __future_ import per request.
There were several other comments above: with regard to attempting to use arch/basearch
conversion functions and using a directory listing those are items that will be resolved
in a fix that is coming after bodhi freeze.
The main point of updating this script is just to get DNF dependency solving in place
before Bodhi freeze so that the functionality is there. The longer term fix required more
work/testing after @mohanboddu 's request and I didn't feel comfortable trying to
shoehorn it all in while attending FLOCK and travelling with the time constraints.
Thanks for all the reviews - if there's anything I didn't cover please let me
know.
``
To reply, visit the link below or just reply to this email
https://pagure.io/releng/pull-request/7007