November 2013 - 389-devel - Fedora Mailing-Lists

please review: Ticket 47582 - replication agreement count can go negative

by Mark Reynolds

https://fedorahosted.org/389/ticket/47582/ https://fedorahosted.org/389/attachment/ticket/47582/0001-Ticket-47582-ag... -- Mark Reynolds 389 Development Team Red Hat, Inc mreynolds(a)redhat.com

10 years, 5 months

1
0
0 / 0

please review: Ticket 47541 - Replication of the schema may overwrite consumer 'attributetypes' even if consumer definition is a superset

by Mark Reynolds

https://fedorahosted.org/389//ticket/47541 https://fedorahosted.org/389/attachment/ticket/47541/0001-Ticket-47541-Re... -- Mark Reynolds 389 Development Team Red Hat, Inc mreynolds(a)redhat.com

10 years, 5 months

1
0
0 / 0

Please review: ticket 47521 Complex filter in a search request doen't work as expected.

by Ludwig Krispenz

https://fedorahosted.org/389/ticket/47521 https://fedorahosted.org/389/attachment/ticket/47521/0001-Ticket-47521-Co...

10 years, 5 months

1
0
0 / 0

Please review lib389 ticket 47584 (take #3): CI tests: add backup/restore of an instance

by thierry bordaz

This review differs from previous with: * skip verbose option (use of log.level). * use glob.glob to retrieve files matching rather that os.walk * fix a bug in instanceBackupFS that did not return an already existing backup * add two functions to handle instance backup: clearInstanceBackupFS (to remove one or all backups of an instance), _infoInstanceBackupFS (just to keep path/pattern info of backup into a single routine) https://fedorahosted.org/389/attachment/ticket/47584/0003-Ticket-47584-CI...

10 years, 5 months

1
0
0 / 0

Please review lib389 ticket 47584 (take #2): CI tests: add backup/restore of an instance

by thierry bordaz

Thanks Roberto and Rich for reviewing this. This second patch takes into account your recommendation to let the logging mechanism to choose rather that to use 'verbose' flag. https://fedorahosted.org/389/attachment/ticket/47584/0002-Ticket-47584-CI...

10 years, 5 months

2
2
0 / 0

Please review lib389 ticket 47578 (take #2): removal of 'sudo' and absolute path in lib389

by thierry bordaz

This review enhances the previous fix with the handling of non SELinux platforms. https://fedorahosted.org/389/attachment/ticket/47578/0002-Ticket-47578-CI...

10 years, 5 months

1
0
0 / 0

Please review lib389 ticket 47584: CI tests: add backup/restore of an instance

by thierry bordaz

Hello, This ticket implements in lib389 the ability to backup/restore a full instance. This is required by the ticket 47575: add test case for ticket47560, that uses this ability. https://fedorahosted.org/389/attachment/ticket/47584/0001-Ticket-47584-CI...

10 years, 5 months

2
3
0 / 0

Please review (take #2) ticket 47575: add test case for ticket47560

by thierry bordaz

Hi All, This review is new proposal to implement CI test cases inside 389-DS. The layout of the tests will be: <head>/dirsrvtests/ tickets/ ticket_abc_test.py ticket_xyz_test.py ... finalizer testsuites/ acl_test.py replication_test.py ... Each ticket_xyz_test.py will contain "framework" functions that will allocate a fresh installed instance then the test functions: "framework" functions are _ds_create_standalone, DSInstance class and ds_instance pytest fixture. tests functions are named 'test_ticket_xyz' with 'ds_instance' fixture as argument. py.test will call the test functions 'test_ticket_xyz'. Its argument is an instance (ds_instance) of DSInstance where ds_instance.instance is a connection to the instance. The first instance of DSInstance (first ticket being tested), get a newly created instance (e.g. slapd-standalone) and creates a backup of the instance (under /tmp/slapd-standalone.bck/backup_HHMMSS.tar.gz). Then when running others ticket test cases, the instance is reinitialized from the backup. So each ticket test case will have an instance almost like it was just created. py.test will discover all the ticket_xxx_test.py files and run them. In order to remove the created instances, py.test is called a second time to run finalizer.py. So a jenkins job script, will do something like: cd <head>/dirsrvtests/tickets py.test -v # that will run all the ticket_xxx_tests and create the instance py.test -v finalizer.py Note: in order to check/backup/restore instance, new functions are added in lib389 ( checkInstanceBackupFS, instanceBackupFS, instanceRestoreFS), I will send an other review for them as it is not in 389-DS repos. https://fedorahosted.org/389/attachment/ticket/47575/0002-Ticket-47575-CI...

10 years, 5 months

1
0
0 / 0

pLease review: Ticket #47577 crash when removing entries from cache

by Ludwig Krispenz

https://fedorahosted.org/389/ticket/47577 https://fedorahosted.org/389/attachment/ticket/47577/0001-Ticket-47577-cr...

10 years, 5 months

1
0
0 / 0

Please review: [389 Project] #47581: Winsync plugin segfault during incremental backoff

by Noriko Hosoi

https://fedorahosted.org/389/ticket/47581 https://fedorahosted.org/389/attachment/ticket/47581/0001-Ticket-47581-Wi... git patch file (master) https://fedorahosted.org/389/attachment/ticket/47581/0001-Ticket-47581-Wi... git patch file (389-ds-base-1.2.11) Bug description: Once WinSync backoff timer is set, even if the protocol that the backoff timer belongs to is deleted by removing the windows sync agreement, the timer is not deleted from the event queue. Thus the timer is expired and backoff is called, it crashes the server since the protocol handle is already freed, then. Fix description: Make sure to delete the backoff timer when 1) a windows sync agreement is removed and the protocol is deleted, and 2) a new backoff timer set and there is already a backoff timer set up.

10 years, 5 months

1
0
0 / 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

389-devel November 2013