[389-devel] Please review (take 3): [389 Project] #47606: replica init/bulk import errors should be more verbose
https://fedorahosted.org/389/ticket/47606
https://fedorahosted.org/389/attachment/ticket/47606/0001-Ticket-47606-re...
Responding to the comment by Rich (https://fedorahosted.org/389/ticket/47606#comment:13),
389 Project wrote:
Thanks for your comments, Rich.
The code skipping a failed entry instead of failing there in
bulk_import_queue was backed off.
And this is the cause why repl5_tot_waitfor_async_results did not return
with "done" when a failure was returned from the connection.
3. In repl5_tot_result_threadmain, when conn_read_result_ex returns
non zero (non SUCCESS), it sets abort, but does not set any error
code to rc (return code), which is not considered as "finished" in
repl5_tot_waitfor_async_results and it contines waiting until the
code reaches the max loop count (about 5 minutes). This patch sets
LDAP_CONNECT_ERROR to the return code along with setting abort, if
conn_read_result_ex returns CONN_NOT_CONNECTED. This makes the bulk
import finishes quickly when it fails.