[Fedora-directory-devel] Please review and comment: [Bug 214533] configure needs to support --with-fhs

[Noriko Hosoi]

Summary: configure needs to support --with-fhs

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=214533

------- Additional Comments From nhosoi(a)redhat.com  2006-11-10 14:19 EST -------
Created an attachment (id=140927)
 --> (https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=140927&action=...)
cvs diffs (configure.ac Makefile.am), new file m4/fhs.m4

Files:
configure.ac
Makefile.am
m4/fhs.m4

Changes:
1. introduced a new option --with-fhs
2. instead of passing the define macro with -D, generate config.h

------- Additional Comments From nhosoi(a)redhat.com  2006-11-10 14:28 EST -------
I verified that the changes in Comment #1 generates config.h with the following
define:
with_fhs/config.h:#define IS_FHS 1
without_fhs:/* #undef IS_FHS */

And the build command line (on RHEL4) looks like this:
if gcc -DHAVE_CONFIG_H -I. -I.. -I.  -DXP_UNIX -DLinux -DLINUX -DLINUX2_0
-DLINUX2_2 -DLINUX2_4  -DBUILD_NUM=\"2006.314.1857\" -I../ldap/include
-I../ldap/servers/slapd -I../include -I. -I../lib/ldaputil
-I/usr/include/mozldap6 -I/usr/include/dirsec/nspr4 -I/usr/include/dirsec/nss3 
 -I/usr/include/dirsec/nss3   -I/usr/include/dirsec/nspr4     -g -O2 -MT
lib/ldaputil/libldaputil_a-ldapdb.o -MD -MP -MF
"lib/ldaputil/.deps/libldaputil_a-ldapdb.Tpo" -c -o
lib/ldaputil/libldaputil_a-ldapdb.o `test -f 'lib/ldaputil/ldapdb.c' || echo
'../'`lib/ldaputil/ldapdb.c; 

Now, each source file can have this include at the top of the code?
#ifdef HAVE_CONFIG_H
#  include <config.h>
#endif


------------------------------------------------------------------------
Note: The changes proposed in comment #1 generate the macro defined in 
config.h, but does nothing else.  The install paths should be updated, 
as well (in the build).  And I'm planning to use the macro IS_FHS in 
create_instance to notify the instance generator which paths the server 
instance should use.

Thanks,
--noriko