On 11/13/2014 02:57 AM, Dennis Gilmore wrote:
On Wed, 12 Nov 2014 17:17:17 -0800
Mike Bonnet <mikeb(a)redhat.com> wrote:
> On 11/12/14 5:06 PM, Dennis Gilmore wrote:
>> -----BEGIN PGP SIGNED MESSAGE-----
>> Hash: SHA1
>>
>> On Wed, 12 Nov 2014 10:11:31 -0800
>> Mike Bonnet <mikeb(a)redhat.com> wrote:
>>
>>> On 10/30/14 1:21 PM, Mike Bonnet wrote:
[...]
>>>
>>> It came to my attention that these patches broke fedpkg because it
>>> passes keyword args as positional args. This patch to fedpkg fixes
>>> that, which should make enhancing rpkg and fedpkg easier in the
>>> future.
>>>
>>
>> nak, we need to do this without changing the api, there is other
>> users of rpkg outside of our control, we can not go changing the
>> API on them and breaking their clients. rpkg needs to be changed
>> without changing the API
> I didn't think the order of kwargs was part of the API. If fedpkg
> was using the API correctly, order wouldn't matter.
Too early in the day here, you're right. we should fix up fedpkg
I've
applied 0001-pass-keyword-args-as-keyword-args.patch to fedpkg repo
then and pushed to upstream repo.
--
Pavol Babincak
Release Engineering, Red Hat