puiterwijk opened a new pull-request against the project: `fedora-atomic` that you are following: `` Make the list of repos empty in the default inherit chain ``
To reply, visit the link below or just reply to this email https://pagure.io/fedora-atomic/pull-request/90
puiterwijk commented on the pull-request: `Make the list of repos empty in the default inherit chain` that you are following: `` This basically moves the bulk of the tree definition to a -base, and just the repos back to the fedora-atomic-host.json. The reason for this is that this way, if Pungi injects the correct repos, it won't still have the repos from the base. ``
To reply, visit the link below or just reply to this email https://pagure.io/fedora-atomic/pull-request/90
puiterwijk commented on the pull-request: `Make the list of repos empty in the default inherit chain` that you are following: `` I've confirmed that with this change, the "repos" field in the updates-*.json files takes effect as expected. ``
To reply, visit the link below or just reply to this email https://pagure.io/fedora-atomic/pull-request/90
ausil merged a pull-request against the project: `fedora-atomic` that you are following.
Merged pull-request:
`` Make the list of repos empty in the default inherit chain ``
walters commented on the pull-request: `Make the list of repos empty in the default inherit chain` that you are following: `` I'm not *opposed* to this but...again the reason I chose JSON was *precisely* so that tools like pungi or whatever could easily override the `repos` field dynamically. ``
To reply, visit the link below or just reply to this email https://pagure.io/fedora-atomic/pull-request/90
puiterwijk commented on the pull-request: `Make the list of repos empty in the default inherit chain` that you are following: `` @walters And that is exactly what Pungi does. Unfortunately, the problem is that right now, Pungi does not allow me to override the ref, and that is what I need overridden (Dusty has an RFE for that. As soon as that gets fixed, I'll revert all these changes and use that). ``
To reply, visit the link below or just reply to this email https://pagure.io/fedora-atomic/pull-request/90
puiterwijk commented on the pull-request: `Make the list of repos empty in the default inherit chain` that you are following: `` The problem with Pungi's editing of "repos" in this downstream file is that, as per documentation, lists get appended. So given that the base already had repos in it, the injected repos were appended to the already existing ones, while they needed to be fully overridden (without the old ones). ``
To reply, visit the link below or just reply to this email https://pagure.io/fedora-atomic/pull-request/90
walters commented on the pull-request: `Make the list of repos empty in the default inherit chain` that you are following: `` Yeah it's fine, again I'm not objecting. But I thought what we had with fedmsg-atomic-composer before was a bit nicer in that it overrode both the `ref` and the `repos` fields in the single file. So once Pungi learns to do that I think that'd be a bit nicer.
Anyways, no worries, the changes LGTM. ``
To reply, visit the link below or just reply to this email https://pagure.io/fedora-atomic/pull-request/90
puiterwijk commented on the pull-request: `Make the list of repos empty in the default inherit chain` that you are following: `` Oh, yeah, I totally agree with that when Pungi can override ref, that's way nicer (I would not even say "a bit"). ``
To reply, visit the link below or just reply to this email https://pagure.io/fedora-atomic/pull-request/90
dustymabe commented on the pull-request: `Make the list of repos empty in the default inherit chain` that you are following: `` i'm pretty sure pungi already has support for overriding the repos.
Example [here](https://kojipkgs.fedoraproject.org/compose/branched/Fedora-27-20171022.n.0/l...). You can see it only picks up rpms from one repo: `Fedora-27-20171022.n.0-Everything-20171022114659`.
We pass `--extra-config=/mnt/koji/compose/branched/Fedora-27-20171022.n.0/work/ostree-3/extra_config.json`([link](https://kojipkgs.fedoraproject.org/compose/branched/Fedora-27-20171022.n.0/w...)) to pungi which has the effect of overriding the repos. The final config (after replacement) is [here](https://kojipkgs.fedoraproject.org/compose/branched/Fedora-27-20171022.n.0/w...). The original (with a `.bak` extension) is [here](https://kojipkgs.fedoraproject.org/compose/branched/Fedora-27-20171022.n.0/w...). ``
To reply, visit the link below or just reply to this email https://pagure.io/fedora-atomic/pull-request/90
puiterwijk commented on the pull-request: `Make the list of repos empty in the default inherit chain` that you are following: `` @dustymabe Yes, it overrides the repos. But the problem is that Pungi only changes atomic-host-updates-testing.json. But then, that file "include"s atomic-host.json, and if that already has repos, those add added to the ones Pungi inject. The problem is that the ones that are in the default .repo files in this repository are not usable from within koji builders. ``
To reply, visit the link below or just reply to this email https://pagure.io/fedora-atomic/pull-request/90
dustymabe commented on the pull-request: `Make the list of repos empty in the default inherit chain` that you are following: `` oh ok, so we're saying that the pungi override of repos doesn't work with the change we made yesterday. got it. ``
To reply, visit the link below or just reply to this email https://pagure.io/fedora-atomic/pull-request/90
-
Colin Walters -
Dennis Gilmore
-
Dusty Mabe
-
Patrick "マルタインアンドレアス" Uiterwijk