Re: Change request: reenable last-modified (was Re: squid issues)

[Seth Vidal]

On Mon, 2009-02-02 at 21:15 -0500, Ricky Zhou wrote:
>  On 2009-02-02 09:08:54 PM, Ricky Zhou wrote:
>  > On 2009-02-02 05:34:39 PM, Jesse Keating wrote:
>  > > I noticed something while composing this release.  Packages gotten from
>  > > kojipkgs (and thus the proxy) all have a timestamp of when the file was
>  > > downloaded, vs the timestamp of the file on the fileserver.  This has
>  > > caused me some... frustration in getting my composes synced on the
>  > > master mirror using hardlinks to rawhide.
>  > > 
>  > > Can somebody help me debug why this is?  I'm not familiar with our squid
>  > > setup, and I couldn't find it in a quick wiki search for 'squid'.
>  > Oops, I cleared the Last-Modified headers in the configs hoping that it
>  > might somehow save some NFS load.  Here's a patch to remove those lines
>  > - can I get two +1s?
>  I'm sorry, that was the wrong patch.  Here is the right one:
>  
>  diff --git a/configs/web/applications/kojipkgs.conf
> b/configs/web/applications/kojipkgs.conf
>  index 7077546..6ad116c 100644
>  --- a/configs/web/applications/kojipkgs.conf
>  +++ b/configs/web/applications/kojipkgs.conf
>  @@ -6,7 +6,6 @@ Alias /packages /mnt/koji/packages
>   <Directory /mnt/koji/packages>
>       Options Indexes
>       FileETag None
>  -    Header unset Last-Modified
>   </Directory>
>   
>   Alias /repos /mnt/koji/repos
>  @@ -14,7 +13,6 @@ Alias /repos /mnt/koji/repos
>   <Directory /mnt/koji/repos>
>       Options Indexes
>       FileETag None
>  -    Header unset Last-Modified
>   </Directory>
>   
>   Alias /scratch /mnt/koji/scratch
>  @@ -22,7 +20,6 @@ Alias /scratch /mnt/koji/scratch
>   <Directory /mnt/koji/scratch>
>       Options Indexes
>       FileETag None
>  -    Header unset Last-Modified
>   </Directory>
>   
>   Alias /work /mnt/koji/work
>  @@ -30,7 +27,6 @@ Alias /work /mnt/koji/work
>   <Directory /mnt/koji/work>
>       Options Indexes
>       FileETag None
>  -    Header unset Last-Modified
>   </Directory>
>   
>   Alias /static-repos /mnt/koji/static-repos
>  @@ -38,7 +34,6 @@ Alias /static-repos /mnt/koji/static-repos
>   <Directory /mnt/koji/static-repos>
>       Options Indexes FollowSymLinks
>       FileETag None
>  -    Header unset Last-Modified
>   </Directory>
>   
>   Alias /mash /mnt/koji/mash
>  @@ -46,6 +41,5 @@ Alias /mash /mnt/koji/mash
>   <Directory /mnt/koji/mash>
>       Options Indexes FollowSymLinks
>       FileETag None
>  -    Header unset Last-Modified
>   </Directory>
>    
+1

-sv