On Sat, Jul 24, 2010 at 22:53:30 -0500,
Bruno Wolff III <bruno(a)wolff.to> wrote:
What do other people think? If we want to pursue this, I can look over the
exception checks and see if just this one has to deal with bogus stuff
from urlgrabber and pykickstart. Change the two arg exception checks to
one and use strerror for the string with or args[0] in the problem
place (or other if I see any) and file bugs against urlgrabber and
pykickstart?
Going down this road, I have something worked up that would need to be
tested before committing. The patch is attached.
The git commit log:
Fix issue with improper exception args used by urlgrabber and pykickstart.
urlgrabber and pykickstart don't always supply both and error number and
an error message when raising an IOError exception. This was causing
an exception while processing the exception for some errors.
To prevent exceptions from insufficient arguments, the exception calls
were changed to use a single variable instead of a tuple and to use
strerror instead of the second argument.
As a temporary work around for urlgrabber and pykickstart issues, if
strerror is null, args[0] is used as a fallback so that we get a
reasonable error message.
This resolves bug 551932.