Re: [Fedora-livecd-list] [PATCH] Add initramfs image creator
Hi Alan,
There's nothing wrong with the code, it's in good shape. Some thoughts:
- Using pax instead of cpio is okay, I guess. The cpio code is
probably a little hairy just for the sake of avoiding the pax
dep.
- Symlinking /init to /sbin/init seems a little odd, but I guess it
is useful.
- I'm not sure how generally useful this is and whether it really
belongs in the imgcreate public API. This doesn't use any imgcreate
internals, so it could live outside imgcreate. Then again, if it's
in there, maybe people will come up with fun uses for it. I'm of
two minds on it ... Jeremy?
Cheers,
Mark.