Re: [Fedora-livecd-list] " def _generate_efiboot(self, isodir)" breaks the livecd build

[Brian C. Lane]

On Wed, Mar 07, 2012 at 06:24:02PM +0100, Joshua C. wrote:
>  2012/3/7 Joshua C. <joshuacov(a)googlemail.com&gt;:
>  > 2012/3/7 Joshua C. <joshuacov(a)googlemail.com&gt;:
>  >> 2012/3/7 Matthew Garrett <mjg59(a)srcf.ucam.org&gt;:
>  >>> On Wed, Mar 07, 2012 at 09:25:25AM +0100, Joshua C. wrote:
>  >>>> The following commit breaks the builds on f16 because the files
> don't exist:
>  >>>
>  >>> Sounds like you need newer Lorax.
>  >>>
>  >>> --
>  >>> Matthew Garrett | mjg59(a)srcf.ucam.org
>  >>
>  >> livecd didn't complain about a new lorax but I'll give it a try later
>  >> today and report back.
>  >
>  > One thing I forgot to mention: Yesterday after reverting the patch and
>  > recompiling the package, the build went fine.
>  
>  You were right. lorax wasn't even installed on my machine, but it has
>  always worked fine. Now it works again but throws the following
>  
>  Traceback (most recent call last):
>    File "/usr/sbin/mkefiboot", line 105, in <module>
>      mkmacboot(opt.bootdir, opt.outfile, opt.label, opt.icon)
>    File "/usr/sbin/mkefiboot", line 35, in mkmacboot
>      mkhfsimg(None, outfile, label=label, graft=graft)
>    File "/usr/lib/python2.7/site-packages/pylorax/imgutils.py", line
>  292, in mkhfsimg
>      mkfsargs=["-v", label], graft=graft)
>    File "/usr/lib/python2.7/site-packages/pylorax/imgutils.py", line
>  271, in mkfsimage
>      stdout=PIPE, stderr=PIPE)
>    File "/usr/lib64/python2.7/subprocess.py", line 506, in check_call
>      retcode = call(*popenargs, **kwargs)
>    File "/usr/lib64/python2.7/subprocess.py", line 493, in call
>      return Popen(*popenargs, **kwargs).wait()
>    File "/usr/lib64/python2.7/subprocess.py", line 679, in __init__
>      errread, errwrite)
>    File "/usr/lib64/python2.7/subprocess.py", line 1228, in _execute_child
>      raise child_exception
>  OSError: [Errno 2] No such file or directory
>  
>  but I'm not making efi builds so I can safely ignore it. The process
>  isn't interrupted as before.
>  
>  Someone has to make lorax a dependency for livecd-tools. 
16.11 added a lorax Requires, but I missed adding a hfsplus-tools
require to lorax-16.4.8, I'll get that fixed up in the next build.

Thanks!

-- 
Brian C. Lane | Anaconda Team | IRC: bcl #anaconda | Port Orchard, WA (PST8PDT)