Review Process

[Sourav Basu]

Hi,

I've been trying to do reviews informally but been unsuccessful so far. I would like to request all people who are well into reviews to create some wiki pages that give a little more detailed information about how to perform each check. It would really help novices.

Regards,

Sourav

[Ankur Sinha]

On Thu, 2012-10-25 at 12:30 -0700, Sourav Basu wrote:
> Hi,
>
> I've been trying to do reviews informally but been unsuccessful so
> far. I would like to request all people who are well into reviews to
> create some wiki pages that give a little more detailed information
> about how to perform each check. It would really help novices.
>
> Regards,
>
> Sourav

Sourav,

Reviewing implies matching the package against the current guidelines. I
use Kevin's template here:

https://fedoraproject.org/wiki/User:Kevin/Review_Template?rd=KevinFenzi/Revi...

Quite a few people now use the fedora-review tool. To each his own :)

[Ankur Sinha]

On Fri, 2012-10-26 at 10:14 +1100, Ankur Sinha wrote:
> Quite a few people now use the fedora-review tool. To each his own :)

Forgot the essential link:

https://fedoraproject.org/wiki/Packaging:ReviewGuidelines

[Dan Mashal]

fedora-review is extremely helpful.

Dan

On Thu, Oct 25, 2012 at 4:16 PM, Ankur Sinha  wrote:
> On Fri, 2012-10-26 at 10:14 +1100, Ankur Sinha wrote:
> > Quite a few people now use the fedora-review tool. To each his own :)
>
> Forgot the essential link:
>
> https://fedoraproject.org/wiki/Packaging:ReviewGuidelines
>
> fedora-join mailing list
> [e-mail]
> https://admin.fedoraproject.org/mailman/listinfo/fedora-join

[Mathieu Bridon]

On Friday, October 26, 2012 08:57 AM, Dan Mashal wrote:
> fedora-review is extremely helpful.

But Sourav's question was to understand how to check things.

fedora-review is an awesome tool (I use it regularly, don't get me 
wrong), but that won't help him understand how fedora-review checks the 
things it checks.

For example, if you don't know what "package does not contain static 
binaries" mean, it won't help you a lot that fedora-review can check for 
that.

Sourav, here's an idea. Following the long tradition of the Fedora 
Project being a community of contribution, how about you write the wiki 
pages you think would be useful? :)

In the process, you will actually learn how to perform these checks you 
are wondering about, and you will create a useful resource for future 
contributors.

Does that sound like something you can do?

Of course, if you start it and feel lost, don't hesitate to ask specific 
questions on the points you're blocking on. ;)

Cheers,

[Sourav Basu]

Hi,

Yea, definitely I could do that. I can write what the checks mean as I understand each and every check(I still have no clue about many of them). But its gonna take time I guess. So if someone also wants to help out writing a new wiki you are more than welcome. :)

Regards,

Sourav

________________________________
 From: Mathieu Bridon 
To: Dan Mashal  
Cc: Fedora Join Mailing list  
Sent: Friday, October 26, 2012 7:54 AM
Subject: Re: [Fedora-join] Review Process

On Friday, October 26, 2012 08:57 AM, Dan Mashal wrote:
> fedora-review is extremely helpful.

But Sourav's question was to understand how to check things.

fedora-review is an awesome tool (I use it regularly, don't get me wrong), but that won't help him understand how fedora-review checks the things it checks.

For example, if you don't know what "package does not contain static binaries" mean, it won't help you a lot that fedora-review can check for that.

Sourav, here's an idea. Following the long tradition of the Fedora Project being a community of contribution, how about you write the wiki pages you think would be useful? :)

In the process, you will actually learn how to perform these checks you are wondering about, and you will create a useful resource for future contributors.

Does that sound like something you can do?

Of course, if you start it and feel lost, don't hesitate to ask specific questions on the points you're blocking on. ;)

Cheers,

-- Mathieu
_______________________________________________
fedora-join mailing list
[e-mail]
https://admin.fedoraproject.org/mailman/listinfo/fedora-join