I cannot use %ifarch on a noarch package?

[Miro Hrončok]

Hello.

I wanted to ship the following snippet in python-hypothesis:

--------------------------------------------------
%check
%pytest -v -n auto \
   -k "not test_registered_from_entrypoint" \
   --ignore tests/codemods \
   --ignore tests/dpcontracts \
   --ignore tests/redis \
%ifarch s390x
   -k "not test_data_frames_with_timestamp_columns"
%endif
--------------------------------------------------

However, for some reason, the s390x part was not present on s390x. I've been 
banging my head on the desk for some time trying to figure out why it doesn't 
wok and apparently, it is because the package is noarch.

I've got around the problem by using:

%if "%{_arch}" == "s390x"
   -k "not test_data_frames_with_timestamp_columns"
%endif

Is that how it is supposed to work?

-- 
Miro Hrončok
--
Phone: [phone]
IRC: mhroncok

[Dominik 'Rathann' Mierzejewski]

Hi!

On Thursday, 11 March 2021 at 11:15, Miro Hrončok wrote:
>  Hello.
>  
>  I wanted to ship the following snippet in python-hypothesis:
>  
>  --------------------------------------------------
>  %check
>  %pytest -v -n auto \
>    -k "not test_registered_from_entrypoint" \
>    --ignore tests/codemods \
>    --ignore tests/dpcontracts \
>    --ignore tests/redis \
>  %ifarch s390x
>    -k "not test_data_frames_with_timestamp_columns"
>  %endif
>  --------------------------------------------------
>  
>  However, for some reason, the s390x part was not present on s390x. I've been
>  banging my head on the desk for some time trying to figure out why it
>  doesn't wok and apparently, it is because the package is noarch.
>  
>  I've got around the problem by using:
>  
>  %if "%{_arch}" == "s390x"
>    -k "not test_data_frames_with_timestamp_columns"
>  %endif
>  
>  Is that how it is supposed to work? 
I think the solution is to make the main package archful and the python3
subpackage(s) noarch. That way you'll build (and run tests) on all arches.

Regards,
Dominik
-- 
Fedora   https://getfedora.org  |  RPM Fusion  http://rpmfusion.org
There should be a science of discontent. People need hard times and
oppression to develop psychic muscles.
        -- from "Collected Sayings of Muad'Dib" by the Princess Irulan

[Miro Hrončok]

On 11. 03. 21 11:50, Dominik 'Rathann' Mierzejewski wrote:
>  Hi!
>  
>  On Thursday, 11 March 2021 at 11:15, Miro Hrončok wrote:
> > Hello.
> >
> > I wanted to ship the following snippet in python-hypothesis:
> >
> > --------------------------------------------------
> > %check
> > %pytest -v -n auto \
> >    -k "not test_registered_from_entrypoint" \
> >    --ignore tests/codemods \
> >    --ignore tests/dpcontracts \
> >    --ignore tests/redis \
> > %ifarch s390x
> >    -k "not test_data_frames_with_timestamp_columns"
> > %endif
> > --------------------------------------------------
> >
> > However, for some reason, the s390x part was not present on s390x. I've been
> > banging my head on the desk for some time trying to figure out why it
> > doesn't wok and apparently, it is because the package is noarch.
> >
> > I've got around the problem by using:
> >
> > %if "%{_arch}" == "s390x"
> >    -k "not test_data_frames_with_timestamp_columns"
> > %endif
> >
> > Is that how it is supposed to work?
>  
>  I think the solution is to make the main package archful and the python3
>  subpackage(s) noarch. That way you'll build (and run tests) on all arches. 
That is indeed a thing I am thinking about doing for all Python packages for a 
long time already, but I don't want to open that Pandora box (yet anyway).

-- 
Miro Hrončok
--
Phone: [phone]
IRC: mhroncok