FTBFS: chocolate-doom

[Jordan Christiansen]

I noticed that chocolate-doom wasn't showing up in the package search results, so I
decided to look into why and help out if I could.

When the Fedora 32 mass rebuild happened, chocolate doom failed to build[1] because of
changes in the default settings in GCC 10. I submitted a patch to upstream to fix it and
it was accepted to master. Now I want to make sure that the package makes it into Fedora
32. What needs to be done to make that happen? What is the policy for packages that fail
to build? What's the deadline for getting it fixed? If upstream doesn't cut a
release before the deadline, should we carry my patch downstream?

[1]: https://bugzilla.redhat.com/show_bug.cgi?id=1799222

[Gwyn Ciesla]

Ideally, we'd wait for the next release. Next best would be if the maintainer applied
the patch in the mean time.  Since that hasn't happened, someone with provenpackager
rights with an interest in a health Doom ecosystem could add the patch and push a build
for f32.

So I will. :)


-- 
Gwyn Ciesla
she/her/hers
------------------------------------------------ 
in your fear, seek only peace 
in your fear, seek only love
-d. bowie

Sent with ProtonMail Secure Email.

‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
On Thursday, March 19, 2020 1:11 PM, Jordan Christiansen <xordspar0(a)gmail.com&gt;
wrote:

>  I noticed that chocolate-doom wasn't showing up in the package
> search results, so I decided to look into why and help out if I could.
>   
>  When the Fedora 32 mass rebuild happened, chocolate doom failed to
> build[1] because of changes in the default settings in GCC 10. I submitted a patch to
> upstream to fix it and it was accepted to master. Now I want to make sure that the package
> makes it into Fedora 32. What needs to be done to make that happen? What is the policy for
> packages that fail to build? What's the deadline for getting it fixed? If upstream
> doesn't cut a release before the deadline, should we carry my patch downstream?
>   
>  [1]: https://bugzilla.redhat.com/show_bug.cgi?id=1799222
>   
>  packaging mailing list -- packaging(a)lists.fedoraproject.org
>  To unsubscribe send an email to packaging-leave(a)lists.fedoraproject.org
>  Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
>  List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
>  List Archives:
> https://lists.fedoraproject.org/archives/list/[e-mail]...

[Jordan Christiansen]

Yay! The last release was in 2017 and there are over 800 commits to master
since then. Unless it's just a backport, I doubt there will be an upstream
release. I agree that carrying the patch downstream is the most likely way
to get it done in time.

On Thu, Mar 19, 2020 at 1:15 PM Gwyn Ciesla <gwync(a)protonmail.com&gt; wrote:

>  Ideally, we'd wait for the next release. Next best would be if
> the
>  maintainer applied the patch in the mean time.  Since that hasn't happened,
>  someone with provenpackager rights with an interest in a health Doom
>  ecosystem could add the patch and push a build for f32.
>
>  So I will. :)
>
>
>  --
>  Gwyn Ciesla
>  she/her/hers
>  ------------------------------------------------
>  in your fear, seek only peace
>  in your fear, seek only love
>  -d. bowie
>
>  Sent with ProtonMail Secure Email.
>
>  ‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
>  On Thursday, March 19, 2020 1:11 PM, Jordan Christiansen <
>  xordspar0(a)gmail.com&gt; wrote:
>
>  > I noticed that chocolate-doom wasn't showing up in the package search
>  results, so I decided to look into why and help out if I could.
>  >
>
>  > When the Fedora 32 mass rebuild happened, chocolate doom failed to
>  build[1] because of changes in the default settings in GCC 10. I submitted
>  a patch to upstream to fix it and it was accepted to master. Now I want to
>  make sure that the package makes it into Fedora 32. What needs to be done
>  to make that happen? What is the policy for packages that fail to build?
>  What's the deadline for getting it fixed? If upstream doesn't cut a release
>  before the deadline, should we carry my patch downstream?
>  >
>
>  > [1]: https://bugzilla.redhat.com/show_bug.cgi?id=1799222
>  >
>
>  > packaging mailing list -- packaging(a)lists.fedoraproject.org
>  > To unsubscribe send an email to packaging-leave(a)lists.fedoraproject.org
>  > Fedora Code of Conduct:
>  https://docs.fedoraproject.org/en-US/project/code-of-conduct/
>  > List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
>  > List Archives:
>  https://lists.fedoraproject.org/archives/list/[e-mail]...
>
>  _______________________________________________
>  packaging mailing list -- packaging(a)lists.fedoraproject.org
>  To unsubscribe send an email to packaging-leave(a)lists.fedoraproject.org
>  Fedora Code of Conduct:
>  https://docs.fedoraproject.org/en-US/project/code-of-conduct/
>  List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
>  List Archives:
>  https://lists.fedoraproject.org/archives/list/[e-mail]...
>

[Gwyn Ciesla]

Yeah. And who knows, they might cut a release at any moment. Until then, test and give
karma:

https://bodhi.fedoraproject.org/updates/FEDORA-2020-7feeffda7b

-- 
Gwyn Ciesla
she/her/hers
------------------------------------------------ 
in your fear, seek only peace 
in your fear, seek only love
-d. bowie

Sent with ProtonMail Secure Email.

‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
On Thursday, March 19, 2020 1:19 PM, Jordan Christiansen <xordspar0(a)gmail.com&gt;
wrote:

>  Yay! The last release was in 2017 and there are over 800 commits to
> master since then. Unless it's just a backport, I doubt there will be an upstream
> release. I agree that carrying the patch downstream is the most likely way to get it done
> in time.
>   
>  On Thu, Mar 19, 2020 at 1:15 PM Gwyn Ciesla
> <gwync(a)protonmail.com&gt; wrote:
>   
>  > Ideally, we'd wait for the next release. Next best would be
> if the maintainer applied the patch in the mean time.  Since that hasn't happened,
> someone with provenpackager rights with an interest in a health Doom ecosystem could add
> the patch and push a build for f32.
>  >  
>  > So I will. :)
>  >  
>  > -- 
>  > Gwyn Ciesla
>  > she/her/hers
>  > ------------------------------------------------ 
>  > in your fear, seek only peace 
>  > in your fear, seek only love
>  > -d. bowie
>  >  
>  > Sent with ProtonMail Secure Email.
>  >  
>  > ‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
>  > On Thursday, March 19, 2020 1:11 PM, Jordan Christiansen <xordspar0(a)gmail.com&gt;
> wrote:
>  >  
>  > > I noticed that chocolate-doom wasn't showing up in the
> package search results, so I decided to look into why and help out if I could.
>  > >
>  >  
>  > > When the Fedora 32 mass rebuild happened, chocolate doom
> failed to build[1] because of changes in the default settings in GCC 10. I submitted a
> patch to upstream to fix it and it was accepted to master. Now I want to make sure that
> the package makes it into Fedora 32. What needs to be done to make that happen? What is
> the policy for packages that fail to build? What's the deadline for getting it fixed?
> If upstream doesn't cut a release before the deadline, should we carry my patch
> downstream?
>  > >
>  >  
>  > > [1]: https://bugzilla.redhat.com/show_bug.cgi?id=1799222
>  > >
>  >  
>  > > packaging mailing list --
> packaging(a)lists.fedoraproject.org
>  > > To unsubscribe send an email to packaging-leave(a)lists.fedoraproject.org
>  > > Fedora Code of Conduct:
> https://docs.fedoraproject.org/en-US/project/code-of-conduct/
>  > > List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
>  > > List Archives:
> https://lists.fedoraproject.org/archives/list/[e-mail]...
>  >  
>  > _______________________________________________
>  > packaging mailing list -- packaging(a)lists.fedoraproject.org
>  > To unsubscribe send an email to packaging-leave(a)lists.fedoraproject.org
>  > Fedora Code of Conduct:
> https://docs.fedoraproject.org/en-US/project/code-of-conduct/
>  > List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
>  > List Archives:
> https://lists.fedoraproject.org/archives/list/[e-mail]...

[Jordan Christiansen]

Great, I tested it and it works. I don't think I have permission to log in
and give it karma though.

On Thu, Mar 19, 2020 at 1:28 PM Gwyn Ciesla <gwync(a)protonmail.com&gt; wrote:

>  Yeah. And who knows, they might cut a release at any moment. Until
> then,
>  test and give karma:
>
>  https://bodhi.fedoraproject.org/updates/FEDORA-2020-7feeffda7b
>
>  --
>  Gwyn Ciesla
>  she/her/hers
>  ------------------------------------------------
>  in your fear, seek only peace
>  in your fear, seek only love
>  -d. bowie
>
>
>  Sent with ProtonMail <https://protonmail.com> Secure Email.
>
>  ‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
>  On Thursday, March 19, 2020 1:19 PM, Jordan Christiansen <
>  xordspar0(a)gmail.com&gt; wrote:
>
>  Yay! The last release was in 2017 and there are over 800 commits to master
>  since then. Unless it's just a backport, I doubt there will be an upstream
>  release. I agree that carrying the patch downstream is the most likely way
>  to get it done in time.
>
>  On Thu, Mar 19, 2020 at 1:15 PM Gwyn Ciesla <gwync(a)protonmail.com&gt; wrote:
>
> > Ideally, we'd wait for the next release. Next best would be if the
> > maintainer applied the patch in the mean time.  Since that hasn't happened,
> > someone with provenpackager rights with an interest in a health Doom
> > ecosystem could add the patch and push a build for f32.
> >
> > So I will. :)
> >
> >
> > --
> > Gwyn Ciesla
> > she/her/hers
> > ------------------------------------------------
> > in your fear, seek only peace
> > in your fear, seek only love
> > -d. bowie
> >
> > Sent with ProtonMail Secure Email.
> >
> > ‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
> > On Thursday, March 19, 2020 1:11 PM, Jordan Christiansen <
> > xordspar0(a)gmail.com&gt; wrote:
> >
> > > I noticed that chocolate-doom wasn't showing up in the package search
> > results, so I decided to look into why and help out if I could.
> > >
> >
> > > When the Fedora 32 mass rebuild happened, chocolate doom failed to
> > build[1] because of changes in the default settings in GCC 10. I submitted
> > a patch to upstream to fix it and it was accepted to master. Now I want to
> > make sure that the package makes it into Fedora 32. What needs to be done
> > to make that happen? What is the policy for packages that fail to build?
> > What's the deadline for getting it fixed? If upstream doesn't cut a release
> > before the deadline, should we carry my patch downstream?
> > >
> >
> > > [1]: https://bugzilla.redhat.com/show_bug.cgi?id=1799222
> > >
> >
> > > packaging mailing list -- packaging(a)lists.fedoraproject.org
> > > To unsubscribe send an email to packaging-leave(a)lists.fedoraproject.org
> > > Fedora Code of Conduct:
> > https://docs.fedoraproject.org/en-US/project/code-of-conduct/
> > > List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
> > > List Archives:
> > https://lists.fedoraproject.org/archives/list/[e-mail]...
> >
> > _______________________________________________
> > packaging mailing list -- packaging(a)lists.fedoraproject.org
> > To unsubscribe send an email to packaging-leave(a)lists.fedoraproject.org
> > Fedora Code of Conduct:
> > https://docs.fedoraproject.org/en-US/project/code-of-conduct/
> > List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
> > List Archives:
> > https://lists.fedoraproject.org/archives/list/[e-mail]...
> >
>
>  _______________________________________________
>  packaging mailing list -- packaging(a)lists.fedoraproject.org
>  To unsubscribe send an email to packaging-leave(a)lists.fedoraproject.org
>  Fedora Code of Conduct:
>  https://docs.fedoraproject.org/en-US/project/code-of-conduct/
>  List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
>  List Archives:
>  https://lists.fedoraproject.org/archives/list/[e-mail]...
>

[Vít Ondruch]

Dne 20. 03. 20 v 16:00 Jordan Christiansen napsal(a):
>  Great, I tested it and it works. I don't think I have permission
> to
>  log in and give it karma though. 

Having Fedora account should be enough to give a karma. Here is Fedora
Magazine article, which describes the workflow:

https://fedoramagazine.org/contributing-fedora-testing-packages/


Cheers,


Vít




>  On Thu, Mar 19, 2020 at 1:28 PM Gwyn Ciesla <gwync(a)protonmail.com
>  <mailto:[e-mail]>> wrote:
>
>      Yeah. And who knows, they might cut a release at any moment. Until
>      then, test and give karma:
>
>      https://bodhi.fedoraproject.org/updates/FEDORA-2020-7feeffda7b
>
>      -- 
>      Gwyn Ciesla
>      she/her/hers
>      ------------------------------------------------ 
>      in your fear, seek only peace 
>      in your fear, seek only love
>      -d. bowie
>
>
>      Sent with ProtonMail <https://protonmail.com> Secure Email.
>
>      ‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
>      On Thursday, March 19, 2020 1:19 PM, Jordan Christiansen
>      <xordspar0(a)gmail.com <mailto:[e-mail]>> wrote:
>
> >     Yay! The last release was in 2017 and there are over 800 commits
> >     to master since then. Unless it's just a backport, I doubt there
> >     will be an upstream release. I agree that carrying the patch
> >     downstream is the most likely way to get it done in time.
> >
> >     On Thu, Mar 19, 2020 at 1:15 PM Gwyn Ciesla <gwync(a)protonmail.com
> >     <mailto:[e-mail]>> wrote:
> >
> >         Ideally, we'd wait for the next release. Next best would be
> >         if the maintainer applied the patch in the mean time.  Since
> >         that hasn't happened, someone with provenpackager rights with
> >         an interest in a health Doom ecosystem could add the patch
> >         and push a build for f32.
> >
> >         So I will. :)
> >
> >
> >         -- 
> >         Gwyn Ciesla
> >         she/her/hers
> >         ------------------------------------------------ 
> >         in your fear, seek only peace 
> >         in your fear, seek only love
> >         -d. bowie
> >
> >         Sent with ProtonMail Secure Email.
> >
> >         ‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
> >         On Thursday, March 19, 2020 1:11 PM, Jordan Christiansen
> >         <xordspar0(a)gmail.com <mailto:[e-mail]>> wrote:
> >
> >         > I noticed that chocolate-doom wasn't showing up in the
> >         package search results, so I decided to look into why and
> >         help out if I could.
> >         >
> >
> >         > When the Fedora 32 mass rebuild happened, chocolate doom
> >         failed to build[1] because of changes in the default settings
> >         in GCC 10. I submitted a patch to upstream to fix it and it
> >         was accepted to master. Now I want to make sure that the
> >         package makes it into Fedora 32. What needs to be done to
> >         make that happen? What is the policy for packages that fail
> >         to build? What's the deadline for getting it fixed? If
> >         upstream doesn't cut a release before the deadline, should we
> >         carry my patch downstream?
> >         >
> >
> >         > [1]: https://bugzilla.redhat.com/show_bug.cgi?id=1799222
> >         >
> >
> >         > packaging mailing list -- packaging(a)lists.fedoraproject.org
> >         <mailto:[e-mail]>
> >         > To unsubscribe send an email to
> >         packaging-leave(a)lists.fedoraproject.org
> >         <mailto:[e-mail]>
> >         > Fedora Code of Conduct:
> >         https://docs.fedoraproject.org/en-US/project/code-of-conduct/
> >         > List Guidelines:
> >         https://fedoraproject.org/wiki/Mailing_list_guidelines
> >         > List Archives:
> >        
> https://lists.fedoraproject.org/archives/list/[e-mail]...
> >
> >         _______________________________________________
> >         packaging mailing list -- packaging(a)lists.fedoraproject.org
> >         <mailto:[e-mail]>
> >         To unsubscribe send an email to
> >         packaging-leave(a)lists.fedoraproject.org
> >         <mailto:[e-mail]>
> >         Fedora Code of Conduct:
> >         https://docs.fedoraproject.org/en-US/project/code-of-conduct/
> >         List Guidelines:
> >         https://fedoraproject.org/wiki/Mailing_list_guidelines
> >         List Archives:
> >        
> https://lists.fedoraproject.org/archives/list/[e-mail]...
> >
>
>      _______________________________________________
>      packaging mailing list -- packaging(a)lists.fedoraproject.org
>      <mailto:[e-mail]>
>      To unsubscribe send an email to
>      packaging-leave(a)lists.fedoraproject.org
>      <mailto:[e-mail]>
>      Fedora Code of Conduct:
>      https://docs.fedoraproject.org/en-US/project/code-of-conduct/
>      List Guidelines:
>      https://fedoraproject.org/wiki/Mailing_list_guidelines
>      List Archives:
>      https://lists.fedoraproject.org/archives/list/[e-mail]...
>
>
>  _______________________________________________
>  packaging mailing list -- packaging(a)lists.fedoraproject.org
>  To unsubscribe send an email to packaging-leave(a)lists.fedoraproject.org
>  Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
>  List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
>  List Archives:
> https://lists.fedoraproject.org/archives/list/[e-mail]...

[Jordan Christiansen]

Cool, thank you! I'm not sure, but I think the problem was that I hadn't
signed the contributor agreement.

On Mon, Mar 23, 2020 at 3:11 AM Vít Ondruch <vondruch(a)redhat.com&gt; wrote:

>  Dne 20. 03. 20 v 16:00 Jordan Christiansen napsal(a):
>
>  Great, I tested it and it works. I don't think I have permission to log in
>  and give it karma though.
>
>
>  Having Fedora account should be enough to give a karma. Here is Fedora
>  Magazine article, which describes the workflow:
>
>  https://fedoramagazine.org/contributing-fedora-testing-packages/
>
>
>  Cheers,
>
>
>  Vít
>
>
>
>
>
>  On Thu, Mar 19, 2020 at 1:28 PM Gwyn Ciesla <gwync(a)protonmail.com&gt; wrote:
>
> > Yeah. And who knows, they might cut a release at any moment. Until then,
> > test and give karma:
> >
> > https://bodhi.fedoraproject.org/updates/FEDORA-2020-7feeffda7b
> >
> > --
> > Gwyn Ciesla
> > she/her/hers
> > ------------------------------------------------
> > in your fear, seek only peace
> > in your fear, seek only love
> > -d. bowie
> >
> >
> > Sent with ProtonMail <https://protonmail.com> Secure Email.
> >
> > ‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
> > On Thursday, March 19, 2020 1:19 PM, Jordan Christiansen <
> > xordspar0(a)gmail.com&gt; wrote:
> >
> > Yay! The last release was in 2017 and there are over 800 commits to
> > master since then. Unless it's just a backport, I doubt there will be an
> > upstream release. I agree that carrying the patch downstream is the most
> > likely way to get it done in time.
> >
> > On Thu, Mar 19, 2020 at 1:15 PM Gwyn Ciesla <gwync(a)protonmail.com&gt; wrote:
> >
> >> Ideally, we'd wait for the next release. Next best would be if the
> >> maintainer applied the patch in the mean time.  Since that hasn't happened,
> >> someone with provenpackager rights with an interest in a health Doom
> >> ecosystem could add the patch and push a build for f32.
> >>
> >> So I will. :)
> >>
> >>
> >> --
> >> Gwyn Ciesla
> >> she/her/hers
> >> ------------------------------------------------
> >> in your fear, seek only peace
> >> in your fear, seek only love
> >> -d. bowie
> >>
> >> Sent with ProtonMail Secure Email.
> >>
> >> ‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
> >> On Thursday, March 19, 2020 1:11 PM, Jordan Christiansen <
> >> xordspar0(a)gmail.com&gt; wrote:
> >>
> >> > I noticed that chocolate-doom wasn't showing up in the package search
> >> results, so I decided to look into why and help out if I could.
> >> >
> >>
> >> > When the Fedora 32 mass rebuild happened, chocolate doom failed to
> >> build[1] because of changes in the default settings in GCC 10. I submitted
> >> a patch to upstream to fix it and it was accepted to master. Now I want to
> >> make sure that the package makes it into Fedora 32. What needs to be done
> >> to make that happen? What is the policy for packages that fail to build?
> >> What's the deadline for getting it fixed? If upstream doesn't cut a
> release
> >> before the deadline, should we carry my patch downstream?
> >> >
> >>
> >> > [1]: https://bugzilla.redhat.com/show_bug.cgi?id=1799222
> >> >
> >>
> >> > packaging mailing list -- packaging(a)lists.fedoraproject.org
> >> > To unsubscribe send an email to
> >> packaging-leave(a)lists.fedoraproject.org
> >> > Fedora Code of Conduct:
> >> https://docs.fedoraproject.org/en-US/project/code-of-conduct/
> >> > List Guidelines:
> >> https://fedoraproject.org/wiki/Mailing_list_guidelines
> >> > List Archives:
> >> https://lists.fedoraproject.org/archives/list/[e-mail]...
> >>
> >> _______________________________________________
> >> packaging mailing list -- packaging(a)lists.fedoraproject.org
> >> To unsubscribe send an email to packaging-leave(a)lists.fedoraproject.org
> >> Fedora Code of Conduct:
> >> https://docs.fedoraproject.org/en-US/project/code-of-conduct/
> >> List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
> >> List Archives:
> >> https://lists.fedoraproject.org/archives/list/[e-mail]...
> >>
> >
> > _______________________________________________
> > packaging mailing list -- packaging(a)lists.fedoraproject.org
> > To unsubscribe send an email to packaging-leave(a)lists.fedoraproject.org
> > Fedora Code of Conduct:
> > https://docs.fedoraproject.org/en-US/project/code-of-conduct/
> > List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
> > List Archives:
> > https://lists.fedoraproject.org/archives/list/[e-mail]...
> >
>
>  _______________________________________________
>  packaging mailing list -- packaging(a)lists.fedoraproject.org
>  To unsubscribe send an email to packaging-leave(a)lists.fedoraproject.org
>  Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
>  List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
>  List Archives:
> https://lists.fedoraproject.org/archives/list/[e-mail]...
>
>  _______________________________________________
>  packaging mailing list -- packaging(a)lists.fedoraproject.org
>  To unsubscribe send an email to packaging-leave(a)lists.fedoraproject.org
>  Fedora Code of Conduct:
>  https://docs.fedoraproject.org/en-US/project/code-of-conduct/
>  List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
>  List Archives:
>  https://lists.fedoraproject.org/archives/list/[e-mail]...
>