> - What is the trigger to run CI?
The running is currently run for each koji build and dist-git pull request
...
>
> Both cron (regular running) and trigger by pull-request to target
> RPM packages repositoris?
There is no cron, it reacts on a finished koji build (scratch or
non-scratch)
Okay, which package's koji build is the target for the trigger?
Is it only rpms/ruby?
Because we are actually testing Rails in the CI test.
I prefer every Ruby on Rails groups are the target.
https://apps.fedoraproject.org/koschei/groups/ruby-rails
And here are 6 use cases for testing Rails.
I want to add these 6 uses cases to CI at first.
https://github.com/junaruga/fedora-blog/blob/master/2018-06-20-test-for-r...
I have not checked at the target Fedora CI documents yet.
Jun
On Wed, Jun 20, 2018 at 6:33 PM, Miroslav Vadkerti <mvadkert(a)redhat.com> wrote:
> Hi,
>
> On Wed, Jun 20, 2018 at 5:02 PM, Jun Aruga <jaruga(a)redhat.com> wrote:
>>
>> Hi Miroslav,
>>
>> Thanks for the cooperation.
>
>
> Sure thing :)
>
>
>>
>>
>> > And you would like to automate as much as possible from that, cool.
>>
>> Yes, as much as possible :)
>>
>> > I created that shared test space [1] some time ago. The idea behind
>> > it was to host ruby related integration and other tests, that work on
>> > all
>> > supported
>> > Fedora releases and do not fit into a specific component's dist-git.
>> > Idea
>> > for them was to include link them from multiple ruby packages.
>> >
>> > In your case, I guess theste tests could be added here, as they seem
>> > to be generic enough. If you would need to include that test also
>> > from other compoents, just link them according to [1]
>>
>> Your idea is exactly what I want.
>>
>> > This is also a possibility, but I would be against it (creating another
>> > repository in tests namespace). Feel free to use the tests/ruby repo,
>> > if you decide to go with the shared test repository.
>>
>> > If you feel that these tests are not integration, and are really
>> > for ruby-on-rails, please add the directly to dist-git [2], similarly
>> > to what I did lately for rubygem-bundler [3]
>>
>> Right now I will try to understand the way for option 1: tests/ruby at
>> first, reading the document.
>> In the future if it is problem to manage the rails test by test/ruby,
>> we can split and move it.
>>
>> Maintaining the rails tests on 1 part is better and easier.
>
>
> Sure, you should choose as you like.
>
>
>>
>>
>>
>> At first what I want to know is
>> - How to run Fedora CI manually.
>
>
> The pipeline itself cannot be run manually, but that should not be needed
> very much. You should be able to execute tests on a VM or inside a docker
> image via ansible. Quick start guide is here:
>
>
https://fedoraproject.org/wiki/CI/Quick_Start_Guide
>
>
>>
> - What is the trigger to run CI?
The running is currently run for each koji build and dist-git pull request
...
>
> Both cron (regular running) and trigger by pull-request to target
> RPM packages repositoris?
There is no cron, it reacts on a finished koji build (scratch or
non-scratch)
>
>
>>
>> > [2]
>>
https://src.fedoraproject.org/rpms/rubygem-rails
>>
>>
>> What is the actual link?
>
>
> I think it was this :)
>
> HTH
> /M
>
>
>>
>>
>> Jun
>>
>>
>> On Tue, Jun 19, 2018 at 5:23 PM, Miroslav Vadkerti <mvadkert(a)redhat.com>
>> wrote:
>> > Hi Jun!
>> >
>> > On Tue, Jun 19, 2018 at 3:12 PM, Jun Aruga <jaruga(a)redhat.com> wrote:
>> >>
>> >> Hi @mvadkert, and people in Ruby SIG
>> >>
>> >> @mvadkert, I found you in below pull-request.
>> >>
https://src.fedoraproject.org/rpms/rubygem-bundler/pull-request/4
>> >> And I was introduced by Vit that you are good person to discuss about
>> >> CI (Fedora CI?).
>> >
>> >
>> > That is correct, I am adding our mailing list, where there are more of
>> > us :)
>> >
>> >
>> >>
>> >>
>> >> The thing that I want to discuss with you, and what I want to improve
>> >> is to add CI environment for Ruby on Rails.
>> >
>> >
>> > I see, cool!
>> >
>> >
>> >>
>> >>
>> >> For every version up of Ruby on Rails, in my impression, we are doing
>> >> similar things manually such as running use cases on page [1], editing
>> >> packages in rubyonrails group file in fedora-comps project, fixing
>> >> build failure seeing [3].
>> >
>> >
>> > And you would like to automate as much as possible from that, cool.
>> >
>> >>
>> >>
>> >> There are options
>> >> Option 1. Update tests/ruby. The Rails test has already been in
>> >>
>> >>
>> >>
https://src.fedoraproject.org/tests/ruby/blob/master/f/run-basic-rails-ap...
>> >
>> >
>> > I created that shared test space [1] some time ago. The idea behind
>> > it was to host ruby related integration and other tests, that work on
>> > all
>> > supported
>> > Fedora releases and do not fit into a specific component's dist-git.
>> > Idea
>> > for them was to include link them from multiple ruby packages.
>> >
>> > In your case, I guess theste tests could be added here, as they seem
>> > to be generic enough. If you would need to include that test also
>> > from other compoents, just link them according to [1]
>> >
>> >> .
>> >> Option 2. Create new tests name space
>> >> - 2.1. tests/rubygem-rails (rubygem-rails is a top package of Ruby on
>> >> Rails.)
>> >> - 2.2. tests/rails (Simple name)
>> >> - 2.3. tests/ruby-rails (Same name with the group name [3])
>> >> - 2.4. tests/rubyonrails (Same name with the group name [2])
>> >
>> >
>> > This is also a possibility, but I would be against it (creating another
>> > repository in tests namespace). Feel free to use the tests/ruby repo,
>> > if you decide to go with the shared test repository.
>> >
>> > If you feel that these tests are not integration, and are really
>> > for ruby-on-rails, please add the directly to dist-git [2], similarly
>> > to what I did lately for rubygem-bundler [3]
>> >
>> >>
>> >> How do you think about it?
>> >
>> >
>> > Note that there is not clear winner here. It all depends on you how
>> > you want to structure and maintain your test code.
>> >
>> >
>> >>
>> >> Which name space is better to run the CI for rails?
>> >> Personally I prefer 2. because I want to run only rails related tests
>> >> without necessary dependencies.
>> >
>> >
>> > I would go for 1. or directly to dist-git of ruby-on-rails as tried
>> > to explain aboce.
>> >
>> >
>> >>
>> >> The feed back from other people is welcome.
>> >
>> >
>> > Feel free to reach out if this still would be unclear or I can
>> > provide any more info.
>> >
>> > HTH,
>> >
>> > /M
>> >
>> >
>> >>
>> >>
>> >> [1]
https://fedoraproject.org/wiki/Changes/R
>> >>
>> >> For integration tests, this is a very nice fit. We could simply also
>> >>
>> >> include this integration test to
>> >>
>> >> uby_on_Rails_5.2
>> >> [2]
https://pagure.io/fedora-comps/blob/master/f/comps-f29.xml.in#_5204
>> >> [3]
https://apps.fedoraproject.org/koschei/groups/ruby-rails
>> >>
>> >
>> > [1] what is shared test namespace:
>> >
https://fedoraproject.org/wiki/CI/Share_Test_Code
>> > [2]
>> > [3]
https://src.fedoraproject.org/rpms/rubygem-bundler/pull-request/4
>> >
>> >
>> >>
>> >>
>> >> --
>> >> Jun Aruga jaruga(a)redhat.com
>> >
>> >
>> >
>> >
>> > --
>> > Miroslav Vadkerti :: Principal QE :: BaseOS QE Security
>> > IRC mvadkert #qe #urt #brno #rpmdiff :: GPG 0x25881087
>> > Desk Phone +420 532 294 129 :: Mobile +420 773 944 252
>> > Red Hat Czech s.r.o, Purkyňova 99/71, 612 00, Brno, CR
>> >
>>
>>
>>
>> --
>> Jun Aruga jaruga(a)redhat.com
>> IRC: jaruga, Office: TPB(Technology Park Brno) Building C 1F, Brno,
>> Czech Republic
>
>
>
>
> --
> Miroslav Vadkerti :: Principal QE :: BaseOS QE Security
> IRC mvadkert #qe #urt #brno #rpmdiff :: GPG 0x25881087
> Desk Phone +420 532 294 129 :: Mobile +420 773 944 252
> Red Hat Czech s.r.o, Purkyňova 99/71, 612 00, Brno, CR
>
--
Jun Aruga jaruga(a)redhat.com
IRC: jaruga, Office: TPB(Technology Park Brno) Building C 1F, Brno,
Czech Republic