asciidoctor-diagram missing from Fedora

[Christopher Brown]

Hello,

I've upgrade to F33 and discovered that we are missing asciidoctor-diagram
as a requirement for some internal tooling.

https://rubygems.org/gems/asciidoctor-diagram/
https://github.com/asciidoctor/asciidoctor-diagram

I am putting together a spec file for this now however tests are failing
with missing executables in the path. I am able to work around some by
installing the package but the majority we don't appear to ship packages
for - see example below.

Again, I'm sure this is something obvious (hopefully) and would appreciate
a steer in the right direction. I've attempted to pass various options to
rspec but to no avail.

Thanks for any advice in advance.

425) Asciidoctor::Diagram::WavedromBlockProcessor should support scaling
diagrams
       Failure/Error: raise "Could not find the #{cmd_names.map { |c|
"'#{c}'" }.join(', ')} executable in PATH; add it to the PATH or specify
its location using the '#{attr_names[0]}' document attribute"

RuntimeError:
         asciidoctor: FAILED: <stdin>: Failed to load AsciiDoc document -
Could not find the 'WaveDromEditor' executable in PATH; add it to the PATH
or specify its location using the 'WaveDromEditor' document attribute
       Shared Example Group: "block" called from ./spec/wavedrom_spec.rb:16
       # ./lib/asciidoctor-diagram/diagram_source.rb:130:in `find_command'
       # ./lib/asciidoctor-diagram/wavedrom/converter.rb:39:in `convert'
       # ./lib/asciidoctor-diagram/diagram_processor.rb:170:in
`create_image_block'
       # ./lib/asciidoctor-diagram/diagram_processor.rb:86:in `process'
       #
/usr/share/gems/gems/asciidoctor-2.0.10/lib/asciidoctor/parser.rb:1040:in
`[]'
       #
/usr/share/gems/gems/asciidoctor-2.0.10/lib/asciidoctor/parser.rb:1040:in
`build_block'
       #
/usr/share/gems/gems/asciidoctor-2.0.10/lib/asciidoctor/parser.rb:886:in
`next_block'
       #
/usr/share/gems/gems/asciidoctor-2.0.10/lib/asciidoctor/parser.rb:379:in
`next_section'
       #
/usr/share/gems/gems/asciidoctor-2.0.10/lib/asciidoctor/parser.rb:364:in
`next_section'
       #
/usr/share/gems/gems/asciidoctor-2.0.10/lib/asciidoctor/parser.rb:97:in
`parse'
       #
/usr/share/gems/gems/asciidoctor-2.0.10/lib/asciidoctor/document.rb:549:in
`parse'
       #
/usr/share/gems/gems/asciidoctor-2.0.10/lib/asciidoctor/load.rb:83:in `load'
       # ./spec/test_helper.rb:70:in `load_asciidoc'
       # ./spec/shared_examples.rb:592:in `block (2 levels) in <top
(required)>'
       # ./spec/test_helper.rb:112:in `block (3 levels) in <top (required)>'
       # ./spec/test_helper.rb:111:in `chdir'
       # ./spec/test_helper.rb:111:in `block (2 levels) in <top (required)>'
       # ------------------
       # --- Caused by: ---
       # RuntimeError:
       #   Could not find the 'WaveDromEditor' executable in PATH; add it
to the PATH or specify its location using the 'WaveDromEditor' document
attribute
       #   ./lib/asciidoctor-diagram/diagram_source.rb:130:in `find_command'

[Vít Ondruch]

When we tried to get ascii_binder into Fedora, we get this far with 
asciidoctor-diagram.

https://fedorapeople.org/cgit/jackorp/public_git/rubygem-asciidoctor-diagram...

But we rather avoided the dependency in ascii_binder for the time being:

https://src.fedoraproject.org/rpms/rubygem-ascii_binder/blob/0d17b858e07ea9d...

Vít

Dne 27. 10. 20 v 17:31 Christopher Brown napsal(a):
> Hello,
>
> I've upgrade to F33 and discovered that we are missing 
> asciidoctor-diagram as a requirement for some internal tooling.
>
> https://rubygems.org/gems/asciidoctor-diagram/ 
> https://rubygems.org/gems/asciidoctor-diagram/
> https://github.com/asciidoctor/asciidoctor-diagram 
> https://github.com/asciidoctor/asciidoctor-diagram
>
> I am putting together a spec file for this now however tests are 
> failing with missing executables in the path. I am able to work around 
> some by installing the package but the majority we don't appear to 
> ship packages for - see example below.
>
> Again, I'm sure this is something obvious (hopefully) and would 
> appreciate a steer in the right direction. I've attempted to pass 
> various options to rspec but to no avail.
>
> Thanks for any advice in advance.
>
> 425) Asciidoctor::Diagram::WavedromBlockProcessor should support 
> scaling diagrams
>        Failure/Error: raise "Could not find the #{cmd_names.map { |c| 
> "'#{c}'" }.join(', ')} executable in PATH; add it to the PATH or 
> specify its location using the '#{attr_names[0]}' document attribute"
>
> RuntimeError:
>          asciidoctor: FAILED: <stdin>: Failed to load AsciiDoc 
> document - Could not find the 'WaveDromEditor' executable in PATH; add 
> it to the PATH or specify its location using the 'WaveDromEditor' 
> document attribute
>        Shared Example Group: "block" called from 
> ./spec/wavedrom_spec.rb:16
>        # ./lib/asciidoctor-diagram/diagram_source.rb:130:in `find_command'
>        # ./lib/asciidoctor-diagram/wavedrom/converter.rb:39:in `convert'
>        # ./lib/asciidoctor-diagram/diagram_processor.rb:170:in 
> `create_image_block'
>        # ./lib/asciidoctor-diagram/diagram_processor.rb:86:in `process'
>        # 
> /usr/share/gems/gems/asciidoctor-2.0.10/lib/asciidoctor/parser.rb:1040:in 
> `[]'
>        # 
> /usr/share/gems/gems/asciidoctor-2.0.10/lib/asciidoctor/parser.rb:1040:in 
> `build_block'
>        # 
> /usr/share/gems/gems/asciidoctor-2.0.10/lib/asciidoctor/parser.rb:886:in 
> `next_block'
>        # 
> /usr/share/gems/gems/asciidoctor-2.0.10/lib/asciidoctor/parser.rb:379:in 
> `next_section'
>        # 
> /usr/share/gems/gems/asciidoctor-2.0.10/lib/asciidoctor/parser.rb:364:in 
> `next_section'
>        # 
> /usr/share/gems/gems/asciidoctor-2.0.10/lib/asciidoctor/parser.rb:97:in 
> `parse'
>        # 
> /usr/share/gems/gems/asciidoctor-2.0.10/lib/asciidoctor/document.rb:549:in 
> `parse'
>        # 
> /usr/share/gems/gems/asciidoctor-2.0.10/lib/asciidoctor/load.rb:83:in 
> `load'
>        # ./spec/test_helper.rb:70:in `load_asciidoc'
>        # ./spec/shared_examples.rb:592:in `block (2 levels) in <top 
> (required)>'
>        # ./spec/test_helper.rb:112:in `block (3 levels) in <top 
> (required)>'
>        # ./spec/test_helper.rb:111:in `chdir'
>        # ./spec/test_helper.rb:111:in `block (2 levels) in <top 
> (required)>'
>        # ------------------
>        # --- Caused by: ---
>        # RuntimeError:
>        #   Could not find the 'WaveDromEditor' executable in PATH; add 
> it to the PATH or specify its location using the 'WaveDromEditor' 
> document attribute
>        #   ./lib/asciidoctor-diagram/diagram_source.rb:130:in 
> `find_command'
>
> -- 
> Christopher Brown
>
> ruby-sig mailing list -- [e-mail]
> To unsubscribe send an email to [e-mail]
> Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
> List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
> List Archives: https://lists.fedoraproject.org/archives/list/[e-mail].o...

[Christopher Brown]

Ok, thanks Vit.

I think I'll probably do the same.

I don't have the bandwidth to take on the maintenance of that number of
packages right now unless anyone else is interested in sharing the work?

On Tue, 27 Oct 2020 at 16:52, Vít Ondruch  wrote:
> When we tried to get ascii_binder into Fedora, we get this far with
> asciidoctor-diagram.
>
> https://fedorapeople.org/cgit/jackorp/public_git/rubygem-asciidoctor-diagram...
>
> But we rather avoided the dependency in ascii_binder for the time being:
>
> https://src.fedoraproject.org/rpms/rubygem-ascii_binder/blob/0d17b858e07ea9d...
>
> Vít
>
> Dne 27. 10. 20 v 17:31 Christopher Brown napsal(a):
>
> Hello,
>
> I've upgrade to F33 and discovered that we are missing asciidoctor-diagram
> as a requirement for some internal tooling.
>
> https://rubygems.org/gems/asciidoctor-diagram/
> https://github.com/asciidoctor/asciidoctor-diagram
>
> I am putting together a spec file for this now however tests are failing
> with missing executables in the path. I am able to work around some by
> installing the package but the majority we don't appear to ship packages
> for - see example below.
>
> Again, I'm sure this is something obvious (hopefully) and would appreciate
> a steer in the right direction. I've attempted to pass various options to
> rspec but to no avail.
>
> Thanks for any advice in advance.
> Asciidoctor::Diagram::WavedromBlockProcessor should support scaling
>
> diagrams
>        Failure/Error: raise "Could not find the #{cmd_names.map { |c|
> "'#{c}'" }.join(', ')} executable in PATH; add it to the PATH or specify
> its location using the '#{attr_names[0]}' document attribute"
>    RuntimeError:
>      asciidoctor: FAILED: <stdin>: Failed to load AsciiDoc document -
>
> Could not find the 'WaveDromEditor' executable in PATH; add it to the PATH
> or specify its location using the 'WaveDromEditor' document attribute
>        Shared Example Group: "block" called from ./spec/wavedrom_spec.rb:16
>        # ./lib/asciidoctor-diagram/diagram_source.rb:130:in `find_command'
>        # ./lib/asciidoctor-diagram/wavedrom/converter.rb:39:in `convert'
>        # ./lib/asciidoctor-diagram/diagram_processor.rb:170:in
> `create_image_block'
>        # ./lib/asciidoctor-diagram/diagram_processor.rb:86:in `process'
>        #
> /usr/share/gems/gems/asciidoctor-2.0.10/lib/asciidoctor/parser.rb:1040:in
> `[]'
>        #
> /usr/share/gems/gems/asciidoctor-2.0.10/lib/asciidoctor/parser.rb:1040:in
> `build_block'
>        #
> /usr/share/gems/gems/asciidoctor-2.0.10/lib/asciidoctor/parser.rb:886:in
> `next_block'
>        #
> /usr/share/gems/gems/asciidoctor-2.0.10/lib/asciidoctor/parser.rb:379:in
> `next_section'
>        #
> /usr/share/gems/gems/asciidoctor-2.0.10/lib/asciidoctor/parser.rb:364:in
> `next_section'
>        #
> /usr/share/gems/gems/asciidoctor-2.0.10/lib/asciidoctor/parser.rb:97:in
> `parse'
>        #
> /usr/share/gems/gems/asciidoctor-2.0.10/lib/asciidoctor/document.rb:549:in
> `parse'
>        #
> /usr/share/gems/gems/asciidoctor-2.0.10/lib/asciidoctor/load.rb:83:in `load'
>        # ./spec/test_helper.rb:70:in `load_asciidoc'
>        # ./spec/shared_examples.rb:592:in `block (2 levels) in <top
> (required)>'
>        # ./spec/test_helper.rb:112:in `block (3 levels) in <top
> (required)>'
>        # ./spec/test_helper.rb:111:in `chdir'
>        # ./spec/test_helper.rb:111:in `block (2 levels) in <top
> (required)>'
>        # ------------------
>        # --- Caused by: ---
>        # RuntimeError:
>        #   Could not find the 'WaveDromEditor' executable in PATH; add it
> to the PATH or specify its location using the 'WaveDromEditor' document
> attribute
>        #   ./lib/asciidoctor-diagram/diagram_source.rb:130:in
> `find_command'
>
> --
> Christopher Brown
>
> ruby-sig mailing list -- [e-mail]
> To unsubscribe send an email to [e-mail]
> Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
> List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
> List Archives: https://lists.fedoraproject.org/archives/list/[e-mail].o...
>
> ruby-sig mailing list -- [e-mail]
> To unsubscribe send an email to [e-mail]
> Fedora Code of Conduct:
> https://docs.fedoraproject.org/en-US/project/code-of-conduct/
> List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
> List Archives:
> https://lists.fedoraproject.org/archives/list/[e-mail].o...

[Dan Allen]

Christopher,

I would encourage you not to give up on Asciidoctor Diagram yet. I spoke
with Pepijn (https://github.com/pepijnve), the maintainer, and he told me
he would be glad to help you if you reached out (via the project issue
tracker). Just introduce yourself there so he knows who you are. He said he
is willing to change the code or build if necessary to get it packaged.

Although Asciidocotor Diagram bundles some of the diagram tools in the
published gem, it could be reconfigured / patched to look for those tools
from another place on the system. The only requirement is that it finds the
tool somewhere on the system so it can be invoked.

Best Regards,

-Dan

On Tue, Oct 27, 2020 at 11:38 AM Christopher Brown 
wrote:
> Ok, thanks Vit.
>
> I think I'll probably do the same.
>
> I don't have the bandwidth to take on the maintenance of that number of
> packages right now unless anyone else is interested in sharing the work?
>
> On Tue, 27 Oct 2020 at 16:52, Vít Ondruch  wrote:
> > When we tried to get ascii_binder into Fedora, we get this far with
> > asciidoctor-diagram.
> >
> > https://fedorapeople.org/cgit/jackorp/public_git/rubygem-asciidoctor-diagram...
> >
> > But we rather avoided the dependency in ascii_binder for the time being:
> >
> > https://src.fedoraproject.org/rpms/rubygem-ascii_binder/blob/0d17b858e07ea9d...
> >
> > Vít
> >
> > Dne 27. 10. 20 v 17:31 Christopher Brown napsal(a):
> >
> > Hello,
> >
> > I've upgrade to F33 and discovered that we are missing
> > asciidoctor-diagram as a requirement for some internal tooling.
> >
> > https://rubygems.org/gems/asciidoctor-diagram/
> > https://github.com/asciidoctor/asciidoctor-diagram
> >
> > I am putting together a spec file for this now however tests are failing
> > with missing executables in the path. I am able to work around some by
> > installing the package but the majority we don't appear to ship packages
> > for - see example below.
> >
> > Again, I'm sure this is something obvious (hopefully) and would
> > appreciate a steer in the right direction. I've attempted to pass various
> > options to rspec but to no avail.
> >
> > Thanks for any advice in advance.
> > Asciidoctor::Diagram::WavedromBlockProcessor should support
> >
> > scaling diagrams
> >        Failure/Error: raise "Could not find the #{cmd_names.map { |c|
> > "'#{c}'" }.join(', ')} executable in PATH; add it to the PATH or specify
> > its location using the '#{attr_names[0]}' document attribute"
> >    RuntimeError:
> >      asciidoctor: FAILED: <stdin>: Failed to load AsciiDoc document -
> >
> > Could not find the 'WaveDromEditor' executable in PATH; add it to the PATH
> > or specify its location using the 'WaveDromEditor' document attribute
> >        Shared Example Group: "block" called from
> > ./spec/wavedrom_spec.rb:16
> >        # ./lib/asciidoctor-diagram/diagram_source.rb:130:in `find_command'
> >        # ./lib/asciidoctor-diagram/wavedrom/converter.rb:39:in `convert'
> >        # ./lib/asciidoctor-diagram/diagram_processor.rb:170:in
> > `create_image_block'
> >        # ./lib/asciidoctor-diagram/diagram_processor.rb:86:in `process'
> >        #
> > /usr/share/gems/gems/asciidoctor-2.0.10/lib/asciidoctor/parser.rb:1040:in
> > `[]'
> >        #
> > /usr/share/gems/gems/asciidoctor-2.0.10/lib/asciidoctor/parser.rb:1040:in
> > `build_block'
> >        #
> > /usr/share/gems/gems/asciidoctor-2.0.10/lib/asciidoctor/parser.rb:886:in
> > `next_block'
> >        #
> > /usr/share/gems/gems/asciidoctor-2.0.10/lib/asciidoctor/parser.rb:379:in
> > `next_section'
> >        #
> > /usr/share/gems/gems/asciidoctor-2.0.10/lib/asciidoctor/parser.rb:364:in
> > `next_section'
> >        #
> > /usr/share/gems/gems/asciidoctor-2.0.10/lib/asciidoctor/parser.rb:97:in
> > `parse'
> >        #
> > /usr/share/gems/gems/asciidoctor-2.0.10/lib/asciidoctor/document.rb:549:in
> > `parse'
> >        #
> > /usr/share/gems/gems/asciidoctor-2.0.10/lib/asciidoctor/load.rb:83:in `load'
> >        # ./spec/test_helper.rb:70:in `load_asciidoc'
> >        # ./spec/shared_examples.rb:592:in `block (2 levels) in <top
> > (required)>'
> >        # ./spec/test_helper.rb:112:in `block (3 levels) in <top
> > (required)>'
> >        # ./spec/test_helper.rb:111:in `chdir'
> >        # ./spec/test_helper.rb:111:in `block (2 levels) in <top
> > (required)>'
> >        # ------------------
> >        # --- Caused by: ---
> >        # RuntimeError:
> >        #   Could not find the 'WaveDromEditor' executable in PATH; add it
> > to the PATH or specify its location using the 'WaveDromEditor' document
> > attribute
> >        #   ./lib/asciidoctor-diagram/diagram_source.rb:130:in
> > `find_command'
> >
> > --
> > Christopher Brown
> >
> > ruby-sig mailing list -- [e-mail]
> > To unsubscribe send an email to [e-mail]
> > Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
> > List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
> > List Archives: https://lists.fedoraproject.org/archives/list/[e-mail].o...
> >
> > ruby-sig mailing list -- [e-mail]
> > To unsubscribe send an email to [e-mail]
> > Fedora Code of Conduct:
> > https://docs.fedoraproject.org/en-US/project/code-of-conduct/
> > List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
> > List Archives:
> > https://lists.fedoraproject.org/archives/list/[e-mail].o...
>
> --
> Christopher Brown
> Senior Consultant
> Red Hat UK Ltd
> [e-mail]
> _______________________________________________
> ruby-sig mailing list -- [e-mail]
> To unsubscribe send an email to [e-mail]
> Fedora Code of Conduct:
> https://docs.fedoraproject.org/en-US/project/code-of-conduct/
> List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
> List Archives:
> https://lists.fedoraproject.org/archives/list/[e-mail].o...

[Christopher Brown]

Hi Dan,

Thanks for this. The issue I think is that there is a large number of
dependencies and AIUI, Fedora doesn't allow these to be bundled with the
gem[1]. This means a fairly significant task creating packages for a
variety of nodejs dependencies amongst other things, e.g. Vega[2] has a
fairly rapid release schedule.

The more I consider the situation, the more I'm thinking that rpm is not
the correct packaging format for asciidoctor-pdf and friends given their
long list of dependencies and that a better fit would be a containerised
deployment or perhaps flatpak/snap.

However I thought I'd put this out for further responses from anyone with a
vested interest.

1.
https://fedoraproject.org/wiki/Bundled_Libraries?rd=Packaging:Bundled_Librar...
2. https://github.com/vega/vega/tags

On Thu, 29 Oct 2020 at 20:28, Dan Allen  wrote:
> Christopher,
>
> I would encourage you not to give up on Asciidoctor Diagram yet. I spoke
> with Pepijn (https://github.com/pepijnve), the maintainer, and he told me
> he would be glad to help you if you reached out (via the project issue
> tracker). Just introduce yourself there so he knows who you are. He said he
> is willing to change the code or build if necessary to get it packaged.
>
> Although Asciidocotor Diagram bundles some of the diagram tools in the
> published gem, it could be reconfigured / patched to look for those tools
> from another place on the system. The only requirement is that it finds the
> tool somewhere on the system so it can be invoked.
>
> Best Regards,
>
> -Dan
>
> On Tue, Oct 27, 2020 at 11:38 AM Christopher Brown 
> wrote:
> > Ok, thanks Vit.
> >
> > I think I'll probably do the same.
> >
> > I don't have the bandwidth to take on the maintenance of that number of
> > packages right now unless anyone else is interested in sharing the work?
> >
> > On Tue, 27 Oct 2020 at 16:52, Vít Ondruch  wrote:
> > > When we tried to get ascii_binder into Fedora, we get this far with
> > > asciidoctor-diagram.
> > >
> > > https://fedorapeople.org/cgit/jackorp/public_git/rubygem-asciidoctor-diagram...
> > >
> > > But we rather avoided the dependency in ascii_binder for the time being:
> > >
> > > https://src.fedoraproject.org/rpms/rubygem-ascii_binder/blob/0d17b858e07ea9d...
> > >
> > > Vít
> > >
> > > Dne 27. 10. 20 v 17:31 Christopher Brown napsal(a):
> > >
> > > Hello,
> > >
> > > I've upgrade to F33 and discovered that we are missing
> > > asciidoctor-diagram as a requirement for some internal tooling.
> > >
> > > https://rubygems.org/gems/asciidoctor-diagram/
> > > https://github.com/asciidoctor/asciidoctor-diagram
> > >
> > > I am putting together a spec file for this now however tests are failing
> > > with missing executables in the path. I am able to work around some by
> > > installing the package but the majority we don't appear to ship packages
> > > for - see example below.
> > >
> > > Again, I'm sure this is something obvious (hopefully) and would
> > > appreciate a steer in the right direction. I've attempted to pass various
> > > options to rspec but to no avail.
> > >
> > > Thanks for any advice in advance.
> > > Asciidoctor::Diagram::WavedromBlockProcessor should support
> > >
> > > scaling diagrams
> > >        Failure/Error: raise "Could not find the #{cmd_names.map { |c|
> > > "'#{c}'" }.join(', ')} executable in PATH; add it to the PATH or specify
> > > its location using the '#{attr_names[0]}' document attribute"
> > >    RuntimeError:
> > >      asciidoctor: FAILED: <stdin>: Failed to load AsciiDoc document
> > > Could not find the 'WaveDromEditor' executable in PATH; add it to the
> > >
> > > PATH or specify its location using the 'WaveDromEditor' document attribute
> > >        Shared Example Group: "block" called from
> > > ./spec/wavedrom_spec.rb:16
> > >        # ./lib/asciidoctor-diagram/diagram_source.rb:130:in
> > > `find_command'
> > >        # ./lib/asciidoctor-diagram/wavedrom/converter.rb:39:in `convert'
> > >        # ./lib/asciidoctor-diagram/diagram_processor.rb:170:in
> > > `create_image_block'
> > >        # ./lib/asciidoctor-diagram/diagram_processor.rb:86:in `process'
> > >        #
> > > /usr/share/gems/gems/asciidoctor-2.0.10/lib/asciidoctor/parser.rb:1040:in
> > > `[]'
> > >        #
> > > /usr/share/gems/gems/asciidoctor-2.0.10/lib/asciidoctor/parser.rb:1040:in
> > > `build_block'
> > >        #
> > > /usr/share/gems/gems/asciidoctor-2.0.10/lib/asciidoctor/parser.rb:886:in
> > > `next_block'
> > >        #
> > > /usr/share/gems/gems/asciidoctor-2.0.10/lib/asciidoctor/parser.rb:379:in
> > > `next_section'
> > >        #
> > > /usr/share/gems/gems/asciidoctor-2.0.10/lib/asciidoctor/parser.rb:364:in
> > > `next_section'
> > >        #
> > > /usr/share/gems/gems/asciidoctor-2.0.10/lib/asciidoctor/parser.rb:97:in
> > > `parse'
> > >        #
> > > /usr/share/gems/gems/asciidoctor-2.0.10/lib/asciidoctor/document.rb:549:in
> > > `parse'
> > >        #
> > > /usr/share/gems/gems/asciidoctor-2.0.10/lib/asciidoctor/load.rb:83:in `load'
> > >        # ./spec/test_helper.rb:70:in `load_asciidoc'
> > >        # ./spec/shared_examples.rb:592:in `block (2 levels) in <top
> > > (required)>'
> > >        # ./spec/test_helper.rb:112:in `block (3 levels) in <top
> > > (required)>'
> > >        # ./spec/test_helper.rb:111:in `chdir'
> > >        # ./spec/test_helper.rb:111:in `block (2 levels) in <top
> > > (required)>'
> > >        # ------------------
> > >        # --- Caused by: ---
> > >        # RuntimeError:
> > >        #   Could not find the 'WaveDromEditor' executable in PATH; add
> > > it to the PATH or specify its location using the 'WaveDromEditor' document
> > > attribute
> > >        #   ./lib/asciidoctor-diagram/diagram_source.rb:130:in
> > > `find_command'
> > >
> > > --
> > > Christopher Brown
> > >
> > > ruby-sig mailing list -- [e-mail]
> > > To unsubscribe send an email to [e-mail]
> > > Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
> > > List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
> > > List Archives: https://lists.fedoraproject.org/archives/list/[e-mail].o...
> > >
> > > ruby-sig mailing list -- [e-mail]
> > > To unsubscribe send an email to [e-mail]
> > > Fedora Code of Conduct:
> > > https://docs.fedoraproject.org/en-US/project/code-of-conduct/
> > > List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
> > > List Archives:
> > > https://lists.fedoraproject.org/archives/list/[e-mail].o...
> >
> > --
> > Christopher Brown
> > Senior Consultant
> > Red Hat UK Ltd
> > [e-mail]
> > _______________________________________________
> > ruby-sig mailing list -- [e-mail]
> > To unsubscribe send an email to [e-mail]
> > Fedora Code of Conduct:
> > https://docs.fedoraproject.org/en-US/project/code-of-conduct/
> > List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
> > List Archives:
> > https://lists.fedoraproject.org/archives/list/[e-mail].o...
>
> --
> Dan Allen (he, him, his) | @mojavelinux | https://twitter.com/mojavelinux
> _______________________________________________
> ruby-sig mailing list -- [e-mail]
> To unsubscribe send an email to [e-mail]
> Fedora Code of Conduct:
> https://docs.fedoraproject.org/en-US/project/code-of-conduct/
> List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
> List Archives:
> https://lists.fedoraproject.org/archives/list/[e-mail].o...

[Vít Ondruch]

Unfortunately, there is not right or wrong format. It is just about 
critical mass. If you create flatpak/snap instead, you won't benefit 
from fixes possibly provided by other packagers. While if there is not 
enough packagers, it is certainly annoying to be the one to take care 
about everything.

Vít

Dne 02. 11. 20 v 16:41 Christopher Brown napsal(a):
> Hi Dan,
>
> Thanks for this. The issue I think is that there is a large number of 
> dependencies and AIUI, Fedora doesn't allow these to be bundled with 
> the gem[1]. This means a fairly significant task creating packages for 
> a variety of nodejs dependencies amongst other things, e.g. Vega[2] 
> has a fairly rapid release schedule.
>
> The more I consider the situation, the more I'm thinking that rpm is 
> not the correct packaging format for asciidoctor-pdf and friends given 
> their long list of dependencies and that a better fit would be a 
> containerised deployment or perhaps flatpak/snap.
>
> However I thought I'd put this out for further responses from anyone 
> with a vested interest.
>
> https://fedoraproject.org/wiki/Bundled_Libraries?rd=Packaging:Bundled_Librar... 
> https://fedoraproject.org/wiki/Bundled_Libraries?rd=Packaging:Bundled_Libraries
> 2. https://github.com/vega/vega/tags https://github.com/vega/vega/tags
>
> On Thu, 29 Oct 2020 at 20:28, Dan Allen <[e-mail] 
> > wrote:
> Christopher,
>
> I would encourage you not to give up on Asciidoctor Diagram yet. I
> spoke with Pepijn (https://github.com/pepijnve
> <https://github.com/pepijnve>), the maintainer, and he told me he
> would be glad to help you if you reached out (via the project
> issue tracker). Just introduce yourself there so he knows who you
> are. He said he is willing to change the code or build if
> necessary to get it packaged.
>
> Although Asciidocotor Diagram bundles some of the diagram tools in
> the published gem, it could be reconfigured / patched to look for
> those tools from another place on the system. The only requirement
> is that it finds the tool somewhere on the system so it can be
> invoked.
>
> Best Regards,
>
> -Dan
>
> On Tue, Oct 27, 2020 at 11:38 AM Christopher Brown
> <[e-mail] <mailto:[e-mail]>> wrote:
>
>     Ok, thanks Vit.
>
>     I think I'll probably do the same.
>
>     I don't have the bandwidth to take on the maintenance of that
>     number of packages right now unless anyone else is interested
>     in sharing the work?
>
>     On Tue, 27 Oct 2020 at 16:52, Vít Ondruch <[e-mail]
>     <mailto:[e-mail]>> wrote:
>
>         When we tried to get ascii_binder into Fedora, we get this
>         far with asciidoctor-diagram.
>
>         https://fedorapeople.org/cgit/jackorp/public_git/rubygem-asciidoctor-diagram.git/tree/rubygem-asciidoctor-diagram.spec
>         <https://fedorapeople.org/cgit/jackorp/public_git/rubygem-asciidoctor-diagram.git/tree/rubygem-asciidoctor-diagram.spec>
>
>         But we rather avoided the dependency in ascii_binder for
>         the time being:
>
>         https://src.fedoraproject.org/rpms/rubygem-ascii_binder/blob/0d17b858e07ea9dca5a18f9f39554ef586caa883/f/rubygem-ascii_binder.spec#_45
>         <https://src.fedoraproject.org/rpms/rubygem-ascii_binder/blob/0d17b858e07ea9dca5a18f9f39554ef586caa883/f/rubygem-ascii_binder.spec#_45>
>
>
>         Vít
>
>
>         Dne 27. 10. 20 v 17:31 Christopher Brown napsal(a):
> >         Hello,
> >
> >         I've upgrade to F33 and discovered that we are missing
> >         asciidoctor-diagram as a requirement for some internal
> >         tooling.
> >
> >         https://rubygems.org/gems/asciidoctor-diagram/
> >         <https://rubygems.org/gems/asciidoctor-diagram/>
> >         https://github.com/asciidoctor/asciidoctor-diagram
> >         <https://github.com/asciidoctor/asciidoctor-diagram>
> >
> >         I am putting together a spec file for this now however
> >         tests are failing with missing executables in the path. I
> >         am able to work around some by installing the package but
> >         the majority we don't appear to ship packages for - see
> >         example below.
> >
> >         Again, I'm sure this is something obvious (hopefully) and
> >         would appreciate a steer in the right direction. I've
> >         attempted to pass various options to rspec but to no avail.
> >
> >         Thanks for any advice in advance.
> >
> >           425) Asciidoctor::Diagram::WavedromBlockProcessor
> >         should support scaling diagrams
> >                Failure/Error: raise "Could not find the
> >         #{cmd_names.map { |c| "'#{c}'" }.join(', ')} executable
> >         in PATH; add it to the PATH or specify its location using
> >         the '#{attr_names[0]}' document attribute"
> >
> >                RuntimeError:
> >                  asciidoctor: FAILED: <stdin>: Failed to load
> >         AsciiDoc document - Could not find the 'WaveDromEditor'
> >         executable in PATH; add it to the PATH or specify its
> >         location using the 'WaveDromEditor' document attribute
> >                Shared Example Group: "block" called from
> >         ./spec/wavedrom_spec.rb:16
> >                #
> >         ./lib/asciidoctor-diagram/diagram_source.rb:130:in
> >         `find_command'
> >                #
> >         ./lib/asciidoctor-diagram/wavedrom/converter.rb:39:in
> >         `convert'
> >                #
> >         ./lib/asciidoctor-diagram/diagram_processor.rb:170:in
> >         `create_image_block'
> >                #
> >         ./lib/asciidoctor-diagram/diagram_processor.rb:86:in
> >         `process'
> >                #
> >         /usr/share/gems/gems/asciidoctor-2.0.10/lib/asciidoctor/parser.rb:1040:in
> >         `[]'
> >                #
> >         /usr/share/gems/gems/asciidoctor-2.0.10/lib/asciidoctor/parser.rb:1040:in
> >         `build_block'
> >                #
> >         /usr/share/gems/gems/asciidoctor-2.0.10/lib/asciidoctor/parser.rb:886:in
> >         `next_block'
> >                #
> >         /usr/share/gems/gems/asciidoctor-2.0.10/lib/asciidoctor/parser.rb:379:in
> >         `next_section'
> >                #
> >         /usr/share/gems/gems/asciidoctor-2.0.10/lib/asciidoctor/parser.rb:364:in
> >         `next_section'
> >                #
> >         /usr/share/gems/gems/asciidoctor-2.0.10/lib/asciidoctor/parser.rb:97:in
> >         `parse'
> >                #
> >         /usr/share/gems/gems/asciidoctor-2.0.10/lib/asciidoctor/document.rb:549:in
> >         `parse'
> >                #
> >         /usr/share/gems/gems/asciidoctor-2.0.10/lib/asciidoctor/load.rb:83:in
> >         `load'
> >                # ./spec/test_helper.rb:70:in `load_asciidoc'
> >                # ./spec/shared_examples.rb:592:in `block (2
> >         levels) in <top (required)>'
> >                # ./spec/test_helper.rb:112:in `block (3 levels)
> >         in <top (required)>'
> >                # ./spec/test_helper.rb:111:in `chdir'
> >                # ./spec/test_helper.rb:111:in `block (2 levels)
> >         in <top (required)>'
> >                # ------------------
> >                # --- Caused by: ---
> >                # RuntimeError:
> >                #   Could not find the 'WaveDromEditor' executable
> >         in PATH; add it to the PATH or specify its location using
> >         the 'WaveDromEditor' document attribute
> >                #
> >         ./lib/asciidoctor-diagram/diagram_source.rb:130:in
> >         `find_command'
> >
> >         -- 
> >         Christopher Brown
> >
> >
> >         _______________________________________________
> >         ruby-sig mailing list [e-mail]  <mailto:[e-mail]>
> >         To unsubscribe send an email [e-mail]  <mailto:[e-mail]>
> >         Fedora Code of Conduct:https://docs.fedoraproject.org/en-US/project/code-of-conduct/  <https://docs.fedoraproject.org/en-US/project/code-of-conduct/>
> >         List Guidelines:https://fedoraproject.org/wiki/Mailing_list_guidelines  <https://fedoraproject.org/wiki/Mailing_list_guidelines>
> >         List Archives:https://lists.fedoraproject.org/archives/list/[e-mail]  <https://lists.fedoraproject.org/archives/list/[e-mail]>
>         _______________________________________________
>         ruby-sig mailing list -- [e-mail]
>         <mailto:[e-mail]>
>         To unsubscribe send an email to
>         [e-mail]
>         <mailto:[e-mail]>
>         Fedora Code of Conduct:
>         https://docs.fedoraproject.org/en-US/project/code-of-conduct/
>         <https://docs.fedoraproject.org/en-US/project/code-of-conduct/>
>         List Guidelines:
>         https://fedoraproject.org/wiki/Mailing_list_guidelines
>         <https://fedoraproject.org/wiki/Mailing_list_guidelines>
>         List Archives:
>         https://lists.fedoraproject.org/archives/list/[e-mail]
>         <https://lists.fedoraproject.org/archives/list/[e-mail]>
>
>
>
>     -- 
>     Christopher Brown
>     Senior Consultant
>     Red Hat UK Ltd
>     [e-mail] <mailto:[e-mail]>
>     _______________________________________________
>     ruby-sig mailing list -- [e-mail]
>     <mailto:[e-mail]>
>     To unsubscribe send an email to
>     [e-mail]
>     <mailto:[e-mail]>
>     Fedora Code of Conduct:
>     https://docs.fedoraproject.org/en-US/project/code-of-conduct/
>     <https://docs.fedoraproject.org/en-US/project/code-of-conduct/>
>     List Guidelines:
>     https://fedoraproject.org/wiki/Mailing_list_guidelines
>     <https://fedoraproject.org/wiki/Mailing_list_guidelines>
>     List Archives:
>     https://lists.fedoraproject.org/archives/list/[e-mail]
>     <https://lists.fedoraproject.org/archives/list/[e-mail]>
>
>
>
> -- 
> Dan Allen (he, him, his) | @mojavelinux |
> https://twitter.com/mojavelinux <https://twitter.com/mojavelinux>
> _______________________________________________
> ruby-sig mailing list -- [e-mail]
> <mailto:[e-mail]>
> To unsubscribe send an email to
> [e-mail]
> <mailto:[e-mail]>
> Fedora Code of Conduct:
> https://docs.fedoraproject.org/en-US/project/code-of-conduct/
> <https://docs.fedoraproject.org/en-US/project/code-of-conduct/>
> List Guidelines:
> https://fedoraproject.org/wiki/Mailing_list_guidelines
> <https://fedoraproject.org/wiki/Mailing_list_guidelines>
> List Archives:
> https://lists.fedoraproject.org/archives/list/[e-mail]
> <https://lists.fedoraproject.org/archives/list/[e-mail]>
>
>
>
> -- 
> Christopher Brown
> Senior Consultant
> Red Hat UK Ltd
> [e-mail]
>
> ruby-sig mailing list -- [e-mail]
> To unsubscribe send an email to [e-mail]
> Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
> List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
> List Archives: https://lists.fedoraproject.org/archives/list/[e-mail].o...

[Dan Allen]

Christopher,

I understand your point. But please consider the fact that many of the
diagramming tool integrations that Asciidoctor Diagram provides are
optional (and thus there is no reason to bundle them). If the tool is not
there, then it simply cannot be used in the document. The "core" ones are
graphviz, plantuml, and blockdiag, which are already packaged for Fedora. I
would focus on those to start. Worry about the long tail later (if ever).

Best Regards,

-Dan

On Mon, Nov 2, 2020 at 8:41 AM Christopher Brown 
wrote:
> Hi Dan,
>
> Thanks for this. The issue I think is that there is a large number of
> dependencies and AIUI, Fedora doesn't allow these to be bundled with the
> gem[1]. This means a fairly significant task creating packages for a
> variety of nodejs dependencies amongst other things, e.g. Vega[2] has a
> fairly rapid release schedule.
>
> The more I consider the situation, the more I'm thinking that rpm is not
> the correct packaging format for asciidoctor-pdf and friends given their
> long list of dependencies and that a better fit would be a containerised
> deployment or perhaps flatpak/snap.
>
> However I thought I'd put this out for further responses from anyone with
> a vested interest.
>
> https://fedoraproject.org/wiki/Bundled_Libraries?rd=Packaging:Bundled_Librar...
> 2. https://github.com/vega/vega/tags
>
> On Thu, 29 Oct 2020 at 20:28, Dan Allen  wrote:
> > Christopher,
> >
> > I would encourage you not to give up on Asciidoctor Diagram yet. I spoke
> > with Pepijn (https://github.com/pepijnve), the maintainer, and he told
> > me he would be glad to help you if you reached out (via the project issue
> > tracker). Just introduce yourself there so he knows who you are. He said he
> > is willing to change the code or build if necessary to get it packaged.
> >
> > Although Asciidocotor Diagram bundles some of the diagram tools in the
> > published gem, it could be reconfigured / patched to look for those tools
> > from another place on the system. The only requirement is that it finds the
> > tool somewhere on the system so it can be invoked.
> >
> > Best Regards,
> >
> > -Dan
> >
> > On Tue, Oct 27, 2020 at 11:38 AM Christopher Brown <
> > [e-mail]> wrote:
> > > Ok, thanks Vit.
> > >
> > > I think I'll probably do the same.
> > >
> > > I don't have the bandwidth to take on the maintenance of that number of
> > > packages right now unless anyone else is interested in sharing the work?
> > >
> > > On Tue, 27 Oct 2020 at 16:52, Vít Ondruch  wrote:
> > > > When we tried to get ascii_binder into Fedora, we get this far with
> > > > asciidoctor-diagram.
> > > >
> > > > https://fedorapeople.org/cgit/jackorp/public_git/rubygem-asciidoctor-diagram...
> > > >
> > > > But we rather avoided the dependency in ascii_binder for the time being:
> > > >
> > > > https://src.fedoraproject.org/rpms/rubygem-ascii_binder/blob/0d17b858e07ea9d...
> > > >
> > > > Vít
> > > >
> > > > Dne 27. 10. 20 v 17:31 Christopher Brown napsal(a):
> > > >
> > > > Hello,
> > > >
> > > > I've upgrade to F33 and discovered that we are missing
> > > > asciidoctor-diagram as a requirement for some internal tooling.
> > > >
> > > > https://rubygems.org/gems/asciidoctor-diagram/
> > > > https://github.com/asciidoctor/asciidoctor-diagram
> > > >
> > > > I am putting together a spec file for this now however tests are
> > > > failing with missing executables in the path. I am able to work around some
> > > > by installing the package but the majority we don't appear to ship packages
> > > > for - see example below.
> > > >
> > > > Again, I'm sure this is something obvious (hopefully) and would
> > > > appreciate a steer in the right direction. I've attempted to pass various
> > > > options to rspec but to no avail.
> > > >
> > > > Thanks for any advice in advance.
> > > > Asciidoctor::Diagram::WavedromBlockProcessor should support
> > > >
> > > > scaling diagrams
> > > >        Failure/Error: raise "Could not find the #{cmd_names.map { |c|
> > > > "'#{c}'" }.join(', ')} executable in PATH; add it to the PATH or specify
> > > > its location using the '#{attr_names[0]}' document attribute"
> > > >    RuntimeError:
> > > >      asciidoctor: FAILED: <stdin>: Failed to load AsciiDoc document
> > > > Could not find the 'WaveDromEditor' executable in PATH; add it to the
> > > >
> > > > PATH or specify its location using the 'WaveDromEditor' document attribute
> > > >        Shared Example Group: "block" called from
> > > > ./spec/wavedrom_spec.rb:16
> > > >        # ./lib/asciidoctor-diagram/diagram_source.rb:130:in
> > > > `find_command'
> > > >        # ./lib/asciidoctor-diagram/wavedrom/converter.rb:39:in `convert'
> > > >        # ./lib/asciidoctor-diagram/diagram_processor.rb:170:in
> > > > `create_image_block'
> > > >        # ./lib/asciidoctor-diagram/diagram_processor.rb:86:in `process'
> > > >        #
> > > > /usr/share/gems/gems/asciidoctor-2.0.10/lib/asciidoctor/parser.rb:1040:in
> > > > `[]'
> > > >        #
> > > > /usr/share/gems/gems/asciidoctor-2.0.10/lib/asciidoctor/parser.rb:1040:in
> > > > `build_block'
> > > >        #
> > > > /usr/share/gems/gems/asciidoctor-2.0.10/lib/asciidoctor/parser.rb:886:in
> > > > `next_block'
> > > >        #
> > > > /usr/share/gems/gems/asciidoctor-2.0.10/lib/asciidoctor/parser.rb:379:in
> > > > `next_section'
> > > >        #
> > > > /usr/share/gems/gems/asciidoctor-2.0.10/lib/asciidoctor/parser.rb:364:in
> > > > `next_section'
> > > >        #
> > > > /usr/share/gems/gems/asciidoctor-2.0.10/lib/asciidoctor/parser.rb:97:in
> > > > `parse'
> > > >        #
> > > > /usr/share/gems/gems/asciidoctor-2.0.10/lib/asciidoctor/document.rb:549:in
> > > > `parse'
> > > >        #
> > > > /usr/share/gems/gems/asciidoctor-2.0.10/lib/asciidoctor/load.rb:83:in `load'
> > > >        # ./spec/test_helper.rb:70:in `load_asciidoc'
> > > >        # ./spec/shared_examples.rb:592:in `block (2 levels) in <top
> > > > (required)>'
> > > >        # ./spec/test_helper.rb:112:in `block (3 levels) in <top
> > > > (required)>'
> > > >        # ./spec/test_helper.rb:111:in `chdir'
> > > >        # ./spec/test_helper.rb:111:in `block (2 levels) in <top
> > > > (required)>'
> > > >        # ------------------
> > > >        # --- Caused by: ---
> > > >        # RuntimeError:
> > > >        #   Could not find the 'WaveDromEditor' executable in PATH; add
> > > > it to the PATH or specify its location using the 'WaveDromEditor' document
> > > > attribute
> > > >        #   ./lib/asciidoctor-diagram/diagram_source.rb:130:in
> > > > `find_command'
> > > >
> > > > --
> > > > Christopher Brown
> > > >
> > > > ruby-sig mailing list -- [e-mail]
> > > > To unsubscribe send an email to [e-mail]
> > > > Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
> > > > List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
> > > > List Archives: https://lists.fedoraproject.org/archives/list/[e-mail].o...
> > > >
> > > > ruby-sig mailing list -- [e-mail]
> > > > To unsubscribe send an email to [e-mail]
> > > > Fedora Code of Conduct:
> > > > https://docs.fedoraproject.org/en-US/project/code-of-conduct/
> > > > List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
> > > > List Archives:
> > > > https://lists.fedoraproject.org/archives/list/[e-mail].o...
> > >
> > > --
> > > Christopher Brown
> > > Senior Consultant
> > > Red Hat UK Ltd
> > > [e-mail]
> > > _______________________________________________
> > > ruby-sig mailing list -- [e-mail]
> > > To unsubscribe send an email to [e-mail]
> > > Fedora Code of Conduct:
> > > https://docs.fedoraproject.org/en-US/project/code-of-conduct/
> > > List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
> > > List Archives:
> > > https://lists.fedoraproject.org/archives/list/[e-mail].o...
> >
> > --
> > Dan Allen (he, him, his) | @mojavelinux | https://twitter.com/mojavelinux
> > _______________________________________________
> > ruby-sig mailing list -- [e-mail]
> > To unsubscribe send an email to [e-mail]
> > Fedora Code of Conduct:
> > https://docs.fedoraproject.org/en-US/project/code-of-conduct/
> > List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
> > List Archives:
> > https://lists.fedoraproject.org/archives/list/[e-mail].o...
>
> --
> Christopher Brown
> Senior Consultant
> Red Hat UK Ltd
> [e-mail]
> _______________________________________________
> ruby-sig mailing list -- [e-mail]
> To unsubscribe send an email to [e-mail]
> Fedora Code of Conduct:
> https://docs.fedoraproject.org/en-US/project/code-of-conduct/
> List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
> List Archives:
> https://lists.fedoraproject.org/archives/list/[e-mail].o...

[Neal Gompa]

On Mon, Nov 2, 2020 at 10:41 AM Christopher Brown
 wrote:
> Hi Dan,
>
> Thanks for this. The issue I think is that there is a large number of dependencies and AIUI, Fedora doesn't allow these to be bundled with the gem[1]. This means a fairly significant task creating packages for a variety of nodejs dependencies amongst other things, e.g. Vega[2] has a fairly rapid release schedule.
>
> The more I consider the situation, the more I'm thinking that rpm is not the correct packaging format for asciidoctor-pdf and friends given their long list of dependencies and that a better fit would be a containerised deployment or perhaps flatpak/snap.
>
> However I thought I'd put this out for further responses from anyone with a vested interest.
> https://fedoraproject.org/wiki/Bundled_Libraries?rd=Packaging:Bundled_Librar...
> https://github.com/vega/vega/tags

Bundling Nodejs dependencies is perfectly fine. Most of us do that
now. Gem and C/C++ dependencies should not be bundled, though.

[Christopher Brown]

Neal, Dan,

Thanks both, I think we have a way forward. I'll start the dialog upstream.

@Neal - would it be possible to update the Fedora wiki regarding bundling
Nodejs deps? Not sure if it needs to be:

https://fedoraproject.org/wiki/Bundled_Libraries?rd=Packaging:Bundled_Librar...

or

https://fedoraproject.org/wiki/Packaging:Node.js

I'm unable to do so because I get the error message: "The action you have
requested is limited to users in the group: Packaging."

On Mon, 2 Nov 2020 at 22:06, Neal Gompa  wrote:
> On Mon, Nov 2, 2020 at 10:41 AM Christopher Brown
>  wrote:
> > Hi Dan,
> >
> > Thanks for this. The issue I think is that there is a large number of
>
> dependencies and AIUI, Fedora doesn't allow these to be bundled with the
> gem[1]. This means a fairly significant task creating packages for a
> variety of nodejs dependencies amongst other things, e.g. Vega[2] has a
> fairly rapid release schedule.
> > The more I consider the situation, the more I'm thinking that rpm is not
>
> the correct packaging format for asciidoctor-pdf and friends given their
> long list of dependencies and that a better fit would be a containerised
> deployment or perhaps flatpak/snap.
> > However I thought I'd put this out for further responses from anyone
>
> with a vested interest.
> >
>
> https://fedoraproject.org/wiki/Bundled_Libraries?rd=Packaging:Bundled_Librar...
> > https://github.com/vega/vega/tags
>
> Bundling Nodejs dependencies is perfectly fine. Most of us do that
> now. Gem and C/C++ dependencies should not be bundled, though.
>
> --
> 真実はいつも一つ！/ Always, there's only one truth!
> _______________________________________________
> ruby-sig mailing list -- [e-mail]
> To unsubscribe send an email to [e-mail]
> Fedora Code of Conduct:
> https://docs.fedoraproject.org/en-US/project/code-of-conduct/
> List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
> List Archives:
> https://lists.fedoraproject.org/archives/list/[e-mail].o...

[Christopher Brown]

Hi folks,

I've got a working build of asciidoctor-diagram ready for review:

https://bugzilla.redhat.com/show_bug.cgi?id=1897619

Spec file:

https://raw.githubusercontent.com/snecklifter/rubygem-asciidoctor-diagram/ma...

@Dan - this includes support for graphviz, plantuml, and blockdiag you
mentioned plus a few others that are already packaged.

Appreciate any eyes on this, particularly with regards to running rspec as
I'm specifically running just the tests for the attributes that are
available.

Regards
Christopher

On Tue, 3 Nov 2020 at 10:19, Christopher Brown 
wrote:
> Neal, Dan,
>
> Thanks both, I think we have a way forward. I'll start the dialog upstream.
>
> @Neal - would it be possible to update the Fedora wiki regarding bundling
> Nodejs deps? Not sure if it needs to be:
>
> https://fedoraproject.org/wiki/Bundled_Libraries?rd=Packaging:Bundled_Librar...
>
> or
>
> https://fedoraproject.org/wiki/Packaging:Node.js
>
> I'm unable to do so because I get the error message: "The action you have
> requested is limited to users in the group: Packaging."
>
> On Mon, 2 Nov 2020 at 22:06, Neal Gompa  wrote:
> > On Mon, Nov 2, 2020 at 10:41 AM Christopher Brown
> >  wrote:
> > > Hi Dan,
> > >
> > > Thanks for this. The issue I think is that there is a large number of
> >
> > dependencies and AIUI, Fedora doesn't allow these to be bundled with the
> > gem[1]. This means a fairly significant task creating packages for a
> > variety of nodejs dependencies amongst other things, e.g. Vega[2] has a
> > fairly rapid release schedule.
> > > The more I consider the situation, the more I'm thinking that rpm is
> >
> > not the correct packaging format for asciidoctor-pdf and friends given
> > their long list of dependencies and that a better fit would be a
> > containerised deployment or perhaps flatpak/snap.
> > > However I thought I'd put this out for further responses from anyone
> >
> > with a vested interest.
> > >
> >
> > https://fedoraproject.org/wiki/Bundled_Libraries?rd=Packaging:Bundled_Librar...
> > > https://github.com/vega/vega/tags
> >
> > Bundling Nodejs dependencies is perfectly fine. Most of us do that
> > now. Gem and C/C++ dependencies should not be bundled, though.
> >
> > --
> > 真実はいつも一つ！/ Always, there's only one truth!
> > _______________________________________________
> > ruby-sig mailing list -- [e-mail]
> > To unsubscribe send an email to [e-mail]
> > Fedora Code of Conduct:
> > https://docs.fedoraproject.org/en-US/project/code-of-conduct/
> > List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
> > List Archives:
> > https://lists.fedoraproject.org/archives/list/[e-mail].o...
>
> --
> Christopher Brown
> Senior Consultant
> Red Hat UK Ltd
> [e-mail]

[Vít Ondruch]

Dne 13. 11. 20 v 17:46 Christopher Brown napsal(a):
> Hi folks,
>
> I've got a working build of asciidoctor-diagram ready for review:
>
> https://bugzilla.redhat.com/show_bug.cgi?id=1897619 
> https://bugzilla.redhat.com/show_bug.cgi?id=1897619
>
> Spec file:
>
> https://raw.githubusercontent.com/snecklifter/rubygem-asciidoctor-diagram/ma... 
> https://raw.githubusercontent.com/snecklifter/rubygem-asciidoctor-diagram/master/rubygem-asciidoctor-diagram.spec
>
> @Dan - this includes support for graphviz, plantuml, and blockdiag you 
> mentioned plus a few others that are already packaged.
>
> Appreciate any eyes on this, particularly with regards to running 
> rspec as I'm specifically running just the tests for the attributes 
> that are available.

Wouldn't it be better to use exclude pattern instead of includes? Also, 
it would deserve some comments a top of the BRs you exclude as well as 
in the %check section. Maybe it'd better to use `bcond_with` to enable 
the rest of the test suite, because in theory, for testing in mock, it 
should be enough to have the missing pieces installed by hand. But since 
it'd make the .spec file more complex, feel free to ignore this 
suggestion ;)

Also, I'd the dependencies on binaries, such as `BuildRequires: 
%{_bindir}/graphviz`(this might be a wrong example, since you require 
the graphviz-ruby, but you get the point).

Vít
> Regards
> Christopher
>
> On Tue, 3 Nov 2020 at 10:19, Christopher Brown <[e-mail] 
> > wrote:
> Neal, Dan,
>
> Thanks both, I think we have a way forward. I'll start the dialog
> upstream.
>
> @Neal - would it be possible to update the Fedora wiki regarding
> bundling Nodejs deps? Not sure if it needs to be:
>
> https://fedoraproject.org/wiki/Bundled_Libraries?rd=Packaging:Bundled_Libraries
> <https://fedoraproject.org/wiki/Bundled_Libraries?rd=Packaging:Bundled_Libraries>
>
> or
>
> https://fedoraproject.org/wiki/Packaging:Node.js
> <https://fedoraproject.org/wiki/Packaging:Node.js>
>
> I'm unable to do so because I get the error message: "The action
> you have requested is limited to users in the group: Packaging."
>
> On Mon, 2 Nov 2020 at 22:06, Neal Gompa <[e-mail]
> <mailto:[e-mail]>> wrote:
>
>     On Mon, Nov 2, 2020 at 10:41 AM Christopher Brown
>     <[e-mail] <mailto:[e-mail]>> wrote:
>     >
>     > Hi Dan,
>     >
>     > Thanks for this. The issue I think is that there is a large
>     number of dependencies and AIUI, Fedora doesn't allow these to
>     be bundled with the gem[1]. This means a fairly significant
>     task creating packages for a variety of nodejs dependencies
>     amongst other things, e.g. Vega[2] has a fairly rapid release
>     schedule.
>     >
>     > The more I consider the situation, the more I'm thinking
>     that rpm is not the correct packaging format for
>     asciidoctor-pdf and friends given their long list of
>     dependencies and that a better fit would be a containerised
>     deployment or perhaps flatpak/snap.
>     >
>     > However I thought I'd put this out for further responses
>     from anyone with a vested interest.
>     >
>     > 1.
>     https://fedoraproject.org/wiki/Bundled_Libraries?rd=Packaging:Bundled_Libraries
>     <https://fedoraproject.org/wiki/Bundled_Libraries?rd=Packaging:Bundled_Libraries>
>     > 2. https://github.com/vega/vega/tags
>     <https://github.com/vega/vega/tags>
>     >
>
>     Bundling Nodejs dependencies is perfectly fine. Most of us do that
>     now. Gem and C/C++ dependencies should not be bundled, though.
>
>
>
>     -- 
>     真実はいつも一つ！/ Always, there's only one truth!
>     _______________________________________________
>     ruby-sig mailing list -- [e-mail]
>     <mailto:[e-mail]>
>     To unsubscribe send an email to
>     [e-mail]
>     <mailto:[e-mail]>
>     Fedora Code of Conduct:
>     https://docs.fedoraproject.org/en-US/project/code-of-conduct/
>     <https://docs.fedoraproject.org/en-US/project/code-of-conduct/>
>     List Guidelines:
>     https://fedoraproject.org/wiki/Mailing_list_guidelines
>     <https://fedoraproject.org/wiki/Mailing_list_guidelines>
>     List Archives:
>     https://lists.fedoraproject.org/archives/list/[e-mail]
>     <https://lists.fedoraproject.org/archives/list/[e-mail]>
>
>
>
> -- 
> Christopher Brown
> Senior Consultant
> Red Hat UK Ltd
> [e-mail] <mailto:[e-mail]>
>
>
>
> -- 
> Christopher Brown
> Senior Consultant
> Red Hat UK Ltd
> [e-mail]
>
> ruby-sig mailing list -- [e-mail]
> To unsubscribe send an email to [e-mail]
> Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
> List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
> List Archives: https://lists.fedoraproject.org/archives/list/[e-mail].o...

[Christopher Brown]

Hi Vit,

On Mon, 16 Nov 2020 at 09:54, Vít Ondruch  wrote:
> Dne 13. 11. 20 v 17:46 Christopher Brown napsal(a):
>
> Hi folks,
>
> I've got a working build of asciidoctor-diagram ready for review:
>
> https://bugzilla.redhat.com/show_bug.cgi?id=1897619
>
> Spec file:
>
> https://raw.githubusercontent.com/snecklifter/rubygem-asciidoctor-diagram/ma...
>
> @Dan - this includes support for graphviz, plantuml, and blockdiag you
> mentioned plus a few others that are already packaged.
>
> Appreciate any eyes on this, particularly with regards to running rspec as
> I'm specifically running just the tests for the attributes that are
> available.
>
> Wouldn't it be better to use exclude pattern instead of includes?

Done
> Also, it would deserve some comments a top of the BRs you exclude as well
> as in the %check section.

Done
> Maybe it'd better to use `bcond_with` to enable the rest of the test
> suite, because in theory, for testing in mock, it should be enough to have
> the missing pieces installed by hand. But since it'd make the .spec file
> more complex, feel free to ignore this suggestion ;)

Can you explain this a bit more? We are mostly missing nodejs extensions
but aside from invoking npm (which I don't think we do in builds ...) I
can't see how this would work?
> Also, I'd the dependencies on binaries, such as `BuildRequires:
> %{_bindir}/graphviz`(this might be a wrong example, since you require the
> graphviz-ruby, but you get the point).

I'll take a look at converting the spec file to this.

In the meantime, if anyone is able to do a review that would be good.
> Vít
>
> Regards
> Christopher
>
> On Tue, 3 Nov 2020 at 10:19, Christopher Brown 
> wrote:
> > Neal, Dan,
> >
> > Thanks both, I think we have a way forward. I'll start the dialog
> > upstream.
> >
> > @Neal - would it be possible to update the Fedora wiki regarding bundling
> > Nodejs deps? Not sure if it needs to be:
> >
> > https://fedoraproject.org/wiki/Bundled_Libraries?rd=Packaging:Bundled_Librar...
> >
> > or
> >
> > https://fedoraproject.org/wiki/Packaging:Node.js
> >
> > I'm unable to do so because I get the error message: "The action you have
> > requested is limited to users in the group: Packaging."
> >
> > On Mon, 2 Nov 2020 at 22:06, Neal Gompa  wrote:
> > > On Mon, Nov 2, 2020 at 10:41 AM Christopher Brown
> > >  wrote:
> > > > Hi Dan,
> > > >
> > > > Thanks for this. The issue I think is that there is a large number of
> > >
> > > dependencies and AIUI, Fedora doesn't allow these to be bundled with the
> > > gem[1]. This means a fairly significant task creating packages for a
> > > variety of nodejs dependencies amongst other things, e.g. Vega[2] has a
> > > fairly rapid release schedule.
> > > > The more I consider the situation, the more I'm thinking that rpm is
> > >
> > > not the correct packaging format for asciidoctor-pdf and friends given
> > > their long list of dependencies and that a better fit would be a
> > > containerised deployment or perhaps flatpak/snap.
> > > > However I thought I'd put this out for further responses from anyone
> > >
> > > with a vested interest.
> > > >
> > >
> > > https://fedoraproject.org/wiki/Bundled_Libraries?rd=Packaging:Bundled_Librar...
> > > > https://github.com/vega/vega/tags
> > >
> > > Bundling Nodejs dependencies is perfectly fine. Most of us do that
> > > now. Gem and C/C++ dependencies should not be bundled, though.
> > >
> > > --
> > > 真実はいつも一つ！/ Always, there's only one truth!
> > > _______________________________________________
> > > ruby-sig mailing list -- [e-mail]
> > > To unsubscribe send an email to [e-mail]
> > > Fedora Code of Conduct:
> > > https://docs.fedoraproject.org/en-US/project/code-of-conduct/
> > > List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
> > > List Archives:
> > > https://lists.fedoraproject.org/archives/list/[e-mail].o...
> >
> > --
> > Christopher Brown
> > Senior Consultant
> > Red Hat UK Ltd
> > [e-mail]
>
> --
> Christopher Brown
> Senior Consultant
> Red Hat UK Ltd
> [e-mail]
>
> ruby-sig mailing list -- [e-mail]
> To unsubscribe send an email to [e-mail]
> Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
> List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
> List Archives: https://lists.fedoraproject.org/archives/list/[e-mail].o...
>
> ruby-sig mailing list -- [e-mail]
> To unsubscribe send an email to [e-mail]
> Fedora Code of Conduct:
> https://docs.fedoraproject.org/en-US/project/code-of-conduct/
> List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
> List Archives:
> https://lists.fedoraproject.org/archives/list/[e-mail].o...

[Dan Allen]

Pepijn gives it the thumbs up too.

Best Regards,

-Dan

On Mon, Nov 16, 2020 at 11:01 AM Christopher Brown 
wrote:
> Hi Vit,
>
> On Mon, 16 Nov 2020 at 09:54, Vít Ondruch  wrote:
> > Dne 13. 11. 20 v 17:46 Christopher Brown napsal(a):
> >
> > Hi folks,
> >
> > I've got a working build of asciidoctor-diagram ready for review:
> >
> > https://bugzilla.redhat.com/show_bug.cgi?id=1897619
> >
> > Spec file:
> >
> > https://raw.githubusercontent.com/snecklifter/rubygem-asciidoctor-diagram/ma...
> >
> > @Dan - this includes support for graphviz, plantuml, and blockdiag you
> > mentioned plus a few others that are already packaged.
> >
> > Appreciate any eyes on this, particularly with regards to running rspec
> > as I'm specifically running just the tests for the attributes that are
> > available.
> >
> > Wouldn't it be better to use exclude pattern instead of includes?
>
> Done
> > Also, it would deserve some comments a top of the BRs you exclude as well
> > as in the %check section.
>
> Done
> > Maybe it'd better to use `bcond_with` to enable the rest of the test
> > suite, because in theory, for testing in mock, it should be enough to have
> > the missing pieces installed by hand. But since it'd make the .spec file
> > more complex, feel free to ignore this suggestion ;)
>
> Can you explain this a bit more? We are mostly missing nodejs extensions
> but aside from invoking npm (which I don't think we do in builds ...) I
> can't see how this would work?
> > Also, I'd the dependencies on binaries, such as `BuildRequires:
> > %{_bindir}/graphviz`(this might be a wrong example, since you require the
> > graphviz-ruby, but you get the point).
>
> I'll take a look at converting the spec file to this.
>
> In the meantime, if anyone is able to do a review that would be good.
> > Vít
> >
> > Regards
> > Christopher
> >
> > On Tue, 3 Nov 2020 at 10:19, Christopher Brown 
> > wrote:
> > > Neal, Dan,
> > >
> > > Thanks both, I think we have a way forward. I'll start the dialog
> > > upstream.
> > >
> > > @Neal - would it be possible to update the Fedora wiki regarding
> > > bundling Nodejs deps? Not sure if it needs to be:
> > >
> > > https://fedoraproject.org/wiki/Bundled_Libraries?rd=Packaging:Bundled_Librar...
> > >
> > > or
> > >
> > > https://fedoraproject.org/wiki/Packaging:Node.js
> > >
> > > I'm unable to do so because I get the error message: "The action you
> > > have requested is limited to users in the group: Packaging."
> > >
> > > On Mon, 2 Nov 2020 at 22:06, Neal Gompa  wrote:
> > > > On Mon, Nov 2, 2020 at 10:41 AM Christopher Brown
> > > >  wrote:
> > > > > Hi Dan,
> > > > >
> > > > > Thanks for this. The issue I think is that there is a large number of
> > > >
> > > > dependencies and AIUI, Fedora doesn't allow these to be bundled with the
> > > > gem[1]. This means a fairly significant task creating packages for a
> > > > variety of nodejs dependencies amongst other things, e.g. Vega[2] has a
> > > > fairly rapid release schedule.
> > > > > The more I consider the situation, the more I'm thinking that rpm is
> > > >
> > > > not the correct packaging format for asciidoctor-pdf and friends given
> > > > their long list of dependencies and that a better fit would be a
> > > > containerised deployment or perhaps flatpak/snap.
> > > > > However I thought I'd put this out for further responses from anyone
> > > >
> > > > with a vested interest.
> > > > >
> > > >
> > > > https://fedoraproject.org/wiki/Bundled_Libraries?rd=Packaging:Bundled_Librar...
> > > > > https://github.com/vega/vega/tags
> > > >
> > > > Bundling Nodejs dependencies is perfectly fine. Most of us do that
> > > > now. Gem and C/C++ dependencies should not be bundled, though.
> > > >
> > > > --
> > > > 真実はいつも一つ！/ Always, there's only one truth!
> > > > _______________________________________________
> > > > ruby-sig mailing list -- [e-mail]
> > > > To unsubscribe send an email to [e-mail]
> > > > Fedora Code of Conduct:
> > > > https://docs.fedoraproject.org/en-US/project/code-of-conduct/
> > > > List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
> > > > List Archives:
> > > > https://lists.fedoraproject.org/archives/list/[e-mail].o...
> > >
> > > --
> > > Christopher Brown
> > > Senior Consultant
> > > Red Hat UK Ltd
> > > [e-mail]
> >
> > --
> > Christopher Brown
> > Senior Consultant
> > Red Hat UK Ltd
> > [e-mail]
> >
> > ruby-sig mailing list -- [e-mail]
> > To unsubscribe send an email to [e-mail]
> > Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
> > List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
> > List Archives: https://lists.fedoraproject.org/archives/list/[e-mail].o...
> >
> > ruby-sig mailing list -- [e-mail]
> > To unsubscribe send an email to [e-mail]
> > Fedora Code of Conduct:
> > https://docs.fedoraproject.org/en-US/project/code-of-conduct/
> > List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
> > List Archives:
> > https://lists.fedoraproject.org/archives/list/[e-mail].o...
>
> --
> Christopher Brown
> Senior Consultant
> Red Hat UK Ltd
> [e-mail]
> _______________________________________________
> ruby-sig mailing list -- [e-mail]
> To unsubscribe send an email to [e-mail]
> Fedora Code of Conduct:
> https://docs.fedoraproject.org/en-US/project/code-of-conduct/
> List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
> List Archives:
> https://lists.fedoraproject.org/archives/list/[e-mail].o...

[Vít Ondruch]

I had something like this on my mind:

~~~

$ diff -u rubygem-asciidoctor-diagram.spec{,.orig}
--- rubygem-asciidoctor-diagram.spec    2020-11-18 10:07:55.687486987 +0100
+++ rubygem-asciidoctor-diagram.spec.orig    2020-11-18 
10:05:33.015423167 +0100
@@ -1,7 +1,5 @@
  %global gem_name asciidoctor-diagram

-%bcond_with missing_test_dependencies
-
  Name: rubygem-%{gem_name}
  Version: 2.0.5
  Release: 1%{?dist}
@@ -33,10 +31,6 @@
  BuildRequires: rubygem(prawn-svg)
  BuildRequires: rubygem(asciidoctor-pdf)
  BuildRequires: rubygem(bigdecimal)
-# Not packaged in Fedora.
-%if %{with missing_test_dependencies}
-BuildRequires: %{_bindir}/a2s
-%endif

BuildArch: noarch

@@ -67,14 +61,11 @@

%check
  # Run the test excluding extensions which are not packaged yet
-rspec \
-%if %{without missing_test_dependencies}
- --exclude-pattern 
'spec/{a2s_spec.rb,bpmn_spec.rb,bytefield_spec.rb,dpic_spec.rb,
+rspec --exclude-pattern 
'spec/{a2s_spec.rb,bpmn_spec.rb,bytefield_spec.rb,dpic_spec.rb,
erd_spec.rb,mermaid_spec.rb,nomnoml_spec.rb,pikchr_spec.rb,
umlet_spec.rb,vega_spec.rb,syntrax_spec.rb,
shaape_spec.rb,smcat_spec.rb,svgbob_spec.rb,
                           symbolator_spec.rb,wavedrom_spec.rb}'
-%endif

%files
  %dir %{gem_instdir}

~~~

This is not complete neither tested (I might have the bcond wrong). But 
the idea is, that you later run:

~~~

$ mock rubygem-asiidoctor-diagrem.srpm --with missing_test_dependencies

~~~

this will execute all the test cases (you can use the `--with` also with 
plain rpmbuild if I am not mistaken). So if you install the 
dependencies, such as a2s into mock via other means (you can run `mock 
shell` to prepare the environment), then you could execute the entire 
test suite.

Similar approach is used here for example:

https://src.fedoraproject.org/rpms/rubygem-mongo/blob/master/f/rubygem-mongo...

Since we don't have MongoDB in Fedora, we can't run the test suite 
during official build, but it is useful to execute it at leas locally 
during preparation of the update.

Vít

Dne 16. 11. 20 v 19:00 Christopher Brown napsal(a):
> Hi Vit,
>
> On Mon, 16 Nov 2020 at 09:54, Vít Ondruch <[e-mail] 
> > wrote:
> Dne 13. 11. 20 v 17:46 Christopher Brown napsal(a):
> > Hi folks,
> >
> > I've got a working build of asciidoctor-diagram ready for review:
> >
> > https://bugzilla.redhat.com/show_bug.cgi?id=1897619
> > <https://bugzilla.redhat.com/show_bug.cgi?id=1897619>
> >
> > Spec file:
> >
> > https://raw.githubusercontent.com/snecklifter/rubygem-asciidoctor-diagram/master/rubygem-asciidoctor-diagram.spec
> > <https://raw.githubusercontent.com/snecklifter/rubygem-asciidoctor-diagram/master/rubygem-asciidoctor-diagram.spec>
> >
> > @Dan - this includes support for graphviz, plantuml, and
> > blockdiag you mentioned plus a few others that are already packaged.
> >
> > Appreciate any eyes on this, particularly with regards to running
> > rspec as I'm specifically running just the tests for the
> > attributes that are available.
> Wouldn't it be better to use exclude pattern instead of includes?
>
> Done
> Also, it would deserve some comments a top of the BRs you exclude
> as well as in the %check section.
>
> Done
> Maybe it'd better to use `bcond_with` to enable the rest of the
> test suite, because in theory, for testing in mock, it should be
> enough to have the missing pieces installed by hand. But since
> it'd make the .spec file more complex, feel free to ignore this
> suggestion ;)
>
> Can you explain this a bit more? We are mostly missing nodejs 
> extensions but aside from invoking npm (which I don't think we do in 
> builds ...) I can't see how this would work?
> Also, I'd the dependencies on binaries, such as `BuildRequires:
> %{_bindir}/graphviz`(this might be a wrong example, since you
> require the graphviz-ruby, but you get the point).
>
> I'll take a look at converting the spec file to this.
>
> In the meantime, if anyone is able to do a review that would be good.
> Vít
>
>
> > Regards
> > Christopher
> >
> > On Tue, 3 Nov 2020 at 10:19, Christopher Brown
> > <[e-mail] <mailto:[e-mail]>> wrote:
> >
> >     Neal, Dan,
> >
> >     Thanks both, I think we have a way forward. I'll start the
> >     dialog upstream.
> >
> >     @Neal - would it be possible to update the Fedora wiki
> >     regarding bundling Nodejs deps? Not sure if it needs to be:
> >
> >     https://fedoraproject.org/wiki/Bundled_Libraries?rd=Packaging:Bundled_Libraries
> >     <https://fedoraproject.org/wiki/Bundled_Libraries?rd=Packaging:Bundled_Libraries>
> >
> >     or
> >
> >     https://fedoraproject.org/wiki/Packaging:Node.js
> >     <https://fedoraproject.org/wiki/Packaging:Node.js>
> >
> >     I'm unable to do so because I get the error message: "The
> >     action you have requested is limited to users in the group:
> >     Packaging."
> >
> >     On Mon, 2 Nov 2020 at 22:06, Neal Gompa <[e-mail]
> >     <mailto:[e-mail]>> wrote:
> >
> >         On Mon, Nov 2, 2020 at 10:41 AM Christopher Brown
> >         <[e-mail] <mailto:[e-mail]>>
> >         wrote:
> >         >
> >         > Hi Dan,
> >         >
> >         > Thanks for this. The issue I think is that there is a
> >         large number of dependencies and AIUI, Fedora doesn't
> >         allow these to be bundled with the gem[1]. This means a
> >         fairly significant task creating packages for a variety
> >         of nodejs dependencies amongst other things, e.g. Vega[2]
> >         has a fairly rapid release schedule.
> >         >
> >         > The more I consider the situation, the more I'm
> >         thinking that rpm is not the correct packaging format for
> >         asciidoctor-pdf and friends given their long list of
> >         dependencies and that a better fit would be a
> >         containerised deployment or perhaps flatpak/snap.
> >         >
> >         > However I thought I'd put this out for further
> >         responses from anyone with a vested interest.
> >         >
> >         > 1.
> >         https://fedoraproject.org/wiki/Bundled_Libraries?rd=Packaging:Bundled_Libraries
> >         <https://fedoraproject.org/wiki/Bundled_Libraries?rd=Packaging:Bundled_Libraries>
> >         > 2. https://github.com/vega/vega/tags
> >         <https://github.com/vega/vega/tags>
> >         >
> >
> >         Bundling Nodejs dependencies is perfectly fine. Most of
> >         us do that
> >         now. Gem and C/C++ dependencies should not be bundled,
> >         though.
> >
> >
> >
> >         -- 
> >         真実はいつも一つ！/ Always, there's only one truth!
> >         _______________________________________________
> >         ruby-sig mailing list -- [e-mail]
> >         <mailto:[e-mail]>
> >         To unsubscribe send an email to
> >         [e-mail]
> >         <mailto:[e-mail]>
> >         Fedora Code of Conduct:
> >         https://docs.fedoraproject.org/en-US/project/code-of-conduct/
> >         <https://docs.fedoraproject.org/en-US/project/code-of-conduct/>
> >         List Guidelines:
> >         https://fedoraproject.org/wiki/Mailing_list_guidelines
> >         <https://fedoraproject.org/wiki/Mailing_list_guidelines>
> >         List Archives:
> >         https://lists.fedoraproject.org/archives/list/[e-mail]
> >         <https://lists.fedoraproject.org/archives/list/[e-mail]>
> >
> >
> >
> >     -- 
> >     Christopher Brown
> >     Senior Consultant
> >     Red Hat UK Ltd
> >     [e-mail] <mailto:[e-mail]>
> >
> >
> >
> > -- 
> > Christopher Brown
> > Senior Consultant
> > Red Hat UK Ltd
> > [e-mail] <mailto:[e-mail]>
> >
> > _______________________________________________
> > ruby-sig mailing list [e-mail]  <mailto:[e-mail]>
> > To unsubscribe send an email [e-mail]  <mailto:[e-mail]>
> > Fedora Code of Conduct:https://docs.fedoraproject.org/en-US/project/code-of-conduct/  <https://docs.fedoraproject.org/en-US/project/code-of-conduct/>
> > List Guidelines:https://fedoraproject.org/wiki/Mailing_list_guidelines  <https://fedoraproject.org/wiki/Mailing_list_guidelines>
> > List Archives:https://lists.fedoraproject.org/archives/list/[e-mail]  <https://lists.fedoraproject.org/archives/list/[e-mail]>
> _______________________________________________
> ruby-sig mailing list -- [e-mail]
> <mailto:[e-mail]>
> To unsubscribe send an email to
> [e-mail]
> <mailto:[e-mail]>
> Fedora Code of Conduct:
> https://docs.fedoraproject.org/en-US/project/code-of-conduct/
> <https://docs.fedoraproject.org/en-US/project/code-of-conduct/>
> List Guidelines:
> https://fedoraproject.org/wiki/Mailing_list_guidelines
> <https://fedoraproject.org/wiki/Mailing_list_guidelines>
> List Archives:
> https://lists.fedoraproject.org/archives/list/[e-mail]
> <https://lists.fedoraproject.org/archives/list/[e-mail]>
>
>
>
> -- 
> Christopher Brown
> Senior Consultant
> Red Hat UK Ltd
> [e-mail]
>
> ruby-sig mailing list -- [e-mail]
> To unsubscribe send an email to [e-mail]
> Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
> List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
> List Archives: https://lists.fedoraproject.org/archives/list/[e-mail].o...

[Dan Allen]

Nice work Christopher! That looks good to me so far. I've notified Pepijn
of your progress to see if he has any comments.

Best Regards,

-Dan

On Fri, Nov 13, 2020 at 9:48 AM Christopher Brown 
wrote:
> Hi folks,
>
> I've got a working build of asciidoctor-diagram ready for review:
>
> https://bugzilla.redhat.com/show_bug.cgi?id=1897619
>
> Spec file:
>
> https://raw.githubusercontent.com/snecklifter/rubygem-asciidoctor-diagram/ma...
>
> @Dan - this includes support for graphviz, plantuml, and blockdiag you
> mentioned plus a few others that are already packaged.
>
> Appreciate any eyes on this, particularly with regards to running rspec as
> I'm specifically running just the tests for the attributes that are
> available.
>
> Regards
> Christopher
>
> On Tue, 3 Nov 2020 at 10:19, Christopher Brown 
> wrote:
> > Neal, Dan,
> >
> > Thanks both, I think we have a way forward. I'll start the dialog
> > upstream.
> >
> > @Neal - would it be possible to update the Fedora wiki regarding bundling
> > Nodejs deps? Not sure if it needs to be:
> >
> > https://fedoraproject.org/wiki/Bundled_Libraries?rd=Packaging:Bundled_Librar...
> >
> > or
> >
> > https://fedoraproject.org/wiki/Packaging:Node.js
> >
> > I'm unable to do so because I get the error message: "The action you have
> > requested is limited to users in the group: Packaging."
> >
> > On Mon, 2 Nov 2020 at 22:06, Neal Gompa  wrote:
> > > On Mon, Nov 2, 2020 at 10:41 AM Christopher Brown
> > >  wrote:
> > > > Hi Dan,
> > > >
> > > > Thanks for this. The issue I think is that there is a large number of
> > >
> > > dependencies and AIUI, Fedora doesn't allow these to be bundled with the
> > > gem[1]. This means a fairly significant task creating packages for a
> > > variety of nodejs dependencies amongst other things, e.g. Vega[2] has a
> > > fairly rapid release schedule.
> > > > The more I consider the situation, the more I'm thinking that rpm is
> > >
> > > not the correct packaging format for asciidoctor-pdf and friends given
> > > their long list of dependencies and that a better fit would be a
> > > containerised deployment or perhaps flatpak/snap.
> > > > However I thought I'd put this out for further responses from anyone
> > >
> > > with a vested interest.
> > > >
> > >
> > > https://fedoraproject.org/wiki/Bundled_Libraries?rd=Packaging:Bundled_Librar...
> > > > https://github.com/vega/vega/tags
> > >
> > > Bundling Nodejs dependencies is perfectly fine. Most of us do that
> > > now. Gem and C/C++ dependencies should not be bundled, though.
> > >
> > > --
> > > 真実はいつも一つ！/ Always, there's only one truth!
> > > _______________________________________________
> > > ruby-sig mailing list -- [e-mail]
> > > To unsubscribe send an email to [e-mail]
> > > Fedora Code of Conduct:
> > > https://docs.fedoraproject.org/en-US/project/code-of-conduct/
> > > List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
> > > List Archives:
> > > https://lists.fedoraproject.org/archives/list/[e-mail].o...
> >
> > --
> > Christopher Brown
> > Senior Consultant
> > Red Hat UK Ltd
> > [e-mail]
>
> --
> Christopher Brown
> Senior Consultant
> Red Hat UK Ltd
> [e-mail]
> _______________________________________________
> ruby-sig mailing list -- [e-mail]
> To unsubscribe send an email to [e-mail]
> Fedora Code of Conduct:
> https://docs.fedoraproject.org/en-US/project/code-of-conduct/
> List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
> List Archives:
> https://lists.fedoraproject.org/archives/list/[e-mail].o...

[Dan Allen]

Christopher,

I just noticed these lines in the spec file:

BuildRequires: rubygem(prawn-svg)
BuildRequires: rubygem(asciidoctor-pdf)

Asciidoctor Diagram does not depend on Asciidoctor PDF. It's an independent
extension that only depends on the main asciidoctor gem (in order to use
the extension API).

Best Regards,

-Dan

On Fri, Nov 13, 2020 at 9:48 AM Christopher Brown 
wrote:
> Hi folks,
>
> I've got a working build of asciidoctor-diagram ready for review:
>
> https://bugzilla.redhat.com/show_bug.cgi?id=1897619
>
> Spec file:
>
> https://raw.githubusercontent.com/snecklifter/rubygem-asciidoctor-diagram/ma...
>
> @Dan - this includes support for graphviz, plantuml, and blockdiag you
> mentioned plus a few others that are already packaged.
>
> Appreciate any eyes on this, particularly with regards to running rspec as
> I'm specifically running just the tests for the attributes that are
> available.
>
> Regards
> Christopher
>
> On Tue, 3 Nov 2020 at 10:19, Christopher Brown 
> wrote:
> > Neal, Dan,
> >
> > Thanks both, I think we have a way forward. I'll start the dialog
> > upstream.
> >
> > @Neal - would it be possible to update the Fedora wiki regarding bundling
> > Nodejs deps? Not sure if it needs to be:
> >
> > https://fedoraproject.org/wiki/Bundled_Libraries?rd=Packaging:Bundled_Librar...
> >
> > or
> >
> > https://fedoraproject.org/wiki/Packaging:Node.js
> >
> > I'm unable to do so because I get the error message: "The action you have
> > requested is limited to users in the group: Packaging."
> >
> > On Mon, 2 Nov 2020 at 22:06, Neal Gompa  wrote:
> > > On Mon, Nov 2, 2020 at 10:41 AM Christopher Brown
> > >  wrote:
> > > > Hi Dan,
> > > >
> > > > Thanks for this. The issue I think is that there is a large number of
> > >
> > > dependencies and AIUI, Fedora doesn't allow these to be bundled with the
> > > gem[1]. This means a fairly significant task creating packages for a
> > > variety of nodejs dependencies amongst other things, e.g. Vega[2] has a
> > > fairly rapid release schedule.
> > > > The more I consider the situation, the more I'm thinking that rpm is
> > >
> > > not the correct packaging format for asciidoctor-pdf and friends given
> > > their long list of dependencies and that a better fit would be a
> > > containerised deployment or perhaps flatpak/snap.
> > > > However I thought I'd put this out for further responses from anyone
> > >
> > > with a vested interest.
> > > >
> > >
> > > https://fedoraproject.org/wiki/Bundled_Libraries?rd=Packaging:Bundled_Librar...
> > > > https://github.com/vega/vega/tags
> > >
> > > Bundling Nodejs dependencies is perfectly fine. Most of us do that
> > > now. Gem and C/C++ dependencies should not be bundled, though.
> > >
> > > --
> > > 真実はいつも一つ！/ Always, there's only one truth!
> > > _______________________________________________
> > > ruby-sig mailing list -- [e-mail]
> > > To unsubscribe send an email to [e-mail]
> > > Fedora Code of Conduct:
> > > https://docs.fedoraproject.org/en-US/project/code-of-conduct/
> > > List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
> > > List Archives:
> > > https://lists.fedoraproject.org/archives/list/[e-mail].o...
> >
> > --
> > Christopher Brown
> > Senior Consultant
> > Red Hat UK Ltd
> > [e-mail]
>
> --
> Christopher Brown
> Senior Consultant
> Red Hat UK Ltd
> [e-mail]
> _______________________________________________
> ruby-sig mailing list -- [e-mail]
> To unsubscribe send an email to [e-mail]
> Fedora Code of Conduct:
> https://docs.fedoraproject.org/en-US/project/code-of-conduct/
> List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
> List Archives:
> https://lists.fedoraproject.org/archives/list/[e-mail].o...

[Christopher Brown]

Vit, Dan,

Thanks for the feedback, I have updated the spec file.

https://raw.githubusercontent.com/snecklifter/rubygem-asciidoctor-diagram/ma...

COPR:
https://copr.fedorainfracloud.org/coprs/snecker/rubygem-asciidoctor-diagram/

Would be good to get this approved in short order if anyone is able and
free to do so?

Regards
Chris

On Wed, 18 Nov 2020 at 20:13, Dan Allen  wrote:
> Christopher,
>
> I just noticed these lines in the spec file:
>
> BuildRequires: rubygem(prawn-svg)
> BuildRequires: rubygem(asciidoctor-pdf)
>
> Asciidoctor Diagram does not depend on Asciidoctor PDF. It's an
> independent extension that only depends on the main asciidoctor gem (in
> order to use the extension API).
>
> Best Regards,
>
> -Dan
>
> On Fri, Nov 13, 2020 at 9:48 AM Christopher Brown 
> wrote:
> > Hi folks,
> >
> > I've got a working build of asciidoctor-diagram ready for review:
> >
> > https://bugzilla.redhat.com/show_bug.cgi?id=1897619
> >
> > Spec file:
> >
> > https://raw.githubusercontent.com/snecklifter/rubygem-asciidoctor-diagram/ma...
> >
> > @Dan - this includes support for graphviz, plantuml, and blockdiag you
> > mentioned plus a few others that are already packaged.
> >
> > Appreciate any eyes on this, particularly with regards to running rspec
> > as I'm specifically running just the tests for the attributes that are
> > available.
> >
> > Regards
> > Christopher
> >
> > On Tue, 3 Nov 2020 at 10:19, Christopher Brown 
> > wrote:
> > > Neal, Dan,
> > >
> > > Thanks both, I think we have a way forward. I'll start the dialog
> > > upstream.
> > >
> > > @Neal - would it be possible to update the Fedora wiki regarding
> > > bundling Nodejs deps? Not sure if it needs to be:
> > >
> > > https://fedoraproject.org/wiki/Bundled_Libraries?rd=Packaging:Bundled_Librar...
> > >
> > > or
> > >
> > > https://fedoraproject.org/wiki/Packaging:Node.js
> > >
> > > I'm unable to do so because I get the error message: "The action you
> > > have requested is limited to users in the group: Packaging."
> > >
> > > On Mon, 2 Nov 2020 at 22:06, Neal Gompa  wrote:
> > > > On Mon, Nov 2, 2020 at 10:41 AM Christopher Brown
> > > >  wrote:
> > > > > Hi Dan,
> > > > >
> > > > > Thanks for this. The issue I think is that there is a large number of
> > > >
> > > > dependencies and AIUI, Fedora doesn't allow these to be bundled with the
> > > > gem[1]. This means a fairly significant task creating packages for a
> > > > variety of nodejs dependencies amongst other things, e.g. Vega[2] has a
> > > > fairly rapid release schedule.
> > > > > The more I consider the situation, the more I'm thinking that rpm is
> > > >
> > > > not the correct packaging format for asciidoctor-pdf and friends given
> > > > their long list of dependencies and that a better fit would be a
> > > > containerised deployment or perhaps flatpak/snap.
> > > > > However I thought I'd put this out for further responses from anyone
> > > >
> > > > with a vested interest.
> > > > >
> > > >
> > > > https://fedoraproject.org/wiki/Bundled_Libraries?rd=Packaging:Bundled_Librar...
> > > > > https://github.com/vega/vega/tags
> > > >
> > > > Bundling Nodejs dependencies is perfectly fine. Most of us do that
> > > > now. Gem and C/C++ dependencies should not be bundled, though.
> > > >
> > > > --
> > > > 真実はいつも一つ！/ Always, there's only one truth!
> > > > _______________________________________________
> > > > ruby-sig mailing list -- [e-mail]
> > > > To unsubscribe send an email to [e-mail]
> > > > Fedora Code of Conduct:
> > > > https://docs.fedoraproject.org/en-US/project/code-of-conduct/
> > > > List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
> > > > List Archives:
> > > > https://lists.fedoraproject.org/archives/list/[e-mail].o...
> > >
> > > --
> > > Christopher Brown
> > > Senior Consultant
> > > Red Hat UK Ltd
> > > [e-mail]
> >
> > --
> > Christopher Brown
> > Senior Consultant
> > Red Hat UK Ltd
> > [e-mail]
> > _______________________________________________
> > ruby-sig mailing list -- [e-mail]
> > To unsubscribe send an email to [e-mail]
> > Fedora Code of Conduct:
> > https://docs.fedoraproject.org/en-US/project/code-of-conduct/
> > List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
> > List Archives:
> > https://lists.fedoraproject.org/archives/list/[e-mail].o...
>
> --
> Dan Allen (he, him, his) | @mojavelinux | https://twitter.com/mojavelinux
> _______________________________________________
> ruby-sig mailing list -- [e-mail]
> To unsubscribe send an email to [e-mail]
> Fedora Code of Conduct:
> https://docs.fedoraproject.org/en-US/project/code-of-conduct/
> List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
> List Archives:
> https://lists.fedoraproject.org/archives/list/[e-mail].o...