Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=507501
Nicolas Mailhot nicolas.mailhot@laposte.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@fedoraproject.org |nicolas.mailhot@laposte.net Flag| |fedora-review?, | |needinfo?(radford@blackbean | |.org)
--- Comment #1 from Nicolas Mailhot nicolas.mailhot@laposte.net 2009-06-23 16:57:03 EDT --- Quick review:
1. The licensing code for OFL, is OFL, not SIL http://fedoraproject.org/wiki/Legal_considerations_for_fonts#Approved_font_l... W: invalid-license SIL
2. Please do not rename the ttf, it makes cross-distro checks easier when everyone is using the unmodified upstream filename
3. I don't think you win a lot by creating the fontconfig file dynamically instead of putting it as Source1. So I'd advise against it. But I won't block the review on this
4. Please use a leading capital A in the summary inkboy-fonts.noarch: W: summary-not-capitalized a clean and usable latin fantasy font
5. Please correct the documentation end of lines inkboy-fonts.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/inkboy-fonts-20070624/OFL.txt inkboy-fonts.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/inkboy-fonts-20070624/FONTLOG.txt
6. Please correct the documentation encoding file-not-utf8 /usr/share/doc/inkboy-fonts-20070624/FONTLOG.txt
You have examples of encoding and EOL fixup in the andika spec http://cvs.fedoraproject.org/viewvc/devel/sil-andika-fonts/sil-andika-fonts....
(of course you need to adapt the source encoding passed to iconv to your file)
Apart from that, the spec seems clean and fine
fonts-bugs@lists.fedoraproject.org